-
Notifications
You must be signed in to change notification settings - Fork 75
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Full stack/feature-branch-botonic1.0 #1700
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ericmarcos
approved these changes
Jul 8, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Niceee! Gogogo!
vanbasten17
changed the title
Full stack/output parser
Full stack/feature-branch-botonic1.0
Jul 9, 2021
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
ericmarcos
force-pushed
the
full-stack/output-parser
branch
from
July 15, 2021 10:49
a4b9444
to
3df40fc
Compare
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
vanbasten17
force-pushed
the
full-stack/output-parser
branch
from
July 28, 2021 08:23
c81a2db
to
155aeb2
Compare
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
…or hybrid project
* chore(react): add experimental components directory with necessary changes * chore(react): bump to alpha 1.0.0-alpha.0 * fix(react): allow carousel elements without buttons * chore(react): bump react to v1.0.0-alpha.1
* chore(ner/intent): support for botonic full-stack * refactor(plugin-ner, plugin-ic): baseUrl typed Co-authored-by: Eric Lozano <ericlozano98@gmail.com>
… make distributed package to point to lib
* style(core): add providerId attribute in User interface * test(core): refactor conditional expect
vanbasten17
force-pushed
the
full-stack/output-parser
branch
from
July 28, 2021 10:03
25975bd
to
d11039f
Compare
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on: #1646
Description
parsedResponse
(JSON with parsed messages instead of our internal xml, which is pretty unusable) to input object.Context
BotonicOutputParser have two main methods:
Note: Still some things are expected to change. ATM, we are typing it with Partial because some information cannot be accessed at runtime in this part of code but later, so
userId, eventId, from, ack, ...
will be fulfilled from a component on top of its usage.Approach
Testing
The pull request...