-
Notifications
You must be signed in to change notification settings - Fork 75
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Full stack/react experimental components #1701
Merged
vanbasten17
merged 4 commits into
full-stack/output-parser
from
full-stack/react-experimental-components
Jul 9, 2021
Merged
Full stack/react experimental components #1701
vanbasten17
merged 4 commits into
full-stack/output-parser
from
full-stack/react-experimental-components
Jul 9, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ericmarcos
approved these changes
Jul 8, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚀🚀🚀
vanbasten17
force-pushed
the
full-stack/react-experimental-components
branch
from
July 9, 2021 13:09
a3e008d
to
b58cbf2
Compare
vanbasten17
force-pushed
the
full-stack/react-experimental-components
branch
from
July 9, 2021 13:11
f7e8bb7
to
2d0434e
Compare
ericmarcos
pushed a commit
that referenced
this pull request
Jul 15, 2021
* chore(react): add experimental components directory with necessary changes * chore(react): bump to alpha 1.0.0-alpha.0 * fix(react): allow carousel elements without buttons * chore(react): bump react to v1.0.0-alpha.1
vanbasten17
added a commit
that referenced
this pull request
Jul 28, 2021
* chore(react): add experimental components directory with necessary changes * chore(react): bump to alpha 1.0.0-alpha.0 * fix(react): allow carousel elements without buttons * chore(react): bump react to v1.0.0-alpha.1
vanbasten17
added a commit
that referenced
this pull request
Jul 28, 2021
* chore(react): add experimental components directory with necessary changes * chore(react): bump to alpha 1.0.0-alpha.0 * fix(react): allow carousel elements without buttons * chore(react): bump react to v1.0.0-alpha.1
vanbasten17
added a commit
that referenced
this pull request
Jul 28, 2021
* chore(core): add minor improvements to models * feat(core): add botonic output parser with tests and project config for hybrid project * chore(core): bump to alpha 1.0.0-alpha.0 * fix(core): add support for postback inputs * chore(core): bump core to v1.0.0-alpha.1 * Full stack/react experimental components (#1701) * chore(react): add experimental components directory with necessary changes * chore(react): bump to alpha 1.0.0-alpha.0 * fix(react): allow carousel elements without buttons * chore(react): bump react to v1.0.0-alpha.1 * chore(ner/intent): support for botonic full-stack (#1644) * chore(ner/intent): support for botonic full-stack * refactor(plugin-ner, plugin-ic): baseUrl typed Co-authored-by: Eric Lozano <ericlozano98@gmail.com> * refactor(react): update whatsapp playground number and small lint errors * chore(core): wrap non bwd compatible functionality with try/catch and make distributed package to point to lib * Full stack: Add providerId in User interface (#1732) * style(core): add providerId attribute in User interface * test(core): refactor conditional expect * chore(core/react): bump to 0.19.0-beta.0 (#1739) Co-authored-by: Eric Lozano <ericlozano98@gmail.com> Co-authored-by: Eric Marcos <ericmarcos.p@gmail.com> Co-authored-by: Adrià Sastre <adria.sastre@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on: #1700
Description
experimental
folder with necessary changes in botonic components for correct functioning with the new parser in @botonic/core (Full stack/feature-branch-botonic1.0 #1700) and avoid breaking current @botonic/react package. Every component used in botonic 1.0 project, will be imported from @botonic/react/src/experimental.Some things have been fixed or simplified in this process:
msgToBotonic
function (no more weird accesses to data attributes, e.g.: now text of aText
component comes under thetext
property, not under text.text or text.data)Location
component receives delay and typing props as expected.lat
andlong
are also recovered from localStorage now (was not working).Audio, Image, Document, Video
allow buttons within the same component.WebchatDev
component with Botonic Playground.