Full stack: Add providerId in User interface #1732
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
asastre
requested review from
ericmarcos,
marcpdw,
vanbasten17,
elozano98 and
AinaVendrell
vanbasten17
approved these changes
Jul 26, 2021
ericmarcos
approved these changes
Jul 26, 2021
vanbasten17
force-pushed
the
full-stack/output-parser
branch
from
c81a2db to
155aeb2
Compare
vanbasten17
force-pushed
the
full-stack/provider-id
branch
from
0382c80 to
58d1b27
Compare
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
vanbasten17
pushed a commit
that referenced
this pull request
Jul 28, 2021
* style(core): add providerId attribute in User interface * test(core): refactor conditional expect
vanbasten17
added a commit
that referenced
this pull request
Jul 28, 2021
* chore(core): add minor improvements to models * feat(core): add botonic output parser with tests and project config for hybrid project * chore(core): bump to alpha 1.0.0-alpha.0 * fix(core): add support for postback inputs * chore(core): bump core to v1.0.0-alpha.1 * Full stack/react experimental components (#1701) * chore(react): add experimental components directory with necessary changes * chore(react): bump to alpha 1.0.0-alpha.0 * fix(react): allow carousel elements without buttons * chore(react): bump react to v1.0.0-alpha.1 * chore(ner/intent): support for botonic full-stack (#1644) * chore(ner/intent): support for botonic full-stack * refactor(plugin-ner, plugin-ic): baseUrl typed Co-authored-by: Eric Lozano <ericlozano98@gmail.com> * refactor(react): update whatsapp playground number and small lint errors * chore(core): wrap non bwd compatible functionality with try/catch and make distributed package to point to lib * Full stack: Add providerId in User interface (#1732) * style(core): add providerId attribute in User interface * test(core): refactor conditional expect * chore(core/react): bump to 0.19.0-beta.0 (#1739) Co-authored-by: Eric Lozano <ericlozano98@gmail.com> Co-authored-by: Eric Marcos <ericmarcos.p@gmail.com> Co-authored-by: Adrià Sastre <adria.sastre@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add missing
providerIdattribute in User interface as an optional attribute.Also, modified the existing
websocketIdattribute to optional.Fix lint error (
no-conditional-expect) in test.Context
Improvement of types in the full-stack version.
Approach taken / Explain the design
To document / Usage example
Testing
The pull request has unit tests.