feat(corda-connector): node diagnostics endpoint #623 #657
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
petermetz
requested review from
kikoncuo,
sfuji822,
jonathan-m-hamilton and
takeutak
takeutak
previously approved these changes
Mar 11, 2021
Primary change ------------- The Corda RPC proxy has a diagnostics method that we exposed here as an endpoint for our own connector as well. This will help tremendously in debugging things when people are working with the corda connector (speaking from experience here). Fixes hyperledger-cacti#623 Secondary change(s) ------------------- 1. Updated the jvm-kotlin-spring-server test case to use the container images from the official repository instead of relying on the temporary ones from Peter's personal one. Signed-off-by: Peter Somogyvari <peter.somogyvari@accenture.com>
|
🎉 Great news! Looks like all the dependencies have been resolved: 💡 To add or remove a dependency please update this issue/PR description. Brought to you by Dependent Issues (:robot: ). Happy coding! |
|
@takeutak I had to resolve some merge conflicts, check/review again please! |
takeutak
approved these changes
Mar 15, 2021
This was referenced Mar 19, 2021
takeutak
approved these changes
Mar 23, 2021
kikoncuo
approved these changes
Mar 23, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on #655
The Corda RPC proxy has a diagnostics method that we
exposed here as an endpoint for our own connector as well.
This will help tremendously in debugging things when
people are working with the corda connector
(speaking from experience here).
Fixes #623
Signed-off-by: Peter Somogyvari peter.somogyvari@accenture.com