fix(tools): corda AIO healthcheck ignores jolokia errors #692
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Mar 19, 2021
takeutak
previously approved these changes
Mar 23, 2021
petermetz
force-pushed
the
feat-621-parent-6
branch
3 times, most recently
from
eebb741 to
acd7048
Compare
takeutak
approved these changes
Mar 25, 2021
kikoncuo
approved these changes
Mar 25, 2021
petermetz
force-pushed
the
feat-621-parent-6
branch
from
acd7048 to
740c98f
Compare
Signed-off-by: Peter Somogyvari <peter.somogyvari@accenture.com>
This is the same thing that we added to the Fabric AIO image earlier: Setting the flag controls whether the CordaTestLedger class will automatically pipe the container's own logs onto the logger object of the class instance (CordaTestLedger) or not. By default it does pipe the logs but if it gets spammy developers can turn it off via the flag to avoid having to scroll through thousands of lines of logs that may or may not be useful to them. Signed-off-by: Peter Somogyvari <peter.somogyvari@accenture.com>
During testing it was easier and faster to have the cordapp building process commented out because the obligation cordapp is pre-built within the container image of AIO Corda, then it was forgotten like that which is not good because the rest of the examples are not pre-built and therefore don't actually work without this line being uncommented. Signed-off-by: Peter Somogyvari <peter.somogyvari@accenture.com>
While trying to use the supervisorctl binary to manage the starting of the corda-network process configured in supervisord.conf the following error was encountered and then fixed by this change: $ supervisorctl -c /etc/supervisor/supervisord.conf Error: .ini file does not include supervisorctl section For help, use /usr/bin/supervisorctl -h Signed-off-by: Peter Somogyvari <peter.somogyvari@accenture.com>
The corda AIO docker image now downloads the CLI tools jar for the standalone shell at build time. By default it downloads the 4.5 version of the jar but this can be altered to any other version through a dedicated build argument of the container image definition. The image built from this commit is also tagged (on top of the automatic tagging script) as hyperledger/cactus-corda-4-6-all-in-one-obligation:2021-03-14-standalone-corda-shell See more details here for what a standalone shell is and how it can be used to execute commands (some which are not available on the RPC proxy so this tool is a must have for certain operations such as gracefully stopping nodes) https://docs.corda.net/docs/corda-os/4.5/shell.html#standalone-shell Signed-off-by: Peter Somogyvari <peter.somogyvari@accenture.com>
The healthcheck script did not fail on curl returning a non-zero exit code because the bahs script that does the healthcheck was not configured to do so leaving the healthcheck essentially broken. Added the set -e line to the healthcheck to ensure that this does not happen (it makes the whole script fail as soon as any command within the script does so which is what we want from the healthcheck script) Tagged in the container registry as: `hyperledger/cactus-corda-4-6-all-in-one-obligation:2021-03-15-fix-healthcheck` Signed-off-by: Peter Somogyvari <peter.somogyvari@accenture.com>
petermetz
force-pushed
the
feat-621-parent-6
branch
from
740c98f to
5a22969
Compare
|
🎉 Great news! Looks like all the dependencies have been resolved:
💡 To add or remove a dependency please update this issue/PR description. Brought to you by Dependent Issues (:robot: ). Happy coding! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Dependencies (need to be reviewed and merged first)
Depends on #657
Depends on #687
Depends on #688
Depends on #689
Depends on #690
Depends on #691
Depends on #656
Commit to be reviewed
Author: Peter Somogyvari peter.somogyvari@accenture.com
Author Date: 2021-03-15 16:06:41 -0700
Committer: Peter Somogyvari peter.somogyvari@accenture.com
Committer Date: 2021-03-15 16:14:59 -0700
fix(tools): corda AIO healthcheck ignores jolokia errors
The healthcheck script did not fail on curl returning
a non-zero exit code because the bahs script that
does the healthcheck was not configured to do so
leaving the healthcheck essentially broken.
Added the set -e line to the healthcheck to ensure
that this does not happen (it makes the whole script
fail as soon as any command within the script
does so which is what we want from the healthcheck
script)
Tagged in the container registry as:
hyperledger/cactus-corda-4-6-all-in-one-obligation:2021-03-15-fix-healthcheck
Signed-off-by: Peter Somogyvari peter.somogyvari@accenture.com