fix(test-tooling): uncomment code that was forgotten #689
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Mar 19, 2021
takeutak
previously approved these changes
Mar 23, 2021
petermetz
force-pushed
the
feat-621-parent-3
branch
from
51af1f0 to
9a8ec3b
Compare
petermetz
changed the title
petermetz
force-pushed
the
feat-621-parent-3
branch
2 times, most recently
from
de18a4f to
d447149
Compare
takeutak
approved these changes
Mar 25, 2021
kikoncuo
approved these changes
Mar 25, 2021
petermetz
force-pushed
the
feat-621-parent-3
branch
from
d447149 to
6ea3425
Compare
Signed-off-by: Peter Somogyvari <peter.somogyvari@accenture.com>
This is the same thing that we added to the Fabric AIO image earlier: Setting the flag controls whether the CordaTestLedger class will automatically pipe the container's own logs onto the logger object of the class instance (CordaTestLedger) or not. By default it does pipe the logs but if it gets spammy developers can turn it off via the flag to avoid having to scroll through thousands of lines of logs that may or may not be useful to them. Signed-off-by: Peter Somogyvari <peter.somogyvari@accenture.com>
During testing it was easier and faster to have the cordapp building process commented out because the obligation cordapp is pre-built within the container image of AIO Corda, then it was forgotten like that which is not good because the rest of the examples are not pre-built and therefore don't actually work without this line being uncommented. Signed-off-by: Peter Somogyvari <peter.somogyvari@accenture.com>
petermetz
force-pushed
the
feat-621-parent-3
branch
from
6ea3425 to
3e37236
Compare
|
🎉 Great news! Looks like all the dependencies have been resolved:
💡 To add or remove a dependency please update this issue/PR description. Brought to you by Dependent Issues (:robot: ). Happy coding! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Dependencies (need to be reviewed and merged first)
Depends on #657
Depends on #687
Depends on #688
Depends on #656
Commit to be reviewed
fix(test-tooling): uncomment code that was forgotten
During testing it was easier and faster to have the
cordapp building process commented out because
the obligation cordapp is pre-built within the
container image of AIO Corda, then it was forgotten
like that which is not good because the rest of the examples
are not pre-built and therefore don't actually work
without this line being uncommented.
Signed-off-by: Peter Somogyvari peter.somogyvari@accenture.com