fix: avoid error on typing colon #6056
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@jdstrand @jeffreyssmith2nd @ivankudibal @bnpfeife does anybody have the opportunity to review? |
Sciator
approved these changes
Aug 31, 2023
ivankudibal
reviewed
Aug 31, 2023
There was a problem hiding this comment.
Hello R290, thanks a lot, after a discussion with @Sciator, would you add a comment that it must be a class component if someone wants to refactor it in the future so that the error does not appear again when the type system does not check it...
|
It would be good to add |
|
Thanks to both of you for your review. I hope we can merge and release soon, the colon error is causing quite a lot of issues being created. |
|
Another issue has popped up (#6058), time to merge this? @ivankudibal @Sciator |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #6007
Closes #6009
Closes #6011
Closes #6013
Closes #6017
Closes #6031
Closes #6034
Closes #6037
Closes #6038
Closes #6039
Closes #6044
Closes #6048
Closes #6051
Closes #6052
Closes #6053
Closes #6055
I might have missed a few issues describing the same error.
Briefly describe your proposed changes:
Replace FunctionComponent by Component in the
TemplateDrawerto restore compatibility withreact-onclickoutsideWhat was the problem?
Error when typing a colon:
Cannot read properties of undefined (reading 'getInstance')What was the solution?
Replacing FunctionComponent by Component, setting properties and adding a render function.
etc/Dockerfile_buildhave been pushed to DockerHub, and the changes have been added to.circleci/config.yml