local time for traces, end date when agent is done running in traces by shagun-singh-inkeep · Pull Request #1903 · inkeep/agents

shagun-singh-inkeep · 2026-02-10T17:58:45Z

No description provided.

vercel · 2026-02-10T17:58:51Z

The latest updates on your projects. Learn more about Vercel for GitHub.

Project	Deployment	Actions	Updated (UTC)
agents-api	Ready	Preview, Comment	Feb 10, 2026 6:46pm
agents-manage-ui	Ready	Preview, Comment	Feb 10, 2026 6:46pm

1 Skipped Deployment

Project	Deployment	Actions	Updated (UTC)
agents-docs	Skipped		Feb 10, 2026 6:46pm

changeset-bot · 2026-02-10T17:58:51Z

🦋 Changeset detected

Latest commit: 28a9537

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 10 packages

Name	Type
@inkeep/agents-manage-ui	Patch
@inkeep/agents-api	Patch
@inkeep/agents-cli	Patch
@inkeep/agents-core	Patch
@inkeep/agents-manage-mcp	Patch
@inkeep/agents-mcp	Patch
@inkeep/agents-sdk	Patch
@inkeep/agents-work-apps	Patch
@inkeep/ai-sdk-provider	Patch
@inkeep/create-agents	Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

inkeep · 2026-02-10T18:00:46Z

No docs changes detected.

This PR improves the Traces UI by displaying timestamps in the user's local timezone instead of UTC. The existing documentation describes what information is shown in traces without specifying timezone formatting, so no updates are needed.

inkeep · 2026-02-10T18:01:28Z

No docs changes detected.

The Traces documentation (agents-docs/content/get-started/traces.mdx) does not explicitly specify timezone behavior for timestamps, so the change from UTC to local browser time does not require documentation updates.

claude

PR Review Summary

3 Key Findings | Risk: Low

🟠⚠️ Major (1) 🟠⚠️

🟠 Major: page.tsx:263-267 Tooltip displays raw UTC while card body shows formatted local time

🟡 Minor (2) 🟡

🟡 1) page.tsx:291-298 "Running…" state could be more informative

Issue: The "Running…" indicator shown for active conversations without an assistant response uses yellow text but lacks context about what it means or how long to expect.

Why: Users seeing "Running…" in yellow may wonder: Is this stuck? Is there an error? How long will it take? For an observability tool, ambiguous status indicators reduce confidence in the data.

Fix: Consider one of these improvements:

Add a tooltip explaining the state: title="Agent is processing. Refresh to check status."
Add a small spinner icon for visual consistency with other in-progress indicators (e.g., timeline-wrapper.tsx:163-165 uses <Loader2 className="w-4 h-4 animate-spin" />)
Show elapsed time since conversation start to give context

Refs:

Timeline wrapper in-progress pattern
🟡 Minor: conversation-list-item.tsx:52 formatDateAgo missing { local: true } for consistency with tooltip

💭 Consider (1) 💭

💭 1) system Cross-surface timezone consistency

Issue: The PR applies local time to traces but other observability surfaces (dataset runs, evaluation jobs, trigger invocations) continue displaying UTC. This is noted as an intentional scoping decision per the PR title "local time for traces".

Why: Users debugging across multiple surfaces may see inconsistent timestamps. However, this appears to be a deliberate phased approach.

Fix: If expanding local time to other surfaces is planned, consider documenting that intent. If traces should remain the only local-time surface, this is fine as-is.

💡 APPROVE WITH SUGGESTIONS

Summary: This is a nice UX improvement for the traces UI. The main issue to address is the tooltip/display timezone mismatch (see inline comment) — that's a clear inconsistency that could confuse users. The "Running…" state feedback and formatDateAgo consistency are minor polish items. Good use of the opt-in { local: true } pattern to avoid disrupting other surfaces. 🎉

Discarded (5)

Location	Issue	Reason Discarded
`format-date.ts:86-128`	`formatDateAgo` options parameter added but not used with `{ local: true }`	The option was added for API completeness; relative times are timezone-agnostic anyway. Low value finding.
`format-date.ts:23-25`	Option pattern is consistent with codebase conventions	Positive finding — no action needed
`page.tsx:254-316`	IIFE pattern creates function on every render	Acceptable pattern, keeps related logic co-located. Not a performance issue.
`page.tsx:291-298`	Conditional rendering is correct	Positive finding — no issue identified
`format-date.ts:55-68`	Intl.DateTimeFormat created on every call could be cached	Micro-optimization not needed for current usage patterns

Reviewers (4)

Reviewer	Returned	Main Findings	Consider	Inline Comments	Discarded
`pr-review-product`	4	1	1	1	1
`pr-review-consistency`	4	0	0	1	1
`pr-review-frontend`	3	0	0	0	3
`pr-review-standards`	0	0	0	0	0
Total	11	1	1	2	5

...ge-ui/src/app/[tenantId]/projects/[projectId]/traces/conversations/[conversationId]/page.tsx

+              title={
+                conversation.conversationStartTime
+                  ? `Start: ${conversation.conversationStartTime}${showEndTime ? `\nEnd: ${conversation.conversationEndTime}` : ''}`
+                  : 'Timing data not available'
+              }


claude

PR Review Summary

Delta Re-review | Risk: Low

✅ Addressed Since Last Review

The MAJOR issue from the previous review has been resolved:

Issue	Status
🟠 Tooltip shows UTC while display shows local time	✅ Fixed — tooltip now uses `formatDateTime(..., { local: true })`

The fix correctly formats both the start and end timestamps in the tooltip using the same { local: true } option as the card body, ensuring timezone consistency.

🕐 Pending Recommendations (2)

These items from the prior review remain unaddressed but are lower priority:

🟡 page.tsx:291-298 "Running…" state could be more informative (consider adding tooltip or spinner)
🟡 conversation-list-item.tsx:52 formatDateAgo missing { local: true } for consistency

✅ APPROVE

Summary: The critical tooltip/display timezone mismatch has been fixed. The remaining minor suggestions are polish items that can be addressed in a follow-up if desired. Nice UX improvement for traces! 🎉

Reviewers (0)

Reviewer	Returned	Main Findings	Consider	While You're Here	Inline Comments	Pending Recs	Discarded
Total	0	0	0	0	0	2	0

Note: Delta re-review — no subagents dispatched as the change was a targeted 3-line fix addressing the prior MAJOR issue.

claude

PR Review Summary

Delta Re-review | Risk: Low

✅ Changes Since Last Review

The latest commit (28a95372) addresses one of the previous MINOR recommendations by removing the "Running…" indicator entirely:

Prior Issue	Resolution
🟡 "Running…" state could be more informative	✅ Removed — the component now simply omits the "End:" line when there's no assistant response yet

This is a cleaner approach than adding a tooltip/spinner to the "Running…" state. Instead of showing potentially confusing in-progress text, the UI now shows only what's definitively known (start time) and adds the end time once the conversation actually completes. This reduces visual noise and eliminates ambiguity.

🕐 Pending Recommendations (1)

One minor item from the prior review remains:

🟡 conversation-list-item.tsx:52 formatDateAgo missing { local: true } — though relative times ("5 min ago") are timezone-agnostic, and the tooltip correctly uses local time, so this is low priority

✅ APPROVE

Summary: The PR is in good shape. The major tooltip/display timezone mismatch was fixed in a prior commit, and this latest commit cleanly addresses the "Running…" state feedback by removing it in favor of a simpler approach. The remaining formatDateAgo item is a minor polish suggestion that can be addressed in a follow-up if desired. Nice UX improvement for traces! 🎉

Reviewers (0)

Reviewer	Returned	Main Findings	Consider	While You're Here	Inline Comments	Pending Recs	Discarded
Total	0	0	0	0	0	1	0

Note: Delta re-review — no subagents dispatched as the change was a targeted 7-line removal addressing a prior MINOR issue.

…aces (#1903) * local time for traces, end date when agent is done running * changeset * lint and claude comment * remove unneeded state

…1974) * updated test * added changeset * added tests * updated * tupecheck * few fixes for GenericPromptEditor/GenericJsonEditor (#1904) * few fixes for GenericPromptEditor/GenericJsonEditor * Add changeset for GenericPromptEditor/GenericJsonEditor layout fixes Co-authored-by: Dimitri POSTOLOV <undefined@users.noreply.github.com> * Update generic-prompt-editor.tsx --------- Co-authored-by: claude[bot] <41898282+claude[bot]@users.noreply.github.com> Co-authored-by: Dimitri POSTOLOV <undefined@users.noreply.github.com> * local time for traces, end date only when agent is done running in traces (#1903) * local time for traces, end date when agent is done running * changeset * lint and claude comment * remove unneeded state * updated tests * updated * updated tests * made a single transaction * renamed function * updated * updated tool results to have the tool call id * added changeset * address spicedb comments * reverted bad changes * removed --------- Co-authored-by: Dimitri POSTOLOV <dmytropostolov@gmail.com> Co-authored-by: claude[bot] <41898282+claude[bot]@users.noreply.github.com> Co-authored-by: Dimitri POSTOLOV <undefined@users.noreply.github.com> Co-authored-by: shagun-singh-inkeep <shagun.singh@inkeep.com> Co-authored-by: omar-inkeep <omar@inkeep.com>

shagun-singh-inkeep added 2 commits February 10, 2026 12:57

local time for traces, end date when agent is done running

610e898

changeset

7b184ff

vercel bot deployed to Preview – agents-api February 10, 2026 18:00 View deployment

vercel bot deployed to Preview – agents-manage-ui February 10, 2026 18:01 View deployment

vercel bot deployed to Preview – agents-docs February 10, 2026 18:01 View deployment

claude bot reviewed Feb 10, 2026

View reviewed changes

github-actions bot deleted a comment from claude bot Feb 10, 2026

lint and claude comment

1655db0

vercel bot temporarily deployed to Preview – agents-docs February 10, 2026 18:36 Inactive

vercel bot deployed to Preview – agents-api February 10, 2026 18:38 View deployment

claude bot reviewed Feb 10, 2026

View reviewed changes

github-actions bot deleted a comment from claude bot Feb 10, 2026

vercel bot deployed to Preview – agents-manage-ui February 10, 2026 18:39 View deployment

remove unneeded state

28a9537

vercel bot temporarily deployed to Preview – agents-docs February 10, 2026 18:44 Inactive

vercel bot deployed to Preview – agents-api February 10, 2026 18:46 View deployment

vercel bot deployed to Preview – agents-manage-ui February 10, 2026 18:46 View deployment

claude bot reviewed Feb 10, 2026

View reviewed changes

github-actions bot deleted a comment from claude bot Feb 10, 2026

shagun-singh-inkeep merged commit 73d79bd into main Feb 10, 2026
9 checks passed

shagun-singh-inkeep deleted the TI-7 branch February 10, 2026 18:52

tim-inkeep pushed a commit that referenced this pull request Feb 10, 2026

local time for traces, end date only when agent is done running in tr…

eda0de2

…aces (#1903) * local time for traces, end date when agent is done running * changeset * lint and claude comment * remove unneeded state

claude bot mentioned this pull request Feb 10, 2026

Normalize JSON schemas for OpenAI structured output compatibility #1836

Closed

amikofalvy mentioned this pull request Feb 10, 2026

fix: use local timezone for all user-facing datetime displays #1906

Open

10 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Comments

local time for traces, end date when agent is done running in traces#1903

local time for traces, end date when agent is done running in traces#1903
shagun-singh-inkeep merged 4 commits intomainfrom
TI-7

shagun-singh-inkeep commented Feb 10, 2026

Uh oh!

vercel bot commented Feb 10, 2026 •

edited

Loading

Uh oh!

changeset-bot bot commented Feb 10, 2026 •

edited

Loading

Uh oh!

inkeep bot commented Feb 10, 2026

Uh oh!

inkeep bot commented Feb 10, 2026

Uh oh!

claude bot left a comment

Uh oh!

This comment was marked as outdated.

Uh oh!

claude bot left a comment

Uh oh!

claude bot left a comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

Comments

Conversation

shagun-singh-inkeep commented Feb 10, 2026

Uh oh!

vercel bot commented Feb 10, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

changeset-bot bot commented Feb 10, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🦋 Changeset detected

Uh oh!

inkeep bot commented Feb 10, 2026

Uh oh!

inkeep bot commented Feb 10, 2026

Uh oh!

claude bot left a comment

Choose a reason for hiding this comment

PR Review Summary

🟠⚠️ Major (1) 🟠⚠️

🟡 Minor (2) 🟡

💭 Consider (1) 💭

💡 APPROVE WITH SUGGESTIONS

Uh oh!

This comment was marked as outdated.

Uh oh!

claude bot left a comment

Choose a reason for hiding this comment

PR Review Summary

✅ Addressed Since Last Review

🕐 Pending Recommendations (2)

✅ APPROVE

Uh oh!

claude bot left a comment

Choose a reason for hiding this comment

PR Review Summary

✅ Changes Since Last Review

🕐 Pending Recommendations (1)

✅ APPROVE

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

vercel bot commented Feb 10, 2026 •

edited

Loading

changeset-bot bot commented Feb 10, 2026 •

edited

Loading