Include tool call ID in enhanced tool results for artifact creation

[tim-inkeep]

Adds _toolCallId field to tool results when artifact components are available. This ensures agents have the correct tool call ID reference when creating artifacts, preventing the need to generate or guess IDs.

[vercel]

The latest updates on your projects. Learn more about Vercel for GitHub.

Project	Deployment	Actions	Updated (UTC)
agents-api	Building	Preview, Comment	Feb 12, 2026 10:16pm
agents-docs	Building	Preview, Comment	Feb 12, 2026 10:16pm
agents-manage-ui	Building	Preview, Comment	Feb 12, 2026 10:16pm

[changeset-bot]

🦋 Changeset detected

Latest commit: 575bf43

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 10 packages

Name	Type
@inkeep/agents-api	Patch
@inkeep/agents-manage-ui	Patch
@inkeep/agents-cli	Patch
@inkeep/agents-core	Patch
@inkeep/agents-manage-mcp	Patch
@inkeep/agents-mcp	Patch
@inkeep/agents-sdk	Patch
@inkeep/agents-work-apps	Patch
@inkeep/ai-sdk-provider	Patch
@inkeep/create-agents	Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

[inkeep]

No documentation updates needed for this PR. This is an internal bugfix that ensures tool call IDs are properly passed during artifact creation—an implementation detail that doesn't affect user-facing APIs or behavior.

[claude]

PR Review Summary

(2) Total Issues | Risk: Low

🟠⚠️ Major (1) 🟠⚠️

🟠 1) Agent.ts:2495-2730 Missing test coverage for enhanceToolResultWithStructureHints

Issue: The enhanceToolResultWithStructureHints method has zero unit test coverage. This PR adds a new toolCallId parameter and _toolCallId field to the method, but there are no tests verifying this behavior works correctly.

Why: Without tests, the following regressions could go undetected:

• The _toolCallId field might not be added when expected (toolCallId provided + artifact components present), causing artifact creation to fail with incorrect tool call IDs
• The _toolCallId field might be incorrectly added when it should not be (toolCallId is undefined/null)
• Edge cases like null/undefined results or non-object results could break silently

This is important business logic for artifact creation that could cause user-facing errors if tool call IDs are missing or incorrect.

Fix: Add unit tests for enhanceToolResultWithStructureHints. Consider testing through the Agent class or extracting to a testable utility. Suggested test cases:

// 1. should add _toolCallId when toolCallId provided and artifactComponents exist
// Input: result = { data: 'test' }, toolCallId = 'call_123', agent has artifactComponents
// Expected: result contains _toolCallId: 'call_123'

// 2. should not add _toolCallId when toolCallId is undefined
// Input: result = { data: 'test' }, toolCallId = undefined
// Expected: result does NOT contain _toolCallId key

// 3. should not enhance result when no artifactComponents
// Input: result = { data: 'test' }, toolCallId = 'call_123', agent has no artifactComponents
// Expected: result returned unchanged

// 4. should return null/undefined result unchanged
// Input: result = null, toolCallId = 'call_123'
// Expected: returns null

Refs:

• Agent.ts:2495-2730 — enhanceToolResultWithStructureHints method
• Agent.ts:1065-1068 — call site passing toolCallId

🟡 Minor (1) 🟡

🟡 1) Agent.ts:2462 Inconsistent metadata filtering: _toolCallId not stripped alongside _structureHints

Issue: The formatToolResult method filters out _structureHints from tool results before storing in conversation history (line 2462), but does not filter the newly added _toolCallId field. The same filtering pattern exists in ArtifactService.ts:151 and BaseCompressor.ts:609.

Why: This creates inconsistent behavior where _toolCallId persists in some contexts (fresh tool results, stored history) while _structureHints is removed. If _toolCallId is intended only as runtime guidance for the LLM during artifact creation, it may be worth filtering it consistently with _structureHints. If it's intentionally meant to persist, consider documenting this decision.

Fix: Either:

1. Add _toolCallId to the filter conditions alongside _structureHints in all three locations, OR
2. Add a code comment explicitly documenting that _toolCallId is intentionally preserved (and why)

Refs:

• Agent.ts:2462 — formatToolResult filtering
• ArtifactService.ts:151 — artifact creation filtering
• BaseCompressor.ts:609 — compression filtering

---

💡 APPROVE WITH SUGGESTIONS

Summary: The implementation is straightforward and correct — the _toolCallId field is properly added to enhanced tool results with appropriate conditional logic. However, the change would benefit from test coverage to prevent regressions, and there's a minor design question about whether _toolCallId should be filtered consistently with _structureHints in cleanup paths. Neither issue is blocking, but addressing the test coverage would improve confidence in this change.

Discarded (1)

Location	Issue	Reason Discarded
Agent.ts:2717	Guidance text uses emoji prefixes (🔧 CRITICAL:)	Consistent with existing patterns in the same code block; developer preference

Reviewers (3)

Reviewer	Returned	Main Findings	Consider	While You're Here	Inline Comments	Pending Recs	Discarded
pr-review-standards	0	0	0	0	0	0	0
pr-review-tests	2	1	0	0	0	0	0
pr-review-llm	2	1	0	0	0	0	1
Total	4	2	0	0	0	0	1