few fixes for GenericPromptEditor/GenericJsonEditor#1904
Merged
dimaMachina merged 3 commits intomainfrom Feb 10, 2026
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
🦋 Changeset detectedLatest commit: f68b847 The changes in this PR will be included in the next version bump. This PR includes changesets to release 10 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Collaborator
Author
|
@claude --review and add changeset |
Contributor
|
No docs changes detected. These are internal UI component layout fixes that don't affect user-facing documentation. |
![claude[bot]](https://avatars.githubusercontent.com/in/1236702?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
PR Review Summary
0 Key Findings | Risk: Low
🔴❗ Critical (0) ❗🔴
None.
🟠⚠️ Major (0) 🟠⚠️
None.
🟡 Minor (0) 🟡
None.
💭 Consider (0) 💭
None.
✅ APPROVE
Summary: Clean layout/styling fixes that align with existing codebase patterns. The changes correctly implement Pattern B (flex wrapper + inline-flex on FormLabel + ml-auto on actions) which is the established convention for form-integrated editor components. The customTemplate default to placeholder is a sensible API simplification. Ship it! 🚀
Discarded (2)
| Location | Issue | Reason Discarded |
|---|---|---|
generic-prompt-editor.tsx:63 |
Commented-out aria-labelledby code |
Pre-existing (not introduced by this PR), LOW confidence, and labeling is handled via FormControl slot pattern |
multi-file |
Layout pattern inconsistency between ExpandableField and Generic*Editor components | The codebase intentionally uses two complementary patterns: Pattern A (ExpandableField - lower-level abstraction with justify-between) and Pattern B (GenericFormEditor - higher-level, react-hook-form integrated with inline-flex + ml-auto). Both are valid and the PR correctly follows Pattern B. |
Reviewers (3)
| Reviewer | Returned | Main Findings | Consider | While You're Here | Inline Comments | Pending Recs | Discarded |
|---|---|---|---|---|---|---|---|
pr-review-standards |
0 | 0 | 0 | 0 | 0 | 0 | 0 |
pr-review-frontend |
1 | 0 | 0 | 0 | 0 | 0 | 1 |
pr-review-consistency |
1 | 0 | 0 | 0 | 0 | 0 | 1 |
| Total | 2 | 0 | 0 | 0 | 0 | 0 | 2 |
Co-authored-by: Dimitri POSTOLOV <undefined@users.noreply.github.com>
Contributor
There was a problem hiding this comment.
PR Review Summary (Delta)
0 Key Findings | Risk: Low
Delta Scope
This is a re-review scoped to changes since the previous review. The delta contains:
.changeset/polish-generic-components.md— Correctly formatted patch changeset for@inkeep/agents-manage-uigeneric-prompt-editor.tsx:35—uriprop made optional (uri?)
Analysis
The uri prop change is safe — the component already has fallback logic at line 39:
const $uri = props.uri ?? `${name}.template`;When uri is not provided, it defaults to using the field name as the template URI, which is the expected behavior for most use cases.
✅ APPROVE
Summary: Delta changes are trivial and safe. The changeset correctly documents the layout fixes, and making uri optional is a sensible API ergonomics improvement with proper fallback handling. 🚀
tim-inkeep
pushed a commit
that referenced
this pull request
Feb 10, 2026
* few fixes for GenericPromptEditor/GenericJsonEditor * Add changeset for GenericPromptEditor/GenericJsonEditor layout fixes Co-authored-by: Dimitri POSTOLOV <undefined@users.noreply.github.com> * Update generic-prompt-editor.tsx --------- Co-authored-by: claude[bot] <41898282+claude[bot]@users.noreply.github.com> Co-authored-by: Dimitri POSTOLOV <undefined@users.noreply.github.com>
tim-inkeep
added a commit
that referenced
this pull request
Feb 13, 2026
…1974) * updated test * added changeset * added tests * updated * tupecheck * few fixes for GenericPromptEditor/GenericJsonEditor (#1904) * few fixes for GenericPromptEditor/GenericJsonEditor * Add changeset for GenericPromptEditor/GenericJsonEditor layout fixes Co-authored-by: Dimitri POSTOLOV <undefined@users.noreply.github.com> * Update generic-prompt-editor.tsx --------- Co-authored-by: claude[bot] <41898282+claude[bot]@users.noreply.github.com> Co-authored-by: Dimitri POSTOLOV <undefined@users.noreply.github.com> * local time for traces, end date only when agent is done running in traces (#1903) * local time for traces, end date when agent is done running * changeset * lint and claude comment * remove unneeded state * updated tests * updated * updated tests * made a single transaction * renamed function * updated * updated tool results to have the tool call id * added changeset * address spicedb comments * reverted bad changes * removed --------- Co-authored-by: Dimitri POSTOLOV <dmytropostolov@gmail.com> Co-authored-by: claude[bot] <41898282+claude[bot]@users.noreply.github.com> Co-authored-by: Dimitri POSTOLOV <undefined@users.noreply.github.com> Co-authored-by: shagun-singh-inkeep <shagun.singh@inkeep.com> Co-authored-by: omar-inkeep <omar@inkeep.com>
dimaMachina
added a commit
that referenced
this pull request
Feb 19, 2026
…1974) * updated test * added changeset * added tests * updated * tupecheck * few fixes for GenericPromptEditor/GenericJsonEditor (#1904) * few fixes for GenericPromptEditor/GenericJsonEditor * Add changeset for GenericPromptEditor/GenericJsonEditor layout fixes Co-authored-by: Dimitri POSTOLOV <undefined@users.noreply.github.com> * Update generic-prompt-editor.tsx --------- Co-authored-by: claude[bot] <41898282+claude[bot]@users.noreply.github.com> Co-authored-by: Dimitri POSTOLOV <undefined@users.noreply.github.com> * local time for traces, end date only when agent is done running in traces (#1903) * local time for traces, end date when agent is done running * changeset * lint and claude comment * remove unneeded state * updated tests * updated * updated tests * made a single transaction * renamed function * updated * updated tool results to have the tool call id * added changeset * address spicedb comments * reverted bad changes * removed --------- Co-authored-by: Dimitri POSTOLOV <dmytropostolov@gmail.com> Co-authored-by: claude[bot] <41898282+claude[bot]@users.noreply.github.com> Co-authored-by: Dimitri POSTOLOV <undefined@users.noreply.github.com> Co-authored-by: shagun-singh-inkeep <shagun.singh@inkeep.com> Co-authored-by: omar-inkeep <omar@inkeep.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.