[SYCL] Make SYCL geometrical functions overloads instead of templates #10014
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It was decided to change all built-in functions from templates to overloads. This patch changes non-marray part of "4.17.8. Geometric functions". Spec: KhronosGroup/SYCL-Docs#428 Co-authored-by: Steffen Larsen <steffen.larsen@intel.com>
KornevNikita
commented
Jun 21, 2023
dm-vodopyanov
approved these changes
Jun 22, 2023
dm-vodopyanov
requested changes
Jun 22, 2023
Contributor
dm-vodopyanov
left a comment
dm-vodopyanov
left a comment
There was a problem hiding this comment.
Sorry, revoked "Approved"
dm-vodopyanov
approved these changes
Jun 23, 2023
Contributor
Author
|
Converting to draft to check something. |
dm-vodopyanov
pushed a commit
that referenced
this pull request
Jun 26, 2023
…mplates (#10048) It was decided to change all built-in functions from templates to overloads. This patch changes marray part of "4.17.8. Geometric functions". Non-marray part: #10014 Spec: KhronosGroup/SYCL-Docs#428
steffenlarsen
added a commit
to steffenlarsen/llvm
that referenced
this pull request
Jul 3, 2023
…emplates (intel#10014)" This reverts commit 49bbcbf.
steffenlarsen
added a commit
that referenced
this pull request
Jul 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It was decided to change all built-in functions from templates to overloads. This patch changes non-marray part of "4.17.8. Geometric functions".
Marray part: #10048
Spec: KhronosGroup/SYCL-Docs#428