[SYCL] Make relational builtins overloads #10050
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In the continued effort to make the math builtin functions into overloads, this commit changes the scalar and vector relational builtins to adhere to the new builtin overload structure. Signed-off-by: Larsen, Steffen <steffen.larsen@intel.com>
steffenlarsen
changed the title
KornevNikita
approved these changes
Jun 27, 2023
Contributor
KornevNikita
left a comment
KornevNikita
left a comment
There was a problem hiding this comment.
LGTM! Just a few typos in comments
againull
approved these changes
Jun 28, 2023
aelovikov-intel
added a commit
to aelovikov-intel/llvm
that referenced
this pull request
Jun 29, 2023
This reverts commit a2aec49. Seems it caused huge compile time regression for `check-sycl`/`check-sycl-e2e`.
steffenlarsen
added a commit
to steffenlarsen/llvm
that referenced
this pull request
Jul 3, 2023
This reverts commit a2aec49.
steffenlarsen
added a commit
that referenced
this pull request
Jul 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the continued effort to make the math builtin functions into overloads, this commit changes the scalar and vector relational builtins to adhere to the new builtin overload structure.