[SYCL] Add defines for built-in transition #10026
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We are going to change built-ins implementation from templates to overloads according to KhronosGroup/SYCL-Docs#428. This patch is intended to unblock the parallel transition of the different groups of built-ins. Co-authored-by: Steffen Larsen <steffen.larsen@intel.com>
dm-vodopyanov
approved these changes
Jun 22, 2023
steffenlarsen
added a commit
to steffenlarsen/llvm
that referenced
this pull request
Jul 3, 2023
This reverts commit fe61b99.
steffenlarsen
added a commit
that referenced
this pull request
Jul 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We are going to change built-ins implementation from templates to overloads according to KhronosGroup/SYCL-Docs#428. This patch is intended to unblock the parallel transition of the different groups of built-ins.