Skip to content

[SYCL][NFC] Add test for array init by zeroes #1402

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 28, 2020

Conversation

mlychkov
Copy link
Contributor

Signed-off-by: Mikhail Lychkov mikhail.lychkov@intel.com

@mlychkov mlychkov force-pushed the private/mlychkov/private_array_init_test branch from 0e21a28 to ee3ad2e Compare March 26, 2020 20:32
Test checks that SYCL program is not crashed if it contains
a class/struct that has private array member which is initialized
by zeroes.

Signed-off-by: Mikhail Lychkov <mikhail.lychkov@intel.com>
@mlychkov mlychkov force-pushed the private/mlychkov/private_array_init_test branch from ee3ad2e to 1e50174 Compare March 27, 2020 10:07
MrSidims
MrSidims previously approved these changes Mar 27, 2020
Copy link
Contributor

@MrSidims MrSidims left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mlychkov mlychkov force-pushed the private/mlychkov/private_array_init_test branch from 1e50174 to eda0b97 Compare March 27, 2020 10:42
@mlychkov mlychkov force-pushed the private/mlychkov/private_array_init_test branch from eda0b97 to bdd335b Compare March 27, 2020 14:30
@mlychkov mlychkov changed the title [SYCL] Add test for array init by zeroes [SYCL][NFC] Add test for array init by zeroes Mar 27, 2020
@bader bader requested review from MrSidims and romanovvlad March 27, 2020 19:05
@bader bader merged commit 3e1fb14 into intel:sycl Mar 28, 2020
@mlychkov mlychkov deleted the private/mlychkov/private_array_init_test branch March 30, 2020 08:35
alexbatashev pushed a commit to alexbatashev/llvm that referenced this pull request Apr 15, 2020
…c_abi_checks

* origin/sycl: (6966 commits)
  [NFC][SYCL] Do not add `sycl_device` attribute to OpenCL kernel (intel#1439)
  [SYCL][NFC] Move SYCL pipe metadata call to be inside the null check for D (intel#1436)
  [SYCL][NFC] Move template function definition to .h file (intel#1433)
  [SYCL] Don't expose vector of booleans as storage format (intel#1419)
  [SYCL] Don't throw exceptions from destructors (intel#1378)
  [BuildBot] Add support for multiple CMake options (intel#1434)
  [SYCL][NFC] Fix warning inline namespace reopened as no-inline (intel#1435)
  [SYCL] Check if loadPlugin returns a nullptr (intel#1411)
  [SYCL] Release notes for February'20 SYCL implementation update (intel#1400)
  [SYCL][Doc] Improve contribution guidelines (intel#1422)
  [BuildBot] Add --cmake-opts option to configure.py script (intel#1430)
  [SYCL] Enable non-read-write memory object mapping in scheduler (intel#1390)
  [SYCL][Driver] Do not store AOT-specific options in the image descriptor (intel#1428)
  [Driver][NFC] Fix string problem used for tracking duplicate triples (intel#1424)
  [SYCL][NFC] Use the non-deprecated setAlignment() in LowerWGScope (intel#1420)
  [SYCL][NFC] Fix formatting in GetStartedGuide (intel#1417)
  [NFC] Move CODEOWNERS file to enable GitHub automation (intel#1418)
  [SYCL] Add test for private array init by zeroes (intel#1402)
  [Driver][SYCL][FPGA] Adjust device and AOCX link order for FPGA (intel#1389)
  [SYCL] Change runtime check to assert in program_manager.cpp (intel#1413)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants