Skip to content

[SYCL][NFC] Use the non-deprecated setAlignment() in LowerWGScope #1420

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 29, 2020

Conversation

AGindinson
Copy link
Contributor

The commit switches to using the MaybeAlign overload directly,
which addresses:

*/llvm/llvm/lib/SYCLLowerIR/LowerWGScope.cpp: In function 'llvm::Value* spirv::genPseudoLocalID(llvm::Instruction&, const llvm::Triple&)':
*/llvm/llvm/lib/SYCLLowerIR/LowerWGScope.cpp:929:28: warning: 'void llvm::GlobalObject::setAlignment(unsigned int)' is deprecated [-Wdeprecated-declarations]
       G->setAlignment(Align);
                            ^
In file included from */llvm/llvm/include/llvm/Support/ErrorHandling.h:17:0,
                 from */llvm/llvm/include/llvm/ADT/Hashing.h:48,
                 from */llvm/llvm/include/llvm/ADT/ArrayRef.h:12,
                 from */llvm/llvm/include/llvm/ADT/DenseMapInfo.h:16,
                 from */llvm/llvm/include/llvm/ADT/DenseMap.h:16,
                 from */llvm/llvm/include/llvm/ADT/DenseSet.h:16,
                 from */llvm/llvm/include/llvm/IR/Function.h:20,
                 from */llvm/llvm/include/llvm/SYCLLowerIR/LowerWGScope.h:15,
                 from */llvm/llvm/lib/SYCLLowerIR/LowerWGScope.cpp:76:
*/llvm/llvm/include/llvm/IR/GlobalObject.h:86:34: note: declared here
   LLVM_ATTRIBUTE_DEPRECATED(void setAlignment(unsigned Align),

Signed-off-by: Artem Gindinson artem.gindinson@intel.com

The commit switches to using the `MaybeAlign` overload directly,
which addresses:

```
*/llvm/llvm/lib/SYCLLowerIR/LowerWGScope.cpp: In function 'llvm::Value* spirv::genPseudoLocalID(llvm::Instruction&, const llvm::Triple&)':
*/llvm/llvm/lib/SYCLLowerIR/LowerWGScope.cpp:929:28: warning: 'void llvm::GlobalObject::setAlignment(unsigned int)' is deprecated [-Wdeprecated-declarations]
       G->setAlignment(Align);
                            ^
In file included from */llvm/llvm/include/llvm/Support/ErrorHandling.h:17:0,
                 from */llvm/llvm/include/llvm/ADT/Hashing.h:48,
                 from */llvm/llvm/include/llvm/ADT/ArrayRef.h:12,
                 from */llvm/llvm/include/llvm/ADT/DenseMapInfo.h:16,
                 from */llvm/llvm/include/llvm/ADT/DenseMap.h:16,
                 from */llvm/llvm/include/llvm/ADT/DenseSet.h:16,
                 from */llvm/llvm/include/llvm/IR/Function.h:20,
                 from */llvm/llvm/include/llvm/SYCLLowerIR/LowerWGScope.h:15,
                 from */llvm/llvm/lib/SYCLLowerIR/LowerWGScope.cpp:76:
*/llvm/llvm/include/llvm/IR/GlobalObject.h:86:34: note: declared here
   LLVM_ATTRIBUTE_DEPRECATED(void setAlignment(unsigned Align),
```

Signed-off-by: Artem Gindinson <artem.gindinson@intel.com>
@AGindinson AGindinson force-pushed the private/agindins/maybealign-warning branch from 248d8e9 to 766d39b Compare March 28, 2020 10:51
@AGindinson AGindinson changed the title [SYCL][NFC] Use the non-deprecated setAlignment() in SYCLLowerWGScope [SYCL][NFC] Use the non-deprecated setAlignment() in LowerWGScope Mar 28, 2020
@bader bader merged commit a61ac0f into intel:sycl Mar 29, 2020
@AGindinson AGindinson deleted the private/agindins/maybealign-warning branch March 29, 2020 09:58
alexbatashev pushed a commit to alexbatashev/llvm that referenced this pull request Apr 15, 2020
…c_abi_checks

* origin/sycl: (6966 commits)
  [NFC][SYCL] Do not add `sycl_device` attribute to OpenCL kernel (intel#1439)
  [SYCL][NFC] Move SYCL pipe metadata call to be inside the null check for D (intel#1436)
  [SYCL][NFC] Move template function definition to .h file (intel#1433)
  [SYCL] Don't expose vector of booleans as storage format (intel#1419)
  [SYCL] Don't throw exceptions from destructors (intel#1378)
  [BuildBot] Add support for multiple CMake options (intel#1434)
  [SYCL][NFC] Fix warning inline namespace reopened as no-inline (intel#1435)
  [SYCL] Check if loadPlugin returns a nullptr (intel#1411)
  [SYCL] Release notes for February'20 SYCL implementation update (intel#1400)
  [SYCL][Doc] Improve contribution guidelines (intel#1422)
  [BuildBot] Add --cmake-opts option to configure.py script (intel#1430)
  [SYCL] Enable non-read-write memory object mapping in scheduler (intel#1390)
  [SYCL][Driver] Do not store AOT-specific options in the image descriptor (intel#1428)
  [Driver][NFC] Fix string problem used for tracking duplicate triples (intel#1424)
  [SYCL][NFC] Use the non-deprecated setAlignment() in LowerWGScope (intel#1420)
  [SYCL][NFC] Fix formatting in GetStartedGuide (intel#1417)
  [NFC] Move CODEOWNERS file to enable GitHub automation (intel#1418)
  [SYCL] Add test for private array init by zeroes (intel#1402)
  [Driver][SYCL][FPGA] Adjust device and AOCX link order for FPGA (intel#1389)
  [SYCL] Change runtime check to assert in program_manager.cpp (intel#1413)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants