Skip to content

[SYCL][Doc] Improve contribution guidelines #1422

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 31, 2020

Conversation

AGindinson
Copy link
Contributor

@AGindinson AGindinson commented Mar 28, 2020

  • Commit message requirements were added;
  • clang-format/clang-tidy usage became explicitly recommended;
  • Some stylistic issues were addressed (grammar, missing dots, etc.)

Signed-off-by: Artem Gindinson artem.gindinson@intel.com

@AGindinson AGindinson requested review from bader and pvchupin March 28, 2020 12:54
@AGindinson AGindinson force-pushed the private/agindins/contributing branch 2 times, most recently from b69fd19 to 5d43cba Compare March 28, 2020 12:58
- Commit message requirements were added;
- clang-format/clang-tidy usage became explicitly recommended;
- Some stylistic issues were addressed (grammar, missing dots, etc.)

Signed-off-by: Artem Gindinson <artem.gindinson@intel.com>
@AGindinson AGindinson force-pushed the private/agindins/contributing branch from 5d43cba to e52f198 Compare March 28, 2020 13:52
Signed-off-by: Artem Gindinson <artem.gindinson@intel.com>
@bader bader merged commit 2f5cd28 into intel:sycl Mar 31, 2020
@AGindinson AGindinson deleted the private/agindins/contributing branch March 31, 2020 08:19
alexbatashev pushed a commit to alexbatashev/llvm that referenced this pull request Apr 15, 2020
…c_abi_checks

* origin/sycl: (6966 commits)
  [NFC][SYCL] Do not add `sycl_device` attribute to OpenCL kernel (intel#1439)
  [SYCL][NFC] Move SYCL pipe metadata call to be inside the null check for D (intel#1436)
  [SYCL][NFC] Move template function definition to .h file (intel#1433)
  [SYCL] Don't expose vector of booleans as storage format (intel#1419)
  [SYCL] Don't throw exceptions from destructors (intel#1378)
  [BuildBot] Add support for multiple CMake options (intel#1434)
  [SYCL][NFC] Fix warning inline namespace reopened as no-inline (intel#1435)
  [SYCL] Check if loadPlugin returns a nullptr (intel#1411)
  [SYCL] Release notes for February'20 SYCL implementation update (intel#1400)
  [SYCL][Doc] Improve contribution guidelines (intel#1422)
  [BuildBot] Add --cmake-opts option to configure.py script (intel#1430)
  [SYCL] Enable non-read-write memory object mapping in scheduler (intel#1390)
  [SYCL][Driver] Do not store AOT-specific options in the image descriptor (intel#1428)
  [Driver][NFC] Fix string problem used for tracking duplicate triples (intel#1424)
  [SYCL][NFC] Use the non-deprecated setAlignment() in LowerWGScope (intel#1420)
  [SYCL][NFC] Fix formatting in GetStartedGuide (intel#1417)
  [NFC] Move CODEOWNERS file to enable GitHub automation (intel#1418)
  [SYCL] Add test for private array init by zeroes (intel#1402)
  [Driver][SYCL][FPGA] Adjust device and AOCX link order for FPGA (intel#1389)
  [SYCL] Change runtime check to assert in program_manager.cpp (intel#1413)
  ...
vmaksimo added a commit to vmaksimo/llvm that referenced this pull request Mar 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants