Added the SYCL_INTEL_mem_channel_property extension specification #2688
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This extension adds a new buffer property that will be useful for some FPGA targets.
jbrodman
approved these changes
Nov 3, 2020
alexbatashev
pushed a commit
to alexbatashev/llvm
that referenced
this pull request
Nov 6, 2020
* upstream/sycl: [SYCL] Move tests with dependencies to on-device directory (intel#2732) [SYCL][Test] Remove leftovers for FPGA archives (intel#2735) [SYCL][NFC] Extend ABI tests to cover device code (intel#2725) [SYCL] Fix link to ESIMD tests (intel#2736) Added the SYCL_INTEL_mem_channel_property extension specification (intel#2688) [SYCL] Add support for new FPGA loop attribute nofusion (intel#2715) [SYCL] Remove host-task-dependency test added to llvm-test-suite (intel#2720) [SYCL] Remove warning about SYCL_EXTERNAL with pointers (intel#2722) [SYCL] dot_product support. (intel#2609) [SYCL][PI][L0] Fix a problem with kernels and programs destruction while they can be used (intel#2710) [SYCL] Fix the check for read-only host pointer during memobj creation (intel#2697)
MrSidims
added a commit
to MrSidims/llvm
that referenced
this pull request
Dec 14, 2020
On some targets manual assignment of buffers to memory regions can improve memory bandwidth. This extension adds a buffer property to indicate in which memory channel a particular buffer should be allocated. This information is an optimization hint to the runtime and thus it is legal to ignore. Spec: intel#2688 Signed-off-by: Dmitry Sidorov <dmitry.sidorov@intel.com>
romanovvlad
pushed a commit
that referenced
this pull request
Dec 22, 2020
On some targets manual assignment of buffers to memory regions can improve memory bandwidth. This extension adds a buffer property to indicate in which memory channel a particular buffer should be allocated. This information is an optimization hint to the runtime and thus it is legal to ignore. Spec: #2688 Signed-off-by: Dmitry Sidorov <dmitry.sidorov@intel.com>
kbenzie
added a commit
to kbenzie/intel-llvm
that referenced
this pull request
Feb 17, 2025
Revert "Merge pull request intel#2606 from Bensuo/cmd-buf_enqueue_refactor"
kbenzie
pushed a commit
to kbenzie/intel-llvm
that referenced
this pull request
Feb 17, 2025
This is a regression after intel#2688
Chenyang-L
pushed a commit
that referenced
this pull request
Feb 18, 2025
Revert "Merge pull request #2606 from Bensuo/cmd-buf_enqueue_refactor"
Chenyang-L
pushed a commit
that referenced
this pull request
Feb 18, 2025
This is a regression after #2688
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This extension adds a new buffer property to indicate which channel in a multi-channel memory a buffer should be allocated in. This can help to get the most of your memory bandwidth by strategically allocating buffers between channels. This was motivated by some FPGA boards but could be useful for other targets as well.