Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: activate eslint for js files #1046

Merged
merged 1 commit into from
Mar 17, 2022
Merged

Conversation

dhhyi
Copy link
Collaborator

@dhhyi dhhyi commented Mar 7, 2022

PR Type

[x] Code style update (formatting, local variables)
[x] Refactoring (no functional changes, no API changes)
[x] Build-related changes

What Is the Current Behavior?

ESLint not running on JS files.

What Is the New Behavior?

ESLint running on JS files.

Does this PR Introduce a Breaking Change?

[ ] Yes
[x] No

Other Information

AB#74955

@dhhyi dhhyi added enhancement Enhancement to an existing feature community Community contributions labels Mar 7, 2022
@dhhyi dhhyi marked this pull request as draft March 7, 2022 10:27
@dhhyi dhhyi marked this pull request as ready for review March 7, 2022 11:45
@dhhyi dhhyi requested a review from MaxKless March 7, 2022 11:45
MaxKless
MaxKless previously approved these changes Mar 7, 2022
@shauke shauke added this to the 2.2 milestone Mar 8, 2022
@dhhyi dhhyi force-pushed the chore/eslint-for-js-files branch from f10ab54 to a1ae61c Compare March 10, 2022 14:09
@MaxKless MaxKless merged commit 6da4089 into develop Mar 17, 2022
@MaxKless MaxKless deleted the chore/eslint-for-js-files branch March 17, 2022 08:54
SGrueber pushed a commit that referenced this pull request May 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
community Community contributions enhancement Enhancement to an existing feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants