Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(schematics): improve schema generation #1078

Merged
merged 4 commits into from
Mar 29, 2022
Merged

refactor(schematics): improve schema generation #1078

merged 4 commits into from
Mar 29, 2022

Conversation

dhhyi
Copy link
Collaborator

@dhhyi dhhyi commented Mar 22, 2022 •
edited
Loading

PR Type

[x] Refactoring (no functional changes, no API changes)

What Is the Current Behavior?

Schema generation script has some flaws:

  • string replacements for unknown properties

What Is the New Behavior?

  • rewritten as mjs
  • custom banner template
  • provided prettier config for formatting correctly
  • use additionalProperties: false in schemas to prevent unspecified properties
  • use tsc instead of tsc-transpile-only
  • install required utility for speeding up postinstall of project

Does this PR Introduce a Breaking Change?

[ ] Yes
[ ] No

Other Information

AB#75421

@dhhyi dhhyi force-pushed the refactor/schematics-schema-generation branch 4 times, most recently from f7858e3 to 64fd4da Compare March 22, 2022 15:42
@dhhyi dhhyi added enhancement Enhancement to an existing feature community Community contributions labels Mar 22, 2022
@dhhyi dhhyi marked this pull request as ready for review March 22, 2022 17:52
@dhhyi dhhyi requested a review from MaxKless March 24, 2022 13:40
@dhhyi dhhyi mentioned this pull request Mar 24, 2022
Merged
@dhhyi dhhyi force-pushed the refactor/schematics-schema-generation branch from 64fd4da to 5a093c0 Compare March 25, 2022 10:48
@MaxKless MaxKless self-assigned this Mar 28, 2022
@MaxKless MaxKless merged commit b432c11 into develop Mar 29, 2022
@MaxKless MaxKless deleted the refactor/schematics-schema-generation branch March 29, 2022 15:09
@MaxKless MaxKless added this to the 2.2 milestone Mar 30, 2022
SGrueber pushed a commit that referenced this pull request May 19, 2022
@dhhyi @SGrueber
refactor(schematics): improve schema generation (#1078)
6ab267d
SGrueber pushed a commit that referenced this pull request May 19, 2022
Merged PR 1287: Update poc Sales solution to pwa 2.2
a346ab7 
Related work items: #963, #1017, #1030, #1046, #1048, #1051, #1053, #1054, #1055, #1056, #1057, #1058, #1061, #1067, #1069, #1072, #1074, #1075, #1076, #1077, #1078, #1079, #1082, #1083, #1084, #1085, #1086, #1090, #1093, #1095, #1096, #1099, #1101
@shauke shauke mentioned this pull request Jul 1, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MaxKless MaxKless MaxKless approved these changes

Assignees

@MaxKless MaxKless

Labels
community Community contributions enhancement Enhancement to an existing feature
Projects
None yet
Milestone
2.2
Development

Successfully merging this pull request may close these issues.
2 participants
@dhhyi @MaxKless