refactor: merge filter effects that trigger loadFilterSuccess #1048
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…le effect to avoid concurrency
dhhyi
previously approved these changes
Mar 7, 2022
dhhyi
added
bug
dhhyi
approved these changes
Mar 7, 2022
dhhyi
changed the title
SGrueber
pushed a commit
that referenced
this pull request
May 19, 2022
…into a single effect to avoid concurrency (#1048)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Type
[ ] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[x ] Refactoring (no functional changes, no API changes)
[ ] Build-related changes
[ ] CI-related changes
[ ] Documentation content changes
[ ] Application / infrastructure changes
[ ] Other:
What Is the Current Behavior?
Currently the filter effects contains multiple effects that trigger the same action. If the userchanges really fast from a filter triggered by a search and then triggers a category filter the current implementation allows the search filter to be applied after the category filter. Therefore the order is not respected and the wrong filters are displayed
Issue Number: Closes #
What Is the New Behavior?
The effects that trigger the same action (loadFilterSuccess) are now merged into a single effect. Switch map was added since we always want the latest source (previous ones can be dropped)
Does this PR Introduce a Breaking Change?
[ ] Yes
[ x] No
Other Information
AB#75013