Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: easily override default config for build #676

Closed
wants to merge 4 commits into from

Conversation

dhhyi
Copy link
Collaborator

@dhhyi dhhyi commented May 1, 2021

PR Type

[x] Feature
[x] Other: Customization enhancement

What Is the Current Behavior?

If a customer project uses a different default build configuration than production, the new configuration has to be inserted into quite a lot of scripts in package.json.

What Is the New Behavior?

The default configuration can be overridden in package.json or in local npm settings and automatically applies to all scripts.

Does this PR Introduce a Breaking Change?

[ ] Yes
[x] No

@dhhyi dhhyi added the enhancement Enhancement to an existing feature label May 1, 2021
@dhhyi dhhyi self-assigned this May 1, 2021
@dhhyi dhhyi force-pushed the feat/override-default-config branch from 45bab45 to 07d852e Compare May 1, 2021 23:30
@dhhyi dhhyi changed the base branch from develop to feat/dynamic-deploy-url May 1, 2021 23:31
@dhhyi dhhyi force-pushed the feat/override-default-config branch from 07d852e to cd87bb1 Compare May 3, 2021 07:30
@dhhyi dhhyi added the wait Waiting for something (e.g. new ICM release) label May 3, 2021
@dhhyi
Copy link
Collaborator Author

dhhyi commented May 3, 2021

wait for integration of #630

@dhhyi dhhyi force-pushed the feat/dynamic-deploy-url branch 2 times, most recently from 54961d3 to f259c00 Compare June 10, 2021 22:41
@jometzner jometzner force-pushed the feat/dynamic-deploy-url branch from f259c00 to e0f9c90 Compare June 28, 2021 07:31
@dhhyi dhhyi force-pushed the feat/dynamic-deploy-url branch from e0f9c90 to 5c68d69 Compare June 28, 2021 09:24
@dhhyi
Copy link
Collaborator Author

dhhyi commented Jul 9, 2021

Will be integrated into #775

@dhhyi dhhyi closed this Jul 9, 2021
@dhhyi dhhyi deleted the feat/override-default-config branch July 9, 2021 09:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Enhancement to an existing feature wait Waiting for something (e.g. new ICM release)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant