feat: set deploy URL as runtime property #630
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dhhyi
force-pushed
the
feat/dynamic-deploy-url
branch
from
0876388 to
46cd114
Compare
dhhyi
changed the title
dhhyi
force-pushed
the
feat/dynamic-deploy-url
branch
from
46cd114 to
b876fc2
Compare
dhhyi
force-pushed
the
feat/dynamic-deploy-url
branch
from
b876fc2 to
a4402f8
Compare
|
I have to take this back to WIP as it breaks |
dhhyi
force-pushed
the
feat/dynamic-deploy-url
branch
from
a4a7063 to
4b96efa
Compare
dhhyi
force-pushed
the
feat/dynamic-deploy-url
branch
from
4b96efa to
c618d58
Compare
dhhyi
changed the base branch from
develop
to
feature/translations-output-hashed
dhhyi
force-pushed
the
feature/translations-output-hashed
branch
from
8c725de to
828dc50
Compare
dhhyi
force-pushed
the
feat/dynamic-deploy-url
branch
from
c618d58 to
6285fe2
Compare
|
wait for integration of #655 |
dhhyi
force-pushed
the
feature/translations-output-hashed
branch
from
828dc50 to
4b07610
Compare
dhhyi
force-pushed
the
feat/dynamic-deploy-url
branch
2 times, most recently
from
c4ceb80 to
ed6433c
Compare
dhhyi
force-pushed
the
feature/translations-output-hashed
branch
2 times, most recently
from
658afe8 to
ba32a09
Compare
|
Closes AB#64439 |
shauke
force-pushed
the
develop
branch
2 times, most recently
from
e9b21fc to
09c2765
Compare
dhhyi
added a commit
that referenced
this pull request
Jul 22, 2021
dhhyi
force-pushed
the
feat/dynamic-deploy-url
branch
from
9763b31 to
ce9cac1
Compare
dhhyi
added a commit
that referenced
this pull request
Jul 22, 2021
dhhyi
force-pushed
the
feat/dynamic-deploy-url
branch
from
ce9cac1 to
5004f9e
Compare
dhhyi
added a commit
that referenced
this pull request
Jul 29, 2021
dhhyi
force-pushed
the
feat/dynamic-deploy-url
branch
from
5004f9e to
d0f0e45
Compare
Co-authored-by: Marcus Schmidt <marcus.schmidt@intershop.de>
jometzner
force-pushed
the
feat/dynamic-deploy-url
branch
from
d0f0e45 to
561a4c6
Compare
jometzner
previously approved these changes
Jul 30, 2021
marschmidt89
approved these changes
Jul 30, 2021
jometzner
approved these changes
Jul 30, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Type
[x] Feature
What Is the Current Behavior?
Deploy URL in links to static resources is sometimes used relatively and sometimes absolute.
Issue Number: Closes #624
What Is the New Behavior?
The deploy URL (which can be set for default Angular projects with
ng build --deploy-url) can be set via environment variableDEPLOY_URLto the SSR process.If not set, the default deployment URL
/is applied, which ensures, all static assets are correctly loaded from the deployment root.This PR also makes it possible to use deeply nested
baseHrefs with a Multi-Channel context path setup.This PR depends on #655 to make the Angular application independent on the
DEPLOY_URL.Does this PR Introduce a Breaking Change?
[ ] Yes
[x] No
TODO
AB#65697