-
Notifications
You must be signed in to change notification settings - Fork 86
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: load translations with webpack #655
Conversation
c0028a7
to
8c725de
Compare
8c725de
to
828dc50
Compare
828dc50
to
4b07610
Compare
Hi Danilo, thanks for the PR. |
aab383f
to
658afe8
Compare
658afe8
to
ba32a09
Compare
@MaxKless I rebased and put in some refactoring. Please test if everything still works properly. |
PR Type
[x] Feature
What Is the Current Behavior?
ngx-translate
translation files are loaded with TranslateHttpLoader on the browser side and a special translate loader on the server side. Due to this handling, the translation files are not automatically output-hashed via Angular CLI. This can lead to misbehavior, when new keys are added but the browser still holds the old translation file in the browser cache.What Is the New Behavior?
The old mechanism ofDoesn't work with FFregisterLocaleData
is exchanged with the new oneand Angular locale datais put into its own bundle and pulled when needed.Does this PR Introduce a Breaking Change?
[ ] Yes
[x] No