feat: respect icm language settings #661
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dhhyi
added
enhancement
dhhyi
changed the title
dhhyi
force-pushed
the
feature/respect-icm-language-settings
branch
from
74b628a to
6763a2e
Compare
dhhyi
changed the base branch from
develop
to
feature/translations-fallback-handling
|
wait for integration of #659 |
dhhyi
force-pushed
the
feature/respect-icm-language-settings
branch
from
6763a2e to
1b0f3fb
Compare
dhhyi
force-pushed
the
feature/translations-fallback-handling
branch
from
d3a8f27 to
933adfe
Compare
- needed for access to locale setting of ICM in core configuration state - relates to #227
dhhyi
force-pushed
the
feature/respect-icm-language-settings
branch
from
1b0f3fb to
aed33fd
Compare
|
Hi Danilo, thanks for the PR! When you submitted this, we were in the middle of our own localization rework. You wrote some nice code, though and we used parts of it in #695 . |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Type
[x] Feature
[x] Refactoring (no functional changes, no API changes)
What Is the Current Behavior?
The PWA ignores locale settings from the ICM, that are available in the
configurationsREST response.What Is the New Behavior?
If retrieved, the PWA uses the ICM locale settings to set a default locale and filter available locales based on channel settings.
Does this PR Introduce a Breaking Change?
[ ] Yes
[x] No
Other Information
To have access t the configurations call results in the configurations store, the server-config store has to be moved from general to core.