feat : load translations from icm #695
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MaxKless
force-pushed
the
feat/load-translations-from-icm
branch
from
92a5d6c to
490dd8c
Compare
MaxKless
force-pushed
the
feat/load-translations-from-icm
branch
3 times, most recently
from
7744ef3 to
6adcb38
Compare
|
Cypres test is failing due to issue with ICM localization resource (IS-32998). |
jometzner
force-pushed
the
feat/load-translations-from-icm
branch
2 times, most recently
from
72d73cd to
c7b9250
Compare
jometzner
reviewed
May 27, 2021
marschmidt89
previously approved these changes
May 28, 2021
jometzner
reviewed
May 31, 2021
jometzner
force-pushed
the
feat/load-translations-from-icm
branch
from
f759b6d to
533593e
Compare
jometzner
approved these changes
Jun 1, 2021
This was referenced Jun 2, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Type
[ ] Bugfix
[x] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no API changes)
[ ] Build-related changes
[ ] CI-related changes
[ ] Documentation content changes
[ ] Application / infrastructure changes
[ ] Other:
What Is the Current Behavior?
Currently, it is only possible to change translations by updating one of the translation files and re-deploying the PWA.
Issue Number: Closes #
With this PR, it will be possible to update translations in the ICM or somewhere remote and load them into the PWA without redeploying.
ToDo
Does this PR Introduce a Breaking Change?
[ ] Yes
[ ] No
Other Information