Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Auth.useUserAccessGroup breaks with firebase-ios-sdk 7.8.0 #5007

Closed
mikehardy opened this issue Mar 10, 2021 · 1 comment · Fixed by #5022
Closed

Auth.useUserAccessGroup breaks with firebase-ios-sdk 7.8.0 #5007

mikehardy opened this issue Mar 10, 2021 · 1 comment · Fixed by #5022
Labels
help: needs-triage Issue needs additional investigation/triaging. platform: ios plugin: authentication Firebase Authentication type: bug New bug report

Comments

@mikehardy
Copy link
Collaborator

mikehardy commented Mar 10, 2021 •
edited
Loading

firebase-ios-sdk 7.8.0 appears to have a break:

  1) auth()
       useUserAccessGroup()
         should return "null" on successful keychain implementation:
     NativeFirebaseError: [auth/keychain-error] An error occurred when accessing the keychain. The NSLocalizedFailureReasonErrorKey field in the NSError.userInfo dictionary will contain more information about the error encountered
      at FirebaseAuthModule.useUserAccessGroup (http://localhost:8081/index.bundle?platform=ios&dev=true&minify=false&sourceMapURL=true:137809:28)
      at Context.<anonymous> (/Users/runner/work/react-native-firebase/react-native-firebase/packages/auth/e2e/auth.e2e.js:1049:56)

Perhaps this? https://firebase.google.com/support/release-notes/ios#authentication / firebase/firebase-ios-sdk#7472

  1. We are not printing the contents of NSError.userInfo dictionary so we do not have more information
  2. It should not error, obviously

Originally posted by @mikehardy in #5005 (comment)
@mikehardy mikehardy added help: needs-triage Issue needs additional investigation/triaging. type: bug New bug report platform: ios plugin: authentication Firebase Authentication labels Mar 10, 2021
@mikehardy
Copy link
Collaborator Author

reproduced locally

mikehardy added a commit that referenced this issue Mar 12, 2021
@mikehardy
fix(auth, useUserAccessGroup): document auth/keychain-error, add test…
3e4d0fd 
… coverage

The update to firebase-ios-sdk v7.8.0 which fixed an underlying useUserAccessGroup issue
exposed an error in the E2E test that covers our wrapper for the method when it started
returning an error in a legitimately incorrect usage.

This patches up the test case and documents the error that may be thrown

Fixes #5007
@mikehardy mikehardy mentioned this issue Mar 12, 2021
Merged
8 tasks
mikehardy added a commit that referenced this issue Mar 12, 2021
@mikehardy
fix(auth, useUserAccessGroup): document auth/keychain-error, add test…
60ec5f9 
… coverage

The update to firebase-ios-sdk v7.8.0 which fixed an underlying useUserAccessGroup issue
exposed an error in the E2E test that covers our wrapper for the method when it started
returning an error in a legitimately incorrect usage.

This patches up the test case and documents the error that may be thrown

Fixes #5007
This was referenced Mar 15, 2021
Closed
Closed
Closed
Closed
androidIsForVivek pushed a commit to androidIsForVivek/react-native-firebase that referenced this issue Sep 15, 2021
@mikehardy
fix(auth, useUserAccessGroup): document auth/keychain-error, add test…
12d97ea 
… coverage

The update to firebase-ios-sdk v7.8.0 which fixed an underlying useUserAccessGroup issue
exposed an error in the E2E test that covers our wrapper for the method when it started
returning an error in a legitimately incorrect usage.

This patches up the test case and documents the error that may be thrown

Fixes invertase#5007
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
help: needs-triage Issue needs additional investigation/triaging. platform: ios plugin: authentication Firebase Authentication type: bug New bug report
Projects
None yet
Milestone
No milestone
1 participant
@mikehardy