Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: dependency updates 20210312 #5022

Merged
merged 5 commits into from
Mar 12, 2021
Merged

Conversation

mikehardy
Copy link
Collaborator

Description

Standard dependency updates

I think there is still an iOS E2E CI problem, this should show it (or maybe it will be fixed now ?)

Related issues

Release Summary

Each commit is conventional-commit correct, rebase merge

Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
    • Yes
  • My change supports the following platforms;
    • Android
    • iOS
  • My change includes tests;
    • e2e tests added or updated in packages/\*\*/e2e
    • jest tests added or updated in packages/\*\*/__tests__
  • I have updated TypeScript types that are affected by my change.
  • This is a breaking change;
    • Yes
    • No

Test Plan

Ran yarn tests:jest and yarn tests:ios:test and yarn tests:android:test locally until everything was working


Think react-native-firebase is great? Please consider supporting the project with any of the below:

- increase min deploy target for all pods, eliminates non-actionable warnings
- stop overriding other warning settings, leave them as default
- stop overriding build architectures, .xcframework ecosystem changes should make everything work
- minimum deploy target used in a couple places now
- better links / description for other Podfile elements
note: still leaving detox, superstruct, metro-react-native-babel-preset and @types/react
… coverage

The update to firebase-ios-sdk v7.8.0 which fixed an underlying useUserAccessGroup issue
exposed an error in the E2E test that covers our wrapper for the method when it started
returning an error in a legitimately incorrect usage.

This patches up the test case and documents the error that may be thrown

Fixes #5007
@vercel
Copy link

vercel bot commented Mar 12, 2021

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/invertase/react-native-firebase/FA6wZpSzkWv4GDAf3TdMhSPPt21X
✅ Preview: https://react-native-f-git-mikehardy-dependency-updates-in-310d7b.vercel.app

@mikehardy mikehardy added the Workflow: Pending Merge Waiting on CI or similar label Mar 12, 2021
@codecov
Copy link

codecov bot commented Mar 12, 2021

Codecov Report

Merging #5022 (7605bb7) into master (06eebad) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #5022   +/-   ##
=======================================
  Coverage   89.09%   89.09%           
=======================================
  Files         109      109           
  Lines        3721     3721           
  Branches      348      348           
=======================================
  Hits         3315     3315           
  Misses        365      365           
  Partials       41       41           

@mikehardy mikehardy changed the title Dependency updates 20210312 chore: dependency updates 20210312 Mar 12, 2021
@mikehardy mikehardy removed the Workflow: Pending Merge Waiting on CI or similar label Mar 12, 2021
@mikehardy mikehardy merged commit d2b0074 into master Mar 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Auth.useUserAccessGroup breaks with firebase-ios-sdk 7.8.0
1 participant