Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(ios, sdk): bump firebase-ios-sdk to 7.8.0 #5005

Closed
wants to merge 1 commit into from

Conversation

mikehardy
Copy link
Collaborator

Description

Periodic dependency update on underlying SDK

Related issues

Release Summary

PR title

Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
    • Yes
  • My change supports the following platforms;
    • Android
    • iOS
  • My change includes tests;
    • e2e tests added or updated in packages/\*\*/e2e
    • jest tests added or updated in packages/\*\*/__tests__
  • I have updated TypeScript types that are affected by my change.
  • This is a breaking change;
    • Yes
    • No

Test Plan


Think react-native-firebase is great? Please consider supporting the project with any of the below:

@vercel
Copy link

vercel bot commented Mar 10, 2021

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/invertase/react-native-firebase/F38Zjd9sXpNQhsNFziwR3XNoK8Yb
✅ Preview: https://react-native-firebase-git-mikehardy-ios-sdk-780-invertase.vercel.app

@mikehardy mikehardy added the Workflow: Pending Merge Waiting on CI or similar label Mar 10, 2021
@codecov
Copy link

codecov bot commented Mar 10, 2021

Codecov Report

Merging #5005 (5100dc6) into master (06eebad) will decrease coverage by 0.43%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #5005      +/-   ##
==========================================
- Coverage   89.09%   88.66%   -0.42%     
==========================================
  Files         109      109              
  Lines        3721     3721              
  Branches      348      348              
==========================================
- Hits         3315     3299      -16     
- Misses        365      381      +16     
  Partials       41       41              

@mikehardy mikehardy added Workflow: Waiting for User Response Blocked waiting for user response. and removed Workflow: Pending Merge Waiting on CI or similar labels Mar 10, 2021
@mikehardy mikehardy self-assigned this Mar 10, 2021
@mikehardy
Copy link
Collaborator Author

firebase-ios-sdk 7.8.0 appears to have a break:

  1) auth()
       useUserAccessGroup()
         should return "null" on successful keychain implementation:
     NativeFirebaseError: [auth/keychain-error] An error occurred when accessing the keychain. The NSLocalizedFailureReasonErrorKey field in the NSError.userInfo dictionary will contain more information about the error encountered
      at FirebaseAuthModule.useUserAccessGroup (http://localhost:8081/index.bundle?platform=ios&dev=true&minify=false&sourceMapURL=true:137809:28)
      at Context.<anonymous> (/Users/runner/work/react-native-firebase/react-native-firebase/packages/auth/e2e/auth.e2e.js:1049:56)

Perhaps this? https://firebase.google.com/support/release-notes/ios#authentication / firebase/firebase-ios-sdk#7472

  1. We are not printing the contents of NSError.userInfo dictionary so we do not have more information
  2. It should not error, obviously

Separately:

We need to turn off detox TRACE logging on iOS at least, it is too verbose

@mikehardy
Copy link
Collaborator Author

Superceded by #5022 where the auth.useUserAccessGroup issue is fixed

@mikehardy mikehardy closed this Mar 12, 2021
@mikehardy mikehardy deleted the @mikehardy/ios-sdk-7.8.0 branch March 12, 2021 19:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Workflow: Waiting for User Response Blocked waiting for user response.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant