Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(core): matchBreakpoint will return true if breakPoint is empty string #15498

Merged
merged 1 commit into from
Sep 7, 2018
Merged

fix(core): matchBreakpoint will return true if breakPoint is empty string #15498

merged 1 commit into from
Sep 7, 2018

Conversation

paulstelzer
Copy link
Contributor

@paulstelzer paulstelzer commented Sep 7, 2018 •
edited
Loading

Short description of what this resolves:

Correct breakpoint will be returned so ion-col is working correctly

Ionic Version: 4.0

Closes #15495

@ionitron-bot ionitron-bot bot added the package: core @ionic/core package label Sep 7, 2018
@paulstelzer
Copy link
Contributor Author

@manucorporat friendly asking for review :)

@manucorporat manucorporat merged commit b362b0a into ionic-team:master Sep 7, 2018
@manucorporat
Copy link
Contributor

@paulstelzer thanks a lot for the fix!

@mhartington mhartington mentioned this pull request Sep 7, 2018
Closed
@paulstelzer paulstelzer mentioned this pull request Sep 10, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
package: core @ionic/core package
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[v4.0.0-beta.8] ion-col size not supported
2 participants
@paulstelzer @manucorporat