[Melodic] workaround missing dependencies #782

fmessmer · 2019-08-07T12:45:18Z

in #780 we introduced a new default branch kinetic_dev with is supposed to supporte both kinetic and melodic distros
unfortunately, universal_robots is not yet released into melodic and also the ur_driver is no longer maintained - in favor of ur_modern_driver

thus, I commented everything ur_X-related in order to achieve the envisaged dual-distro-compatibility

this means that on the real robot hardware (raw3-1 only), kinetic_dev will not work
however, the "old" indigo_dev branch is still kinetic-compatible and has the ur_X stuff included
thus, when using this branch, raw3-1 can still be operated as is...as long as cob_robot is not switched to cob_robots/kinetic_dev

@ipa-jba @ipa-fez @ipa-jcl @ipa-mjp @ipa-mah @ipa-rmb FYI

fmessmer · 2019-08-07T15:50:05Z

realsense_camera and realsense2_camera are not release to melodic - see IntelRealSense/realsense-ros#386 (comment)

unfortunately, the comment-approach does not work for these packages...

fmessmer · 2019-08-07T20:37:35Z

I guess we will not be able to get a melodic release ready for cob_robots (and cob_simulation) due to the missing dependencies...

fmessmer

it got a bit messier than I thought in the beginning, but now I think I got a version that allows us to support/check kinetic and melodic compatibility

we cannot release cob_robots into melodic (for now), though
and we will need for ros/rosdistro#21966 to get merged

@ipa-fez @ipa-jba @ipa-jcl @ipa-mjp @ipa-mah @ipa-rmb
any opinions on this PR?

fmessmer · 2019-08-08T10:19:14Z

.travis.rosinstall

+- git:
+    local-name: realsense2_substitute
+    uri: https://github.com/ipa320/realsense.git
+    version: realsense2_substitute


this is needed because realsense2_camera is not released into kinetic
(although, I commented that dependency again)

fmessmer · 2019-08-08T10:19:54Z

.travis.rosinstall.melodic

+- git:
+    local-name: realsense_substitute
+    uri: https://github.com/ipa320/realsense.git
+    version: realsense_substitute


this is needed because realsense_camera is not released into melodic

fmessmer · 2019-08-08T10:20:03Z

.travis.rosinstall.melodic

+- git:
+    local-name: realsense2_substitute
+    uri: https://github.com/ipa320/realsense.git
+    version: realsense2_substitute


this is needed because realsense2_camera is not released into melodic
(although, I commented that dependency again)

fmessmer · 2019-08-08T10:21:13Z

cob_bringup/drivers/sick_visionary_t.launch

@@ -13,6 +13,6 @@
 		<remap from="$(arg name)_node/intensity" to="$(arg name)/depth/intensity"/>
 		<remap from="$(arg name)_node/ios" to="$(arg name)/depth/ios"/>
 		<remap from="$(arg name)_node/points" to="$(arg name)/depth/points"/>
-	</node>
+	</node-->


I do not feel responsible for this repo anymore...all robots using it, could stay on the indigo_dev branch and still use kinetic

fmessmer · 2019-08-08T10:21:42Z

cob_bringup/drivers/ur.launch

@@ -15,13 +15,13 @@

 	<group unless="$(arg sim)">
 		<!-- universal robot python driver -->
-		<node unless="$(arg use_modern_driver)" ns="arm/joint_trajectory_controller" pkg="ur_driver" type="driver.py" name="ur_driver" args="$(arg robot_ip) $(arg reverse_port)" output="screen">
+		<!--node unless="$(arg use_modern_driver)" ns="arm/joint_trajectory_controller" pkg="ur_driver" type="driver.py" name="ur_driver" args="$(arg robot_ip) $(arg reverse_port)" output="screen">


ur_driver is not supported anymore

fmessmer · 2019-08-08T10:22:22Z

cob_hardware_config/package.xml

@@ -33,7 +33,7 @@
  <exec_depend>raw_description</exec_depend>
  <exec_depend>robot_state_publisher</exec_depend>
  <exec_depend>rviz</exec_depend>
-  <exec_depend>ur_description</exec_depend>
+  <!--exec_depend>ur_description</exec_depend-->


ur_description is not released into melodic...all robots using it, could stay on the indigo_dev branch and still use kinetic

fmessmer · 2019-08-08T10:22:39Z

cob_bringup/package.xml

  <exec_depend>spacenav_node</exec_depend>
  <exec_depend>tf2_ros</exec_depend>
  <exec_depend>theora_image_transport</exec_depend> <!-- needed by the cameras to publish the compressed topics -->
  <exec_depend>topic_tools</exec_depend>
  <exec_depend>twist_mux</exec_depend>
-  <exec_depend>ur_driver</exec_depend>
+  <!--exec_depend>ur_driver</exec_depend-->


ur_driver is not released into melodic...all robots using it, could stay on the indigo_dev branch and still use kinetic

fmessmer · 2019-08-08T10:22:48Z

cob_bringup/package.xml

  <exec_depend>robot_state_publisher</exec_depend>
  <exec_depend>rosserial_python</exec_depend>
  <exec_depend>rosserial_server</exec_depend>
  <exec_depend>rostopic</exec_depend>
  <exec_depend>rplidar_ros</exec_depend>
  <exec_depend>rviz</exec_depend>
-  <exec_depend>sick_visionary_t_driver</exec_depend>
+  <!--exec_depend>sick_visionary_t_driver</exec_depend-->


sick_visionary_t_driver is not released into melodic...all robots using it, could stay on the indigo_dev branch and still use kinetic

ipa-fez · 2019-08-08T10:47:41Z

Looks OK to me.

ipa-rmb · 2019-08-26T10:58:23Z

Fine to me, thanks for your explanations!

fmessmer added 2 commits August 7, 2019 14:39

comment ur dependencies

09a2162

re-activate melodic checks

a7302f5

fmessmer changed the title ~~comment ur dependencies~~ [Melodic] comment ur dependencies Aug 7, 2019

comment sick_visionary_t

fd4cd11

add realsense overlays

875918d

fmessmer changed the title ~~[Melodic] comment ur dependencies~~ [Melodic] workaround missing dependencies Aug 8, 2019

add missing dependency to realsense2_camera

12eaffb

fmessmer force-pushed the comment_ur_dependencies branch from ae8125b to 4fb4e32 Compare August 8, 2019 07:55

use realsense substitute packages

a0a5ef9

fmessmer force-pushed the comment_ur_dependencies branch from 4fb4e32 to a0a5ef9 Compare August 8, 2019 09:02

comment realsense2_camera dependency

b33709d

fmessmer force-pushed the comment_ur_dependencies branch from d651363 to b33709d Compare August 8, 2019 09:37

fmessmer commented Aug 8, 2019

View reviewed changes

fmessmer mentioned this pull request Aug 8, 2019

Melodic testing/migration ipa320/care-o-bot#52

Closed

comment unused dependency cob_collision_monitor

1325573

fmessmer force-pushed the comment_ur_dependencies branch from 65376ac to ca45da9 Compare August 10, 2019 13:12

add missing overlays to rosinstall

2de9fe9

fmessmer force-pushed the comment_ur_dependencies branch from ca45da9 to 2de9fe9 Compare August 10, 2019 14:14

fmessmer merged commit ae1c168 into ipa320:kinetic_dev Aug 10, 2019

fmessmer deleted the comment_ur_dependencies branch August 10, 2019 14:58

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Melodic] workaround missing dependencies #782

[Melodic] workaround missing dependencies #782

fmessmer commented Aug 7, 2019 •

edited

Loading

fmessmer commented Aug 7, 2019

fmessmer commented Aug 7, 2019

fmessmer left a comment •

edited

Loading

fmessmer Aug 8, 2019

fmessmer Aug 8, 2019

fmessmer Aug 8, 2019

fmessmer Aug 8, 2019

fmessmer Aug 8, 2019

fmessmer Aug 8, 2019

fmessmer Aug 8, 2019

fmessmer Aug 8, 2019

ipa-fez commented Aug 8, 2019

ipa-rmb commented Aug 26, 2019

[Melodic] workaround missing dependencies #782

[Melodic] workaround missing dependencies #782

Conversation

fmessmer commented Aug 7, 2019 • edited Loading

fmessmer commented Aug 7, 2019

fmessmer commented Aug 7, 2019

fmessmer left a comment • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

ipa-fez commented Aug 8, 2019

ipa-rmb commented Aug 26, 2019

fmessmer commented Aug 7, 2019 •

edited

Loading

fmessmer left a comment •

edited

Loading