Start fixing appveyor

[dignifiedquire]

No description provided.

[jbenet]

• http://help.appveyor.com/discussions/problems/1467-building-with-makefile
• http://stackoverflow.com/questions/12881854/how-to-use-gnu-make-on-windows

we may need to move it into the path?

[jbenet]

also, Feodor said

Both MinGW and MSYS are installed on unstable image.

[dignifiedquire]

Progress, now make is running, but go install fails but need some more insight on that from go pros ;) https://ci.appveyor.com/project/ipfsbot/test/build/33

cc @whyrusleeping @jbenet

[jbenet]

looks like the project is cloned to:

git clone -q https://github.com/ipfs/go-ipfs.git C:\projects\test

but that's not in the gopath, and it's looking for the packages in the proper gopath:

daemon.go:14:2: cannot find package "github.com/ipfs/go-ipfs/Godeps/_workspace/src/github.com/codahale/metrics/runtime" in any of:
    c:\go\src\github.com\ipfs\go-ipfs\Godeps\_workspace\src\github.com\codahale\metrics\runtime (from $GOROOT)
    c:\gopath\src\github.com\ipfs\go-ipfs\Godeps\_workspace\src\github.com\codahale\metrics\runtime (from $GOPATH)

I would try:

mkdir -p c:\go\src\github.com\ipfs
mv C:\projects\test c:\go\src\github.com\ipfs\go-ipfs
cd c:\go\src\github.com\ipfs\go-ipfs
# carry on

i dont think symlinks will work

[dignifiedquire]

Thanks @jbenet I changed the target clone directory to what you suggested and the go install is now working as expected. Sadly it now fails because it tries to install bazil.org/fuse which has no support on windows, so we need a way that go install does not even tries to install it as far as I understand.

[rht]

From the doc, it appears this should have been mingw32-make nofuse in windows.
An os detect to add the nofuse flag could have been incorporated into the makefile.

[rht]

For faster build,

cache:
- C:\ProgramData\chocolatey\bin -> appveyor.yml
- C:\ProgramData\chocolatey\lib -> appveyor.yml

can be added [1].

[1] http://www.appveyor.com/docs/build-cache

[dignifiedquire]

@rht actually we don't need to install anything with chocolatey I realised, mingw and go 1.5.1 are already preinstalled :)

[dignifiedquire]

@rht I'm not able to pass the nofuse flag properly through to the tests. Any ideas how to fix that?

[rht]

What about adding satisfied_prereq: EXPENSIVE NOFUSE to the env manually?

[rht]

I mean satisfied_prereq: EXPENSIVE. FUSE seems to be opt-in rather than default.

Since the TEST_EXPENSIVE flag is used to set the satisfied_prereq flag (https://github.com/ipfs/go-ipfs/blob/9066b12d33cd67e083c15c58767c5a629c5165e2/test/sharness/lib/test-lib.sh#L42-L43).

[rht]

test_set_prereq.

If it doesn't work, the likely cause is due to satisfied_prereq being overridden after installing sharness

[rht]

Actually, since go builds just fine, go test -tags nofuse ./... can be added before running the sharness test. However, expect to see lots of goroutine errs.

[rht]

@dignifiedquire, so it appears windows shell uses a different syntax to set the env var[1].
The sharness lib assumes it is run in a POSIX shell...

[1] #1982 (comment)

[dignifiedquire]

yeah I was afraid of that, looks like most of the test setup is posix specific :( I will try to look if I can use cygwin or sth like that to emulate it, otherwise this will be really tricky

[dignifiedquire]

@rht okay switched to using cygwin bash, which should support environment variables in posix style, but for some reason it's still trying to run the fuse tests :(

[rht]

TEST_NO_FUSE is to run the test without fuse, but the binary is still built with fuse, which then fails.

Re-enabling GOFLAGS: -tags nofuse should do.

[dignifiedquire]

@rht still failing :(

[GitCop]

There were the following issues with your Pull Request

• Commit: 243a158
  • Invalid signoff. Commit message must end with
    License: MIT
    Signed-off-by: .* <.*>

Guidelines and a script are available to help. Your feedback on GitCop is welcome on this issue.

---

This message was auto-generated by https://gitcop.com