check_instanceable.py in /source/standalone/tools has issues #242
Labels
bug
Something isn't working
Comments
|
Thank you for pointing this out. Would you like to send the MR with the fix? :) |
|
Ok will do |
6 tasks
Junfeng-Long
pushed a commit
to Junfeng-Long/IsaacLab
that referenced
this issue
Feb 27, 2024
# Description This MR goes over the current implementations of Stable-Baselines3 and RL-Games wrapper. It fixes the wrapper implementations as well as the checkpoint loader to work for the logging format of these wrappers. The changes have been tested against the `Isaac-Cartpole-v0` environment from MR isaac-sim#241. ## Type of change - Bug fix (non-breaking change which fixes an issue) ## Checklist - [x] I have run the [`pre-commit` checks](https://pre-commit.com/) with `./orbit.sh --format` - [x] I have made corresponding changes to the documentation - [x] My changes generate no new warnings - [ ] I have added tests that prove my fix is effective or that my feature works - [x] I have updated the changelog and the corresponding version in the extension's `config/extension.toml` file - [x] I have added my name to the `CONTRIBUTORS.md` or my name already exists there
Mayankm96
pushed a commit
that referenced
this issue
Feb 29, 2024
# Description
In line 106 of the `check_instanceable.py` script, there is a typo
error.
The line goes as:
```python
prim_utils.create_prim("/World/envs/env_0/Asset", "Xform", usd_path=os.path.abspath(args_cli.usd_path))
```
but should be:
```python
prim_utils.create_prim("/World/envs/env_0/Asset", "Xform", usd_path=os.path.abspath(args_cli.input))
```
Fixes #242
## Type of change
- Bug fix (non-breaking change which fixes an issue)
## Checklist
- [x] I have run the [`pre-commit` checks](https://pre-commit.com/) with
`./orbit.sh --format`
- [ ] I have made corresponding changes to the documentation
- [x] My changes generate no new warnings
- [ ] I have added tests that prove my fix is effective or that my
feature works
- [x] I have run all the tests with `./orbit.sh --test` and they pass
- [ ] I have updated the changelog and the corresponding version in the
extension's `config/extension.toml` file
Note: These 5 symbols that I changed do not require putting my name on
the contributors list.
fatimaanes
pushed a commit
to fatimaanes/omniperf
that referenced
this issue
Aug 8, 2024
# Description This MR goes over the current implementations of Stable-Baselines3 and RL-Games wrapper. It fixes the wrapper implementations as well as the checkpoint loader to work for the logging format of these wrappers. The changes have been tested against the `Isaac-Cartpole-v0` environment from MR isaac-sim#241. ## Type of change - Bug fix (non-breaking change which fixes an issue) ## Checklist - [x] I have run the [`pre-commit` checks](https://pre-commit.com/) with `./orbit.sh --format` - [x] I have made corresponding changes to the documentation - [x] My changes generate no new warnings - [ ] I have added tests that prove my fix is effective or that my feature works - [x] I have updated the changelog and the corresponding version in the extension's `config/extension.toml` file - [x] I have added my name to the `CONTRIBUTORS.md` or my name already exists there
fatimaanes
pushed a commit
to fatimaanes/omniperf
that referenced
this issue
Aug 8, 2024
# Description
In line 106 of the `check_instanceable.py` script, there is a typo
error.
The line goes as:
```python
prim_utils.create_prim("/World/envs/env_0/Asset", "Xform", usd_path=os.path.abspath(args_cli.usd_path))
```
but should be:
```python
prim_utils.create_prim("/World/envs/env_0/Asset", "Xform", usd_path=os.path.abspath(args_cli.input))
```
Fixes isaac-sim#242
## Type of change
- Bug fix (non-breaking change which fixes an issue)
## Checklist
- [x] I have run the [`pre-commit` checks](https://pre-commit.com/) with
`./orbit.sh --format`
- [ ] I have made corresponding changes to the documentation
- [x] My changes generate no new warnings
- [ ] I have added tests that prove my fix is effective or that my
feature works
- [x] I have run all the tests with `./orbit.sh --test` and they pass
- [ ] I have updated the changelog and the corresponding version in the
extension's `config/extension.toml` file
Note: These 5 symbols that I changed do not require putting my name on
the contributors list.
iamdrfly
pushed a commit
to iamdrfly/IsaacLab
that referenced
this issue
Nov 21, 2024
# Description
In line 106 of the `check_instanceable.py` script, there is a typo
error.
The line goes as:
```python
prim_utils.create_prim("/World/envs/env_0/Asset", "Xform", usd_path=os.path.abspath(args_cli.usd_path))
```
but should be:
```python
prim_utils.create_prim("/World/envs/env_0/Asset", "Xform", usd_path=os.path.abspath(args_cli.input))
```
Fixes isaac-sim#242
## Type of change
- Bug fix (non-breaking change which fixes an issue)
## Checklist
- [x] I have run the [`pre-commit` checks](https://pre-commit.com/) with
`./orbit.sh --format`
- [ ] I have made corresponding changes to the documentation
- [x] My changes generate no new warnings
- [ ] I have added tests that prove my fix is effective or that my
feature works
- [x] I have run all the tests with `./orbit.sh --test` and they pass
- [ ] I have updated the changelog and the corresponding version in the
extension's `config/extension.toml` file
Note: These 5 symbols that I changed do not require putting my name on
the contributors list.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Describe the bug
In line 106 of the check_instanceable.py script there is an error - line goes as
prim_utils.create_prim("/World/envs/env_0/Asset", "Xform", usd_path=os.path.abspath(args_cli.usd_path))but it should be
prim_utils.create_prim("/World/envs/env_0/Asset", "Xform", usd_path=os.path.abspath(args_cli.input))Steps to reproduce
Run check_instanceable.py script with any USD file.
System Info
Describe the characteristic of your environment:
Checklist
Acceptance Criteria
The text was updated successfully, but these errors were encountered: