Adds a validity check for configclasses #1214
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Dhoeller19
requested review from
Mayankm96,
jsmith-bdai and
kellyguo11
as code owners
lgulich
approved these changes
Oct 11, 2024
Mayankm96
reviewed
Oct 11, 2024
source/extensions/omni.isaac.lab/omni/isaac/lab/utils/configclass.py
Outdated
Show resolved
Hide resolved
Mayankm96
reviewed
Oct 11, 2024
source/extensions/omni.isaac.lab/omni/isaac/lab/utils/configclass.py
Outdated
Show resolved
Hide resolved
…ass.py Co-authored-by: Mayank Mittal <12863862+Mayankm96@users.noreply.github.com> Signed-off-by: David Hoeller <dhoeller@nvidia.com>
…ass.py Co-authored-by: Mayank Mittal <12863862+Mayankm96@users.noreply.github.com> Signed-off-by: David Hoeller <dhoeller@nvidia.com>
Dhoeller19
commented
Oct 14, 2024
source/extensions/omni.isaac.lab/omni/isaac/lab/utils/configclass.py
Outdated
Show resolved
Hide resolved
…ass.py Signed-off-by: David Hoeller <dhoeller@nvidia.com>
Dhoeller19
commented
Oct 14, 2024
source/extensions/omni.isaac.lab/test/utils/test_configclass.py
Outdated
Show resolved
Hide resolved
Signed-off-by: David Hoeller <dhoeller@nvidia.com>
Dhoeller19
requested review from
nikitardn,
pascal-roth and
jtigue-bdai
as code owners
Mayankm96
reviewed
Oct 15, 2024
source/extensions/omni.isaac.lab/omni/isaac/lab/terrains/terrain_importer_cfg.py
Outdated
Show resolved
Hide resolved
…in_importer_cfg.py Co-authored-by: Mayank Mittal <12863862+Mayankm96@users.noreply.github.com> Signed-off-by: David Hoeller <dhoeller@nvidia.com>
Mayankm96
reviewed
Oct 15, 2024
source/extensions/omni.isaac.lab/omni/isaac/lab/terrains/terrain_generator_cfg.py
Outdated
Show resolved
Hide resolved
…nds/velocity_command.py Co-authored-by: Mayank Mittal <12863862+Mayankm96@users.noreply.github.com> Signed-off-by: David Hoeller <dhoeller@nvidia.com>
…nds/velocity_command.py Co-authored-by: Mayank Mittal <12863862+Mayankm96@users.noreply.github.com> Signed-off-by: David Hoeller <dhoeller@nvidia.com>
…dity' into feature/check_configclass_validity
Mayankm96
reviewed
Oct 22, 2024
source/extensions/omni.isaac.lab/omni/isaac/lab/sensors/ray_caster/ray_caster.py
Show resolved
Hide resolved
Mayankm96
reviewed
Oct 22, 2024
Mayankm96
reviewed
Oct 22, 2024
Co-authored-by: Mayank Mittal <12863862+Mayankm96@users.noreply.github.com> Signed-off-by: David Hoeller <dhoeller@nvidia.com>
Mayankm96
approved these changes
Oct 22, 2024
iamdrfly
pushed a commit
to iamdrfly/IsaacLab
that referenced
this pull request
Nov 21, 2024
# Description Added a mechanism to check for the validity of a configclass object. A configclass object is valid if it contains no MISSING attributes. ## Type of change - New feature (non-breaking change which adds functionality) ## Checklist - [x] I have run the [`pre-commit` checks](https://pre-commit.com/) with `./isaaclab.sh --format` - [ ] I have made corresponding changes to the documentation - [x] My changes generate no new warnings - [x] I have added tests that prove my fix is effective or that my feature works - [x] I have updated the changelog and the corresponding version in the extension's `config/extension.toml` file - [x] I have added my name to the `CONTRIBUTORS.md` or my name already exists there
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Added a mechanism to check for the validity of a configclass object.
A configclass object is valid if it contains no MISSING attributes.
Type of change
Checklist
pre-commitchecks with./isaaclab.sh --formatconfig/extension.tomlfileCONTRIBUTORS.mdor my name already exists there