Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adds a validity check for configclasses #1214

Merged
merged 63 commits into from
Oct 23, 2024
Merged

Adds a validity check for configclasses #1214

merged 63 commits into from
Oct 23, 2024

Commits on Oct 11, 2024

  1. Added a validity check for configclasses

    @Dhoeller19
    Dhoeller19 committed Oct 11, 2024
    Configuration menu
    Copy the full SHA
    7ae7e56 View commit details
    Browse the repository at this point in the history

  2. Update docstring

    @Dhoeller19
    Dhoeller19 committed Oct 11, 2024
    Configuration menu
    Copy the full SHA
    2154316 View commit details
    Browse the repository at this point in the history

  3. Added additional test case

    @Dhoeller19
    Dhoeller19 committed Oct 11, 2024
    Configuration menu
    Copy the full SHA
    536d560 View commit details
    Browse the repository at this point in the history

  4. Fix error message object type

    @Dhoeller19
    Dhoeller19 committed Oct 11, 2024
    Configuration menu
    Copy the full SHA
    a3c0664 View commit details
    Browse the repository at this point in the history

Commits on Oct 14, 2024

  1. Update source/extensions/omni.isaac.lab/omni/isaac/lab/utils/configcl… 

    …ass.py

Co-authored-by: Mayank Mittal <12863862+Mayankm96@users.noreply.github.com>
Signed-off-by: David Hoeller <dhoeller@nvidia.com>
    @Dhoeller19 @Mayankm96
    Dhoeller19 and Mayankm96 authored Oct 14, 2024
    Configuration menu
    Copy the full SHA
    02d7a8b View commit details
    Browse the repository at this point in the history

  2. Update source/extensions/omni.isaac.lab/omni/isaac/lab/utils/configcl… 

    …ass.py

Co-authored-by: Mayank Mittal <12863862+Mayankm96@users.noreply.github.com>
Signed-off-by: David Hoeller <dhoeller@nvidia.com>
    @Dhoeller19 @Mayankm96
    Dhoeller19 and Mayankm96 authored Oct 14, 2024
    Configuration menu
    Copy the full SHA
    1a9d4a8 View commit details
    Browse the repository at this point in the history

  3. Update source/extensions/omni.isaac.lab/omni/isaac/lab/utils/configcl… 

    …ass.py

Signed-off-by: David Hoeller <dhoeller@nvidia.com>
    @Dhoeller19
    Dhoeller19 authored Oct 14, 2024
    Configuration menu
    Copy the full SHA
    5c42a9d View commit details
    Browse the repository at this point in the history

  4. Merge branch 'main' into feature/check_configclass_validity

    @Dhoeller19
    Dhoeller19 authored Oct 14, 2024
    Configuration menu
    Copy the full SHA
    3f4f353 View commit details
    Browse the repository at this point in the history

  5. Merge branch 'main' into feature/check_configclass_validity

    @Dhoeller19
    Dhoeller19 authored Oct 14, 2024
    Configuration menu
    Copy the full SHA
    5e5dfff View commit details
    Browse the repository at this point in the history

  6. Fixed issues from validate renaming

    @Dhoeller19
    Dhoeller19 committed Oct 14, 2024
    Configuration menu
    Copy the full SHA
    494f365 View commit details
    Browse the repository at this point in the history

  7. Merge branch 'main' into feature/check_configclass_validity

    @Dhoeller19
    Dhoeller19 authored Oct 14, 2024
    Configuration menu
    Copy the full SHA
    92c4679 View commit details
    Browse the repository at this point in the history

  8. Update source/extensions/omni.isaac.lab/test/utils/test_configclass.py 

    Signed-off-by: David Hoeller <dhoeller@nvidia.com>
    @Dhoeller19
    Dhoeller19 authored Oct 14, 2024
    Configuration menu
    Copy the full SHA
    e539d7c View commit details
    Browse the repository at this point in the history

Commits on Oct 15, 2024

  1. Merge branch 'main' into feature/check_configclass_validity

    @Dhoeller19
    Dhoeller19 authored Oct 15, 2024
    Configuration menu
    Copy the full SHA
    101b263 View commit details
    Browse the repository at this point in the history

  2. Added validity checking throughout the code

    @Dhoeller19
    Dhoeller19 committed Oct 15, 2024
    Configuration menu
    Copy the full SHA
    97676cf View commit details
    Browse the repository at this point in the history

  3. Update source/extensions/omni.isaac.lab/omni/isaac/lab/terrains/terra… 

    …in_importer_cfg.py

Co-authored-by: Mayank Mittal <12863862+Mayankm96@users.noreply.github.com>
Signed-off-by: David Hoeller <dhoeller@nvidia.com>
    @Dhoeller19 @Mayankm96
    Dhoeller19 and Mayankm96 authored Oct 15, 2024
    Configuration menu
    Copy the full SHA
    7c2b45d View commit details
    Browse the repository at this point in the history

  4. Update source/extensions/omni.isaac.lab/omni/isaac/lab/terrains/terra… 

    …in_generator_cfg.py

Co-authored-by: Mayank Mittal <12863862+Mayankm96@users.noreply.github.com>
Signed-off-by: David Hoeller <dhoeller@nvidia.com>
    @Dhoeller19 @Mayankm96
    Dhoeller19 and Mayankm96 authored Oct 15, 2024
    Configuration menu
    Copy the full SHA
    23ae1c9 View commit details
    Browse the repository at this point in the history

  5. Apply suggestions from code review 

    Signed-off-by: Mayank Mittal <12863862+Mayankm96@users.noreply.github.com>
    @Mayankm96
    Mayankm96 authored Oct 15, 2024
    Configuration menu
    Copy the full SHA
    6ab60fe View commit details
    Browse the repository at this point in the history

  6. Formatting

    @Dhoeller19
    Dhoeller19 committed Oct 15, 2024
    Configuration menu
    Copy the full SHA
    9db651a View commit details
    Browse the repository at this point in the history

  7. Merge branch 'feature/check_configclass_validity' of github.com:isaac… 

    …-sim/IsaacLab into feature/check_configclass_validity
    @Dhoeller19
    Dhoeller19 committed Oct 15, 2024
    Configuration menu
    Copy the full SHA
    eb6830c View commit details
    Browse the repository at this point in the history

  8. removes validate from docstrings

    @Mayankm96
    Mayankm96 committed Oct 15, 2024
    Configuration menu
    Copy the full SHA
    2c93c1d View commit details
    Browse the repository at this point in the history

  9. adds version

    @Mayankm96
    Mayankm96 committed Oct 15, 2024
    Configuration menu
    Copy the full SHA
    93a118e View commit details
    Browse the repository at this point in the history

  10. more info

    @Mayankm96
    Mayankm96 committed Oct 15, 2024
    Configuration menu
    Copy the full SHA
    973129f View commit details
    Browse the repository at this point in the history

  11. Merge branch 'main' into feature/check_configclass_validity

    @Mayankm96
    Mayankm96 authored Oct 15, 2024
    Configuration menu
    Copy the full SHA
    e924c70 View commit details
    Browse the repository at this point in the history

Commits on Oct 18, 2024

  1. Merge branch 'main' into feature/check_configclass_validity 

    Signed-off-by: David Hoeller <dhoeller@nvidia.com>
    @Dhoeller19
    Dhoeller19 authored Oct 18, 2024
    Configuration menu
    Copy the full SHA
    8b3851c View commit details
    Browse the repository at this point in the history

  2. Update extension.toml 

    Signed-off-by: David Hoeller <dhoeller@nvidia.com>
    @Dhoeller19
    Dhoeller19 authored Oct 18, 2024
    Configuration menu
    Copy the full SHA
    ef4b072 View commit details
    Browse the repository at this point in the history

  3. Update test_multi_agent_environments.py 

    Signed-off-by: David Hoeller <dhoeller@nvidia.com>
    @Dhoeller19
    Dhoeller19 authored Oct 18, 2024
    Configuration menu
    Copy the full SHA
    113a004 View commit details
    Browse the repository at this point in the history

  4. Merge branch 'main' into feature/check_configclass_validity 

    Signed-off-by: David Hoeller <dhoeller@nvidia.com>
    @Dhoeller19
    Dhoeller19 authored Oct 18, 2024
    Configuration menu
    Copy the full SHA
    ee04eca View commit details
    Browse the repository at this point in the history

  5. Fixed interactive scene test

    @Dhoeller19
    Dhoeller19 committed Oct 18, 2024
    Configuration menu
    Copy the full SHA
    a8c7c2f View commit details
    Browse the repository at this point in the history

  6. Merge branch 'main' into feature/check_configclass_validity

    @Dhoeller19
    Dhoeller19 committed Oct 18, 2024
    Configuration menu
    Copy the full SHA
    a7a6274 View commit details
    Browse the repository at this point in the history

  7. Fixed direct marl env test

    @Dhoeller19
    Dhoeller19 committed Oct 18, 2024
    Configuration menu
    Copy the full SHA
    346dabe View commit details
    Browse the repository at this point in the history

Commits on Oct 21, 2024

  1. Fixes the unit tests

    @Dhoeller19
    Dhoeller19 committed Oct 21, 2024
    Configuration menu
    Copy the full SHA
    8440459 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'feature/check_configclass_validity' of github.com:isaac… 

    …-sim/IsaacLab into feature/check_configclass_validity
    @Dhoeller19
    Dhoeller19 committed Oct 21, 2024
    Configuration menu
    Copy the full SHA
    4773ec5 View commit details
    Browse the repository at this point in the history

  3. Update commands config

    @Dhoeller19
    Dhoeller19 committed Oct 21, 2024
    Configuration menu
    Copy the full SHA
    d0ad808 View commit details
    Browse the repository at this point in the history

  4. Added warning in velocity command

    @Dhoeller19
    Dhoeller19 committed Oct 21, 2024
    Configuration menu
    Copy the full SHA
    597d821 View commit details
    Browse the repository at this point in the history

  5. Added concurrency group to docs building actions

    @Dhoeller19
    Dhoeller19 committed Oct 21, 2024
    Configuration menu
    Copy the full SHA
    9015045 View commit details
    Browse the repository at this point in the history

  6. Fix concurrent workflow run of docs building

    @Dhoeller19
    Dhoeller19 committed Oct 21, 2024
    Configuration menu
    Copy the full SHA
    cee4cb1 View commit details
    Browse the repository at this point in the history

  7. Remove on pull_request in doc building action

    @Dhoeller19
    Dhoeller19 committed Oct 21, 2024
    Configuration menu
    Copy the full SHA
    e2df131 View commit details
    Browse the repository at this point in the history

  8. Fixes raycast camera

    @Dhoeller19
    Dhoeller19 committed Oct 21, 2024
    Configuration menu
    Copy the full SHA
    1627b29 View commit details
    Browse the repository at this point in the history

  9. Removed the NullCommand term.

    @Dhoeller19
    Dhoeller19 committed Oct 21, 2024
    Configuration menu
    Copy the full SHA
    e9876c0 View commit details
    Browse the repository at this point in the history

  10. Update source/extensions/omni.isaac.lab/omni/isaac/lab/envs/mdp/comma… 

    …nds/velocity_command.py

Co-authored-by: Mayank Mittal <12863862+Mayankm96@users.noreply.github.com>
Signed-off-by: David Hoeller <dhoeller@nvidia.com>
    @Dhoeller19 @Mayankm96
    Dhoeller19 and Mayankm96 authored Oct 21, 2024
    Configuration menu
    Copy the full SHA
    6d9e781 View commit details
    Browse the repository at this point in the history

  11. Update source/extensions/omni.isaac.lab/omni/isaac/lab/envs/mdp/comma… 

    …nds/velocity_command.py

Co-authored-by: Mayank Mittal <12863862+Mayankm96@users.noreply.github.com>
Signed-off-by: David Hoeller <dhoeller@nvidia.com>
    @Dhoeller19 @Mayankm96
    Dhoeller19 and Mayankm96 authored Oct 21, 2024
    Configuration menu
    Copy the full SHA
    415ce47 View commit details
    Browse the repository at this point in the history

  12. Update source/extensions/omni.isaac.lab/omni/isaac/lab/envs/mdp/comma… 

    …nds/velocity_command.py

Co-authored-by: Mayank Mittal <12863862+Mayankm96@users.noreply.github.com>
Signed-off-by: David Hoeller <dhoeller@nvidia.com>
    @Dhoeller19 @Mayankm96
    Dhoeller19 and Mayankm96 authored Oct 21, 2024
    Configuration menu
    Copy the full SHA
    f6e4c36 View commit details
    Browse the repository at this point in the history

  13. Fix comments

    @Dhoeller19
    Dhoeller19 committed Oct 21, 2024
    Configuration menu
    Copy the full SHA
    25a3270 View commit details
    Browse the repository at this point in the history

  14. Merge remote-tracking branch 'external/feature/check_configclass_vali… 

    …dity' into feature/check_configclass_validity
    @Dhoeller19
    Dhoeller19 committed Oct 21, 2024
    Configuration menu
    Copy the full SHA
    e928e37 View commit details
    Browse the repository at this point in the history

  15. Formatting

    @Dhoeller19
    Dhoeller19 committed Oct 21, 2024
    Configuration menu
    Copy the full SHA
    272c534 View commit details
    Browse the repository at this point in the history

  16. Added back null command term test

    @Dhoeller19
    Dhoeller19 committed Oct 21, 2024
    Configuration menu
    Copy the full SHA
    f5da83c View commit details
    Browse the repository at this point in the history

  17. Fix license header

    @Dhoeller19
    Dhoeller19 committed Oct 21, 2024
    Configuration menu
    Copy the full SHA
    36f3a72 View commit details
    Browse the repository at this point in the history

  18. Formatting

    @Dhoeller19
    Dhoeller19 committed Oct 21, 2024
    Configuration menu
    Copy the full SHA
    e138495 View commit details
    Browse the repository at this point in the history

Commits on Oct 22, 2024

  1. fixes docstring highlighting

    @Mayankm96
    Mayankm96 committed Oct 22, 2024
    Configuration menu
    Copy the full SHA
    9252903 View commit details
    Browse the repository at this point in the history

  2. removes curriculum pass through where not needed

    @Mayankm96
    Mayankm96 committed Oct 22, 2024
    Configuration menu
    Copy the full SHA
    5bb19d3 View commit details
    Browse the repository at this point in the history

  3. runs formatter

    @Mayankm96
    Mayankm96 committed Oct 22, 2024
    Configuration menu
    Copy the full SHA
    4996a34 View commit details
    Browse the repository at this point in the history

  4. fixes versioning

    @Mayankm96
    Mayankm96 committed Oct 22, 2024
    Configuration menu
    Copy the full SHA
    c06c039 View commit details
    Browse the repository at this point in the history

  5. fixes minor typos

    @Mayankm96
    Mayankm96 committed Oct 22, 2024
    Configuration menu
    Copy the full SHA
    6c69c3a View commit details
    Browse the repository at this point in the history

  6. moves check up

    @Mayankm96
    Mayankm96 committed Oct 22, 2024
    Configuration menu
    Copy the full SHA
    010bd51 View commit details
    Browse the repository at this point in the history

  7. adds test to make sure event and reward manager work with None configs

    @Mayankm96
    Mayankm96 committed Oct 22, 2024
    Configuration menu
    Copy the full SHA
    5878c0a View commit details
    Browse the repository at this point in the history

  8. adds none check for action and obs manager as it is mandatory there

    @Mayankm96
    Mayankm96 committed Oct 22, 2024
    Configuration menu
    Copy the full SHA
    9c8c0ef View commit details
    Browse the repository at this point in the history

  9. docs fixes

    @Mayankm96
    Mayankm96 committed Oct 22, 2024
    Configuration menu
    Copy the full SHA
    108e637 View commit details
    Browse the repository at this point in the history

  10. Update source/extensions/omni.isaac.lab/docs/CHANGELOG.rst 

    Co-authored-by: Mayank Mittal <12863862+Mayankm96@users.noreply.github.com>
Signed-off-by: David Hoeller <dhoeller@nvidia.com>
    @Dhoeller19 @Mayankm96
    Dhoeller19 and Mayankm96 authored Oct 22, 2024
    Configuration menu
    Copy the full SHA
    51d8114 View commit details
    Browse the repository at this point in the history

  11. Merge branch 'main' into feature/check_configclass_validity

    @Dhoeller19
    Dhoeller19 authored Oct 22, 2024
    Configuration menu
    Copy the full SHA
    8856085 View commit details
    Browse the repository at this point in the history

  12. Merge branch 'main' into feature/check_configclass_validity

    @Dhoeller19
    Dhoeller19 authored Oct 22, 2024
    Configuration menu
    Copy the full SHA
    ccf36c0 View commit details
    Browse the repository at this point in the history

  13. Merge branch 'main' into feature/check_configclass_validity

    @Mayankm96
    Mayankm96 committed Oct 22, 2024
    Configuration menu
    Copy the full SHA
    332997c View commit details
    Browse the repository at this point in the history

  14. Fix tests

    @Dhoeller19
    Dhoeller19 committed Oct 22, 2024
    Configuration menu
    Copy the full SHA
    5d847bd View commit details
    Browse the repository at this point in the history

  15. Remove hardcode in test_environments

    @Dhoeller19
    Dhoeller19 committed Oct 22, 2024
    Configuration menu
    Copy the full SHA
    134af78 View commit details
    Browse the repository at this point in the history