Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Expose 'is_global' flag when calling write_da… #1223

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

Maexerich
Copy link

@Maexerich Maexerich commented Oct 11, 2024

…ta_to_sim(). That way forces & torques in global coordinates can be applied without any issues.

Description

The flag 'is_global' in the function: self.root_physx_view.apply_forces_and_torques_at_position() is set to False.

If I want to apply forces and torques which are in the global coordinate system, then I need to change this flag to True.

I suggest to expose this flag to the function call: articulation.write_data_to_sim(is_global=False)

Fixes # (issue)

I am not familiar in software deployment and am not sure, if the fix is as simple as just adding the argument to the signature of the function. This is what I would recommend, but I want to leave it to those who know what they are doing.

Type of change

  • New feature (non-breaking change which adds functionality)
  • This change requires a documentation update

Checklist

  • I have run the pre-commit checks with ./isaaclab.sh --format
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • I have updated the changelog and the corresponding version in the extension's config/extension.toml file
  • I have added my name to the CONTRIBUTORS.md or my name already exists there

…ta_to_sim(). That way forces & torques in global coordinates can be applied without any issues.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant