Fix: Expose 'is_global' flag when calling write_da… #1223
+2
−2
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…ta_to_sim(). That way forces & torques in global coordinates can be applied without any issues.
Description
The flag 'is_global' in the function: self.root_physx_view.apply_forces_and_torques_at_position() is set to False.
If I want to apply forces and torques which are in the global coordinate system, then I need to change this flag to True.
I suggest to expose this flag to the function call: articulation.write_data_to_sim(is_global=False)
Fixes # (issue)
I am not familiar in software deployment and am not sure, if the fix is as simple as just adding the argument to the signature of the function. This is what I would recommend, but I want to leave it to those who know what they are doing.
Type of change
Checklist
pre-commit
checks with./isaaclab.sh --format
config/extension.toml
fileCONTRIBUTORS.md
or my name already exists there