Updates documentation on Isaac Lab installation path for Windows #1271
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
louislelay
requested review from
jsmith-bdai,
Dhoeller19,
kellyguo11 and
Mayankm96
as code owners
Signed-off-by: David Hoeller <dhoeller@nvidia.com>
Dhoeller19
reviewed
Oct 24, 2024
Signed-off-by: David Hoeller <dhoeller@nvidia.com>
Dhoeller19
changed the title
iamdrfly
pushed a commit
to iamdrfly/IsaacLab
that referenced
this pull request
Nov 21, 2024
…ac-sim#1271) # Description This update addresses a minor inconsistency found in the Isaac Lab installation documentation for Windows. While following the installation instructions on Isaac Lab for "Option 2: Installation using Isaac Sim binaries" on Windows, I encountered the following lines: > `C:\Users\%USERPROFILE%\AppData\Local\ov\pkg\isaac_sim-*`, with `*` corresponding to the Isaac Sim version. > `set ISAACSIM_PATH="C:\Users\%USERPROFILE%\AppData\Local\ov\pkg\isaac-sim-4.2.0"` This seemed redundant, as `%USERPROFILE%` already refers to the path `C:\Users\name_of_user`. I have compiled and verified the documentation changes to ensure proper display. Additionally, I tested this update on a Windows system, confirming that it works as intended. ## Type of change - This change requires a documentation update ## Checklist - [x] I have run the [`pre-commit` checks](https://pre-commit.com/) with `./isaaclab.sh --format` - [x] I have made corresponding changes to the documentation - [x] My changes generate no new warnings - [x] I have added tests that prove my fix is effective or that my feature works - [x] I have updated the changelog and the corresponding version in the extension's `config/extension.toml` file - [x] I have added my name to the `CONTRIBUTORS.md` or my name already exists there
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This update addresses a minor inconsistency found in the Isaac Lab installation documentation for Windows.
While following the installation instructions on Isaac Lab for "Option 2: Installation using Isaac Sim binaries" on Windows, I encountered the following lines:
This seemed redundant, as
%USERPROFILE%already refers to the pathC:\Users\name_of_user.I have compiled and verified the documentation changes to ensure proper display. Additionally, I tested this update on a Windows system, confirming that it works as intended.
Type of change
Checklist
pre-commitchecks with./isaaclab.sh --formatconfig/extension.tomlfileCONTRIBUTORS.mdor my name already exists there