-
Notifications
You must be signed in to change notification settings - Fork 932
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replaces hardcoded module paths with __name__
dunder
#1357
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mayankm96
requested review from
Dhoeller19,
jsmith-bdai,
jtigue-bdai and
kellyguo11
as code owners
November 1, 2024 13:22
Mayankm96
requested review from
Toni-SM
and removed request for
kellyguo11,
Dhoeller19,
jsmith-bdai and
jtigue-bdai
November 1, 2024 13:22
Dhoeller19
approved these changes
Nov 1, 2024
Dhoeller19
requested changes
Nov 1, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
pre-commit not working
Dhoeller19
approved these changes
Nov 4, 2024
Toni-SM
approved these changes
Nov 4, 2024
kemjensak
added a commit
to IROL-SSU/IsaacLab
that referenced
this pull request
Nov 11, 2024
iamdrfly
pushed a commit
to iamdrfly/IsaacLab
that referenced
this pull request
Nov 21, 2024
# Description A minor change to automate where the config directory is located. ## Motivation If user wants to copy these files to their own project, they shouldn't have to change the paths in the registry.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
A minor change to automate where the config directory is located.
Motivation
If user wants to copy these files to their own project, they shouldn't have to change the paths in the registry.