Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds a cli arg to run_all_tests.py for testing a selected extension #753

Merged
merged 4 commits into from
Aug 2, 2024

Conversation

jsmith-bdai
Copy link
Collaborator

@jsmith-bdai jsmith-bdai commented Jul 29, 2024

Description

Add a cli argument --extension to run only unit tests for a selected extension. As an example:

isaaclab -t --extension omni.isaac.lab_assets # Only runs tests under omni.isaac.lab_assets

Fixes #752

Type of change

  • New feature (non-breaking change which adds functionality)

Checklist

  • I have run the pre-commit checks with ./isaaclab.sh --format
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • I have updated the changelog and the corresponding version in the extension's config/extension.toml file
  • I have added my name to the CONTRIBUTORS.md or my name already exists there

@jsmith-bdai jsmith-bdai self-assigned this Jul 29, 2024
@Mayankm96 Mayankm96 changed the title Add a cli arg to run_all_tests.py to run only tests for a selected extension Adds a cli arg to run_all_tests.py for testing a selected extension Jul 30, 2024
tools/run_all_tests.py Outdated Show resolved Hide resolved
@Mayankm96 Mayankm96 added the enhancement New feature or request label Aug 2, 2024
Copy link
Collaborator

@hhansen-bdai hhansen-bdai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! LGTM!

@jsmith-bdai jsmith-bdai merged commit e90400b into main Aug 2, 2024
2 of 3 checks passed
@jsmith-bdai jsmith-bdai deleted the feature/add_per_extension_testability branch August 2, 2024 14:15
iamdrfly pushed a commit to iamdrfly/IsaacLab that referenced this pull request Nov 21, 2024
…isaac-sim#753)

# Description

Add a cli argument `--extension` to run only unit tests for a selected
extension. As an example:

```bash
isaaclab -t --extension omni.isaac.lab_assets # Only runs tests under omni.isaac.lab_assets
```

Fixes isaac-sim#752 

## Type of change

- New feature (non-breaking change which adds functionality)

## Checklist

- [x] I have run the [`pre-commit` checks](https://pre-commit.com/) with
`./isaaclab.sh --format`
- [x] I have made corresponding changes to the documentation
- [x] My changes generate no new warnings
- [ ] I have added tests that prove my fix is effective or that my
feature works
- [ ] I have updated the changelog and the corresponding version in the
extension's `config/extension.toml` file
- [x] I have added my name to the `CONTRIBUTORS.md` or my name already
exists there
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Proposal] Add ability to run tests per extension
4 participants