Create Manager Based Cartpole Vision Example Environments #995
+267
−8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
glvov-bdai
requested review from
jsmith-bdai,
Dhoeller19,
kellyguo11,
Mayankm96,
pascal-roth and
jtigue-bdai
as code owners
glvov-bdai
changed the title
|
Will review this soon! Can you update the base branch to be the one from #976 so only new changes are reviewed here 🙏. Can help out with this if it doesn't make sense |
glvov-bdai
force-pushed
the
feature/manager_based_vision_cartpole_envs
branch
from
390ee66
to
5ae458c
Compare
Merged
6 tasks
glvov-bdai
force-pushed
the
feature/manager_based_vision_cartpole_envs
branch
from
5ae458c
to
c1c7972
Compare
garylvov
force-pushed
the
feature/manager_based_vision_cartpole_envs
branch
from
541c029
to
549e44a
Compare
garylvov
force-pushed
the
feature/manager_based_vision_cartpole_envs
branch
from
549e44a
to
a35a979
Compare
Signed-off-by: garylvov <67614381+garylvov@users.noreply.github.com>
jsmith-bdai
approved these changes
Sep 23, 2024
source/extensions/omni.isaac.lab/omni/isaac/lab/envs/mdp/observations.py
Outdated
Show resolved
Hide resolved
source/extensions/omni.isaac.lab/omni/isaac/lab/envs/mdp/observations.py
Show resolved
Hide resolved
...aac.lab_tasks/omni/isaac/lab_tasks/manager_based/classic/cartpole/cartpole_camera_env_cfg.py
Outdated
Show resolved
Hide resolved
…vations.py Co-authored-by: James Smith <142246516+jsmith-bdai@users.noreply.github.com> Signed-off-by: glvov-bdai <glvov@theaiinstitute.com>
glvov-bdai
force-pushed
the
feature/manager_based_vision_cartpole_envs
branch
from
98dc71c
to
83bd480
Compare
Signed-off-by: glvov-bdai <glvov@theaiinstitute.com>
Dhoeller19
reviewed
Sep 25, 2024
Dhoeller19
reviewed
Sep 25, 2024
source/extensions/omni.isaac.lab/omni/isaac/lab/envs/mdp/observations.py
Outdated
Show resolved
Hide resolved
Signed-off-by: glvov-bdai <glvov@theaiinstitute.com>
Signed-off-by: glvov-bdai <glvov@theaiinstitute.com>
|
@jsmith-bdai ready to merge |
jsmith-bdai
reviewed
Sep 25, 2024
Co-authored-by: James Smith <142246516+jsmith-bdai@users.noreply.github.com> Signed-off-by: glvov-bdai <glvov@theaiinstitute.com>
iamdrfly
pushed a commit
to iamdrfly/IsaacLab
that referenced
this pull request
Nov 21, 2024
) # Description Adds manager based cartpole vision example environments. Also uses the`convert_perspective_depth_to_orthogonal_depth ` functionality introduced in isaac-sim#976 , contains a duplicate copy of the method and test for completeness of the PR. Will be synced with main to remove this duplicate copy once isaac-sim#976 is merged into main, or isaac-sim#976 will be synced with main if this PR is merged first ## Type of change - New feature (non-breaking change which adds functionality) - This change requires a documentation update ## Screenshots  ## Checklist - [x] I have run the [`pre-commit` checks](https://pre-commit.com/) with `./isaaclab.sh --format` - [x] I have made corresponding changes to the documentation - [x] My changes generate no new warnings - [x] I have added tests that prove my fix is effective or that my feature works - [x] I have updated the changelog and the corresponding version in the extension's `config/extension.toml` file - [x] I have added my name to the `CONTRIBUTORS.md` or my name already exists there ## Testing Training converged in both RGB and Depth at similar rates to the direct environments --------- Signed-off-by: garylvov <67614381+garylvov@users.noreply.github.com> Signed-off-by: glvov-bdai <glvov@theaiinstitute.com> Co-authored-by: garylvov <gary.lvov@gmail.com> Co-authored-by: garylvov <67614381+garylvov@users.noreply.github.com> Co-authored-by: James Smith <142246516+jsmith-bdai@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds manager based cartpole vision example environments.
Also uses the
convert_perspective_depth_to_orthogonal_depthfunctionality introduced in #976 , contains a duplicate copy of the method and test for completeness of the PR. Will be synced with main to remove this duplicate copy once #976 is merged into main, or #976 will be synced with main if this PR is merged firstType of change
Screenshots
Checklist
pre-commitchecks with./isaaclab.sh --formatconfig/extension.tomlfileCONTRIBUTORS.mdor my name already exists thereTesting
Training converged in both RGB and Depth at similar rates to the direct environments