Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(j-s): Digital mailbox API #16301

Merged
merged 13 commits into from
Oct 7, 2024
Merged

fix(j-s): Digital mailbox API #16301

merged 13 commits into from
Oct 7, 2024

Conversation

unakb
Copy link
Member

@unakb unakb commented Oct 7, 2024

What

Fix digital mailbox API after db changes and added 2 new values to return object

Why

Because it's not returning correct information and we need more concrete info about defender choices

Checklist:

  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • Formatting passes locally with my changes
  • I have rebased against main before asking for a review

Summary by CodeRabbit

  • New Features

    • Enhanced error handling and logging in subpoena delivery processes.
    • Added new properties for tracking defender choices in subpoenas.
    • Introduced a new method to assess the success of service statuses.
  • Bug Fixes

    • Improved checks for affected rows during updates to subpoenas and defendants.
  • Documentation

    • Updated logic for determining service status in case responses.
  • Chores

    • Added new exports related to service status checks.

Copy link
Contributor

coderabbitai bot commented Oct 7, 2024

Walkthrough

The changes in this pull request primarily enhance the error handling and logging capabilities within the SubpoenaService class, specifically in the setHash, update, and deliverSubpoenaToPolice methods. Additionally, modifications are made to the CaseResponse, InternalCaseResponse, and SubpoenaResponse classes to improve how service statuses and defender choices are handled. New exports related to service status checks are introduced in the types library, further refining the overall functionality of the judicial system's components.

Changes

File Change Summary
apps/judicial-system/backend/src/app/modules/subpoena/subpoena.service.ts Enhanced error handling and logging in setHash, update, and deliverSubpoenaToPolice methods. Added checks for affected rows and improved exception handling.
apps/judicial-system/digital-mailbox-api/src/app/modules/cases/models/case.response.ts Updated fromInternalCaseResponse method to use isSuccessfulServiceStatus for determining hasBeenServed. Added import statement for isSuccessfulServiceStatus.
apps/judicial-system/digital-mailbox-api/src/app/modules/cases/models/internal/internalCase.response.ts Replaced acknowledged boolean with optional serviceStatus property in Subpoena interface. Added import for ServiceStatus.
apps/judicial-system/digital-mailbox-api/src/app/modules/cases/models/subpoena.response.ts Added hasChosenDefender and defaultDefenderChoice properties to SubpoenaData. Updated fromInternalCaseResponse to use isSuccessfulServiceStatus.
libs/judicial-system/types/src/index.ts Added new export isSuccessfulServiceStatus from ./lib/defendant.
libs/judicial-system/types/src/lib/defendant.ts Introduced successfulServiceStatus array and isSuccessfulServiceStatus function to check service status validity.

Possibly related PRs

Suggested reviewers

  • unakb

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@unakb unakb marked this pull request as ready for review October 7, 2024 15:23
@unakb unakb requested a review from a team as a code owner October 7, 2024 15:23
coderabbitai[bot]
coderabbitai bot previously requested changes Oct 7, 2024
Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 3

🧹 Outside diff range and nitpick comments (5)
apps/judicial-system/digital-mailbox-api/src/app/modules/cases/models/internal/internalCase.response.ts (1)

Line range hint 1-47: Consider broader impact and next steps.

The changes to the Subpoena interface improve type safety and provide more detailed information about subpoena status, aligning with the PR objectives. However, consider the following next steps:

  1. Update any components or API routes that use the Subpoena interface to handle the new serviceStatus property.
  2. Ensure that the ServiceStatus enum is properly defined in the @island.is/judicial-system/types module.
  3. Update relevant documentation to reflect these changes.
  4. Consider adding unit tests to verify the correct usage of the new serviceStatus property.

These steps will ensure that the changes are fully integrated into the NextJS application and maintain overall code quality.

Would you like assistance in identifying the components or API routes that might need updates based on these changes?

libs/judicial-system/types/src/lib/defendant.ts (2)

45-47: Approved with suggestion: Type-safe check for successful service status

The isSuccessfulServiceStatus function is a valuable addition, providing a reusable way to check if a service status is successful. It's well-typed and concise, adhering to the coding guidelines for the libs directory.

However, to improve type safety, consider updating the successfulServiceStatus constant to use ServiceStatus[] instead of string[]. This change would ensure that only valid ServiceStatus values can be included in the array.

Here's the suggested change:

-export const successfulServiceStatus: string[] = [
+export const successfulServiceStatus: ServiceStatus[] = [
   ServiceStatus.ELECTRONICALLY,
   ServiceStatus.DEFENDER,
   ServiceStatus.IN_PERSON,
 ]

This modification will make the isSuccessfulServiceStatus function more robust and prevent potential errors from invalid status strings.


38-47: Summary: Valuable additions for handling service statuses

The new exports, successfulServiceStatus and isSuccessfulServiceStatus, are valuable additions to the defendant.ts file. They provide a clear, reusable way to define and check successful service statuses, which aligns well with the PR objectives of including more detailed information regarding defender choices and API responses.

These additions adhere to the coding guidelines for the libs directory, ensuring reusability across different NextJS apps and proper TypeScript usage. They will likely improve the consistency and reliability of service status checks throughout the judicial system components.

Consider documenting these new exports in the relevant API documentation to ensure other developers are aware of their availability and proper usage.

libs/judicial-system/types/src/index.ts (1)

Line range hint 1-11: LGTM! Consider adding JSDoc comment for the new export.

The addition of isSuccessfulServiceStatus is consistent with the existing exports and adheres to the coding guidelines for the libs directory. It enhances the module's functionality without breaking existing exports.

To improve documentation, consider adding a JSDoc comment for the new export in the ./lib/defendant file. For example:

/**
 * Checks if the given service status is considered successful.
 * @param status The service status to check
 * @returns True if the status is successful, false otherwise
 */
export function isSuccessfulServiceStatus(status: ServiceStatus): boolean;

This will provide better context for developers using this function across different NextJS apps.

apps/judicial-system/digital-mailbox-api/src/app/modules/cases/models/case.response.ts (1)

47-50: Improved logic for determining hasBeenServed

The update to use isSuccessfulServiceStatus enhances the accuracy of determining if a case has been served. This change aligns well with NextJS best practices by improving data transformation logic.

For better readability, consider using optional chaining:

hasBeenServed: isSuccessfulServiceStatus(subpoenas[0]?.serviceStatus) ?? false,

This would eliminate the need for the length check and make the code more concise.

📜 Review details

Configuration used: .coderabbit.yaml
Review profile: CHILL

📥 Commits

Files that changed from the base of the PR and between c7ad42c and 135ccee.

📒 Files selected for processing (6)
  • apps/judicial-system/backend/src/app/modules/subpoena/subpoena.service.ts (0 hunks)
  • apps/judicial-system/digital-mailbox-api/src/app/modules/cases/models/case.response.ts (2 hunks)
  • apps/judicial-system/digital-mailbox-api/src/app/modules/cases/models/internal/internalCase.response.ts (2 hunks)
  • apps/judicial-system/digital-mailbox-api/src/app/modules/cases/models/subpoena.response.ts (4 hunks)
  • libs/judicial-system/types/src/index.ts (1 hunks)
  • libs/judicial-system/types/src/lib/defendant.ts (1 hunks)
💤 Files with no reviewable changes (1)
  • apps/judicial-system/backend/src/app/modules/subpoena/subpoena.service.ts
🧰 Additional context used
📓 Path-based instructions (5)
apps/judicial-system/digital-mailbox-api/src/app/modules/cases/models/case.response.ts (1)

Pattern apps/**/*: "Confirm that the code adheres to the following:

  • NextJS best practices, including file structure, API routes, and static generation methods.
  • Efficient state management and server-side rendering techniques.
  • Optimal use of TypeScript for component and utility type safety."
apps/judicial-system/digital-mailbox-api/src/app/modules/cases/models/internal/internalCase.response.ts (1)

Pattern apps/**/*: "Confirm that the code adheres to the following:

  • NextJS best practices, including file structure, API routes, and static generation methods.
  • Efficient state management and server-side rendering techniques.
  • Optimal use of TypeScript for component and utility type safety."
apps/judicial-system/digital-mailbox-api/src/app/modules/cases/models/subpoena.response.ts (1)

Pattern apps/**/*: "Confirm that the code adheres to the following:

  • NextJS best practices, including file structure, API routes, and static generation methods.
  • Efficient state management and server-side rendering techniques.
  • Optimal use of TypeScript for component and utility type safety."
libs/judicial-system/types/src/index.ts (1)

Pattern libs/**/*: "Confirm that the code adheres to the following:

  • Reusability of components and hooks across different NextJS apps.
  • TypeScript usage for defining props and exporting types.
  • Effective tree-shaking and bundling practices."
libs/judicial-system/types/src/lib/defendant.ts (1)

Pattern libs/**/*: "Confirm that the code adheres to the following:

  • Reusability of components and hooks across different NextJS apps.
  • TypeScript usage for defining props and exporting types.
  • Effective tree-shaking and bundling practices."
🪛 Biome
apps/judicial-system/digital-mailbox-api/src/app/modules/cases/models/subpoena.response.ts

[error] 122-125: Unnecessary use of boolean literals in conditional expression.

Simplify your code by directly assigning the result without using a ternary operator.
If your goal is negation, you may use the logical NOT (!) or double NOT (!!) operator for clearer and concise code.
Check for more details about NOT operator.
Unsafe fix: Remove the conditional expression with

(lint/complexity/noUselessTernary)

🔇 Additional comments (5)
apps/judicial-system/digital-mailbox-api/src/app/modules/cases/models/internal/internalCase.response.ts (2)

Line range hint 1-7: LGTM: Import statement updated correctly.

The addition of ServiceStatus to the import statement is consistent with its usage in the Subpoena interface and follows TypeScript best practices.


Line range hint 42-47: Approve change with verification suggestion.

The replacement of acknowledged: boolean with serviceStatus?: ServiceStatus provides a more detailed representation of the subpoena's status, aligning with the PR objectives. However, as serviceStatus is optional, it's important to ensure proper handling in the code that uses this interface.

To verify the proper usage of the new serviceStatus property, please run the following script:

This will help identify areas where the Subpoena interface or serviceStatus property is used, allowing you to verify that the optional nature of serviceStatus is properly handled.

libs/judicial-system/types/src/lib/defendant.ts (1)

39-43: LGTM: Well-defined constant for successful service statuses

The successfulServiceStatus constant is a good addition. It provides a clear, reusable definition of what constitutes a successful service status, which can be easily used across different parts of the application. The use of TypeScript for explicit typing (string[]) is appropriate and aligns with the coding guidelines for the libs directory.

apps/judicial-system/digital-mailbox-api/src/app/modules/cases/models/case.response.ts (1)

4-7: LGTM: Import changes are well-structured

The addition of isSuccessfulServiceStatus import is properly grouped with related imports from the same module. This follows good TypeScript practices and improves code organization.

apps/judicial-system/digital-mailbox-api/src/app/modules/cases/models/subpoena.response.ts (1)

9-13: Approved: Importing isSuccessfulServiceStatus

The addition of isSuccessfulServiceStatus import is appropriate and necessary for the functionality implemented.

@unakb unakb added the automerge Merge this PR as soon as all checks pass label Oct 7, 2024
@unakb unakb dismissed coderabbitai[bot]’s stale review October 7, 2024 15:37

To get changes through. Ive already resolved all comments but git doesnt seem to recognize it.

Copy link

codecov bot commented Oct 7, 2024

Codecov Report

Attention: Patch coverage is 75.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 36.84%. Comparing base (ef8b3ef) to head (f7af244).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
libs/judicial-system/types/src/lib/defendant.ts 66.66% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main   #16301      +/-   ##
==========================================
- Coverage   36.86%   36.84%   -0.02%     
==========================================
  Files        6798     6796       -2     
  Lines      140495   140394     -101     
  Branches    39945    39917      -28     
==========================================
- Hits        51792    51729      -63     
+ Misses      88703    88665      -38     
Flag Coverage Δ
judicial-system-api 18.29% <75.00%> (+0.06%) ⬆️
judicial-system-backend 55.19% <75.00%> (+<0.01%) ⬆️
judicial-system-formatters 79.90% <75.00%> (-0.03%) ⬇️
judicial-system-message 67.18% <ø> (ø)
judicial-system-message-handler 48.26% <ø> (ø)
judicial-system-scheduler 69.41% <75.00%> (+0.01%) ⬆️
judicial-system-types 47.44% <0.00%> (-0.33%) ⬇️
judicial-system-web 27.96% <66.66%> (+<0.01%) ⬆️
testing-e2e ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...ckend/src/app/modules/subpoena/subpoena.service.ts 32.75% <ø> (ø)
libs/judicial-system/types/src/index.ts 100.00% <100.00%> (ø)
libs/judicial-system/types/src/lib/defendant.ts 96.55% <66.66%> (-3.45%) ⬇️

... and 17 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ef8b3ef...f7af244. Read the comment docs.

@datadog-island-is
Copy link

Datadog Report

All test runs 630b8bc 🔗

73 Total Test Services: 0 Failed, 71 Passed
🔻 Test Sessions change in coverage: 5 decreased, 2 increased, 193 no change

Test Services
This report shows up to 10 services
Service Name Failed Known Flaky New Flaky Passed Skipped Total Time Code Coverage Change Test Service View
air-discount-scheme-backend 0 0 0 81 0 30.36s N/A Link
air-discount-scheme-web 0 0 0 2 0 7.74s N/A Link
api 0 0 0 4 0 2.63s N/A Link
api-domains-air-discount-scheme 0 0 0 6 0 17.78s N/A Link
api-domains-assets 0 0 0 3 0 11.39s N/A Link
api-domains-auth-admin 0 0 0 18 0 14.51s N/A Link
api-domains-communications 0 0 0 5 0 32.07s N/A Link
api-domains-criminal-record 0 0 0 5 0 10.26s 1 no change Link
api-domains-driving-license 0 0 0 23 0 29.98s N/A Link
api-domains-education 0 0 0 8 0 20.81s 1 no change Link

🔻 Code Coverage Decreases vs Default Branch (5)

  • judicial-system-types - jest 51.11% (-0.38%) - Details
  • judicial-system-formatters - jest 88.11% (-0.07%) - Details
  • services-university-gateway - jest 44.88% (-0.03%) - Details
  • services-auth-personal-representative-public - jest 40.75% (-0.02%) - Details
  • application-template-api-modules - jest 26.02% (-0.01%) - Details

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

🧹 Outside diff range and nitpick comments (2)
apps/judicial-system/digital-mailbox-api/src/app/modules/cases/models/subpoena.response.ts (2)

66-71: LGTM: New properties align with PR objectives.

The added properties hasChosenDefender and defaultDefenderChoice in the SubpoenaData class provide the necessary information about defender choices as per the PR objectives. The use of appropriate types and @ApiProperty decorators is commendable.

For consistency, consider adding a description to the @ApiProperty decorators:

@ApiProperty({ type: Boolean, description: 'Indicates if a defender has been chosen' })
hasChosenDefender?: boolean

@ApiProperty({ enum: DefenderChoice, description: 'Default choice for the defender' })
defaultDefenderChoice?: DefenderChoice

This will enhance the API documentation.


123-127: Simplify hasChosenDefender logic and LGTM for defaultDefenderChoice.

The addition of hasChosenDefender and defaultDefenderChoice to the returned object aligns well with the PR objectives. However, the hasChosenDefender logic can be simplified:

hasChosenDefender: defendantInfo?.defenderChoice !== undefined && 
                   defendantInfo.defenderChoice !== DefenderChoice.DELAY,

This eliminates the need for the Boolean constructor and makes the logic more straightforward.

The defaultDefenderChoice: DefenderChoice.DELAY is correct and aligns with the PR objectives.

📜 Review details

Configuration used: .coderabbit.yaml
Review profile: CHILL

📥 Commits

Files that changed from the base of the PR and between 135ccee and f7af244.

📒 Files selected for processing (1)
  • apps/judicial-system/digital-mailbox-api/src/app/modules/cases/models/subpoena.response.ts (4 hunks)
🧰 Additional context used
📓 Path-based instructions (1)
apps/judicial-system/digital-mailbox-api/src/app/modules/cases/models/subpoena.response.ts (1)

Pattern apps/**/*: "Confirm that the code adheres to the following:

  • NextJS best practices, including file structure, API routes, and static generation methods.
  • Efficient state management and server-side rendering techniques.
  • Optimal use of TypeScript for component and utility type safety."
🔇 Additional comments (2)
apps/judicial-system/digital-mailbox-api/src/app/modules/cases/models/subpoena.response.ts (2)

9-13: LGTM: New imports are relevant and necessary.

The added imports from '@island.is/judicial-system/types' are appropriate for the changes made in this file. They introduce necessary types and functions used in the updated code.


100-104: LGTM: Improved handling of subpoenas and service status.

The changes in this segment effectively address previous concerns and improve the code:

  1. Renaming subpoena to subpoenas better reflects the handling of multiple subpoenas.
  2. The added check subpoenas.length > 0 prevents potential undefined access, addressing a previous review comment.
  3. Using isSuccessfulServiceStatus centralizes the logic for checking service status, improving maintainability.

These changes enhance the robustness and clarity of the code.

@kodiakhq kodiakhq bot merged commit 362f331 into main Oct 7, 2024
37 checks passed
@kodiakhq kodiakhq bot deleted the j-s/fix-digital-mailbox-api branch October 7, 2024 18:54
thordurhhh pushed a commit that referenced this pull request Oct 8, 2024
* feat(j-s): Block create subpoena on staging and dev

* Update subpoena.service.ts

* fix(j-s): Fix mailbox API

* remove changes not meant for this branch

* Update subpoena.service.ts

* fix(j-s): reverting changes from other branch

* Update subpoena.response.ts

* Update subpoena.response.ts

* Update subpoena.response.ts

* Update subpoena.response.ts

---------

Co-authored-by: kodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com>
kodiakhq bot added a commit that referenced this pull request Oct 11, 2024
…-pages (#16234)

* Service portal removal. Add portals my pages

* minor fixes

* Fix

* path fix

* fix(portals-admin): locklist (#16279)

* fix(portals-admin): locklist

* tweak

* msg id fix

* tweak

---------

Co-authored-by: kodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com>

* feat(service-portal): feature flag resolver for documents (#16285)

* fix: def info and alert

* feat: add feature flag to resolver

* fix: move ff call to seperate function

---------

Co-authored-by: kodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com>

* fix(vehicles-bulk-mileage): Fixes after testing review (#16295)

* fix: testing fixes v1

* fix: testing comments v2

* fix: better message

* fix: function name

* fix: duplicate loading

---------

Co-authored-by: kodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com>

* feat(tests): New @island/testing/e2e library (#16287)

* Add @swc-node/register and @swc/core

* Add testing/e2e library

* update project.json for testing/e2e

* fix import for libTestingE2e

---------

Co-authored-by: Kristofer <kristofer@andes.is>
Co-authored-by: kodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com>

* feat(parental-leave): ApplicationRights (#15901)

* feat(parental-leave): ApplicationRights

Added applicationRights to parental-leave when sending application. Since we are using a new way of calculating periods

* Fix days used by period calculation

* Tests for new periods

* rename function with proper camelCase

* Refactor: Made duplicate code into a function

* Make ApplicationRights nullable

* refactor: function instead of duplicate code

* remove console.log

* error handling for period data

* clientConfig nullable fix

* Fixes for calculation of months. And using clamp to get correct value of daysLeft

* Multiply amount of months by 30 for period calculation with month durations

* Fix old calculation of endDate with months

---------

Co-authored-by: hfhelgason <hfhelgason@deloitte.is>
Co-authored-by: veronikasif <54938148+veronikasif@users.noreply.github.com>
Co-authored-by: kodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com>

* feat(passport-application): Updated readme (#16296)

* updated readme

* updated readme

* chore: nx format:write update dirty files

---------

Co-authored-by: andes-it <builders@andes.is>
Co-authored-by: kodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com>

* fix(regulations-admin): date format signature, remove self affect, disclaimer text (#16288)

Co-authored-by: kodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com>

* fix(regulations-admin): No diff no addition in appendix (#16293)

Co-authored-by: kodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com>

* fix(web): Global alert banner - Handle null case (#16298)

Co-authored-by: kodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com>

* fix(web): Change custom syslumenn pages config for header (#16299)

Co-authored-by: kodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com>

* fix(j-s): Digital mailbox API (#16301)

* feat(j-s): Block create subpoena on staging and dev

* Update subpoena.service.ts

* fix(j-s): Fix mailbox API

* remove changes not meant for this branch

* Update subpoena.service.ts

* fix(j-s): reverting changes from other branch

* Update subpoena.response.ts

* Update subpoena.response.ts

* Update subpoena.response.ts

* Update subpoena.response.ts

---------

Co-authored-by: kodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com>

* fix(signature-collection): Fix list reviewed toggle (#16300)

Co-authored-by: kodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com>

* chore(scripts): Stricter shell script checking (#16242)

* Set style level for shellcheck

* Linting & formatting scripts

* Remove _podman.sh script

* Format all scripts

* Add reviewdog/action-shfmt step

* Configure shfmt

* Merge from main

* Linting

* Move shfmt to before lint

* Remove reviewdog

* Allow external sources in shellcheck

* Use Reviewdog for shellcheck

* Set version for Reviewdog

---------

Co-authored-by: kodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com>

* chore(new-primary-school): Update messages namespace (#16302)

Co-authored-by: veronikasif <54938148+veronikasif@users.noreply.github.com>
Co-authored-by: kodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com>

* feat(driving-license): check if 65+ renewal is possible (#16292)

* check if 65 renewal is possible

* remove console log

* cleanup

* coderabbit tweaks

* coderabbit changes

* quick fix

* add type?

---------

Co-authored-by: kodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com>

* feat(service-portal): default defender and has chosen fields for subpoena (#16306)

* fix: def info and alert

* feat: add feature flag to resolver

* fix: move ff call to seperate function

* feat: add default choices ans has chosen + loading states

* fix: use type

* fix: undefined type issue

* fix: simplify check

* Update service setup for my pages infra

* chore: charts update dirty files

* Remove from infra

* undo rename

---------

Co-authored-by: albinagu <47886428+albinagu@users.noreply.github.com>
Co-authored-by: kodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com>
Co-authored-by: Ásdís Erna Guðmundsdóttir <disa@hugsmidjan.is>
Co-authored-by: Þorkell Máni Þorkelsson <wowthorkell@gmail.com>
Co-authored-by: Svanhildur Einarsdóttir <54863023+svanaeinars@users.noreply.github.com>
Co-authored-by: Kristofer <kristofer@andes.is>
Co-authored-by: helgifr <helgifreyr95@gmail.com>
Co-authored-by: hfhelgason <hfhelgason@deloitte.is>
Co-authored-by: veronikasif <54938148+veronikasif@users.noreply.github.com>
Co-authored-by: Rafn Árnason <rafnarnason@gmail.com>
Co-authored-by: andes-it <builders@andes.is>
Co-authored-by: Rúnar Vestmann <43557895+RunarVestmann@users.noreply.github.com>
Co-authored-by: mannipje <135017126+mannipje@users.noreply.github.com>
Co-authored-by: unakb <una@kolibri.is>
Co-authored-by: juni-haukur <158475136+juni-haukur@users.noreply.github.com>
Co-authored-by: birkirkristmunds <142495885+birkirkristmunds@users.noreply.github.com>
Co-authored-by: Kristján Albert <kal@juni.is>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
automerge Merge this PR as soon as all checks pass
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants