Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix minor typos in e2e readme file #176

Merged

Conversation

sridhargaddam
Copy link
Contributor

No description provided.

Signed-off-by: Sridhar Gaddam <sgaddam@redhat.com>
@sridhargaddam sridhargaddam requested a review from a team as a code owner June 24, 2024 17:35
@istio-testing istio-testing merged commit df42d5a into istio-ecosystem:main Jun 24, 2024
9 checks passed
openshift-service-mesh-bot referenced this pull request in openshift-service-mesh-bot/sail-operator Jun 24, 2024
* upstream/main:
  Fix minor typos in e2e readme file (openshift-service-mesh#176)
  Include steps to create istio-cni ns when missing (openshift-service-mesh#174)
openshift-service-mesh-bot referenced this pull request in openshift-service-mesh-bot/sail-operator Jun 25, 2024
* upstream/main:
  Automator: Update dependencies in istio-ecosystem/sail-operator@main (openshift-service-mesh#177)
  Fix minor typos in e2e readme file (openshift-service-mesh#176)
  Include steps to create istio-cni ns when missing (openshift-service-mesh#174)

# Conflicts:
#	bundle/manifests/servicemeshoperator3.clusterserviceversion.yaml
openshift-service-mesh-bot referenced this pull request in openshift-service-mesh-bot/sail-operator Jun 25, 2024
* upstream/main:
  Automator: Update dependencies in istio-ecosystem/sail-operator@main (openshift-service-mesh#177)
  Fix minor typos in e2e readme file (openshift-service-mesh#176)
  Include steps to create istio-cni ns when missing (openshift-service-mesh#174)

# Conflicts:
#	bundle/manifests/servicemeshoperator3.clusterserviceversion.yaml
openshift-service-mesh-bot referenced this pull request in openshift-service-mesh-bot/sail-operator Jun 25, 2024
* upstream/main:
  Display a friendly message for missing K8s cluster (openshift-service-mesh#175)
  Automator: Update dependencies in istio-ecosystem/sail-operator@main (openshift-service-mesh#177)
  Fix minor typos in e2e readme file (openshift-service-mesh#176)
  Include steps to create istio-cni ns when missing (openshift-service-mesh#174)

# Conflicts:
#	bundle/manifests/servicemeshoperator3.clusterserviceversion.yaml
openshift-service-mesh-bot referenced this pull request in openshift-service-mesh-bot/sail-operator Jun 25, 2024
* upstream/main:
  Display a friendly message for missing K8s cluster (openshift-service-mesh#175)
  Automator: Update dependencies in istio-ecosystem/sail-operator@main (openshift-service-mesh#177)
  Fix minor typos in e2e readme file (openshift-service-mesh#176)
  Include steps to create istio-cni ns when missing (openshift-service-mesh#174)

# Conflicts:
#	bundle/manifests/servicemeshoperator3.clusterserviceversion.yaml
openshift-service-mesh-bot referenced this pull request in openshift-service-mesh-bot/sail-operator Jun 25, 2024
* upstream/main:
  Add docs for sail-operator installation using CLI (openshift-service-mesh#171)
  Display a friendly message for missing K8s cluster (openshift-service-mesh#175)
  Automator: Update dependencies in istio-ecosystem/sail-operator@main (openshift-service-mesh#177)
  Fix minor typos in e2e readme file (openshift-service-mesh#176)
  Include steps to create istio-cni ns when missing (openshift-service-mesh#174)

# Conflicts:
#	bundle/manifests/servicemeshoperator3.clusterserviceversion.yaml
openshift-service-mesh-bot referenced this pull request in openshift-service-mesh-bot/sail-operator Jun 25, 2024
* upstream/main:
  Add docs for sail-operator installation using CLI (openshift-service-mesh#171)
  Display a friendly message for missing K8s cluster (openshift-service-mesh#175)
  Automator: Update dependencies in istio-ecosystem/sail-operator@main (openshift-service-mesh#177)
  Fix minor typos in e2e readme file (openshift-service-mesh#176)
  Include steps to create istio-cni ns when missing (openshift-service-mesh#174)

# Conflicts:
#	bundle/manifests/servicemeshoperator3.clusterserviceversion.yaml
bmangoen pushed a commit to bmangoen/sail-operator that referenced this pull request Jul 18, 2024
Signed-off-by: Sridhar Gaddam <sgaddam@redhat.com>
bmangoen pushed a commit to bmangoen/sail-operator that referenced this pull request Jul 18, 2024
Signed-off-by: Sridhar Gaddam <sgaddam@redhat.com>
Signed-off-by: bmangoen <bmangoen@redhat.com>
istio-testing pushed a commit that referenced this pull request Jul 19, 2024
* Include steps to create istio-cni ns when missing (#174)

Signed-off-by: Sridhar Gaddam <sgaddam@redhat.com>
Signed-off-by: bmangoen <bmangoen@redhat.com>

* Fix minor typos in e2e readme file (#176)

Signed-off-by: Sridhar Gaddam <sgaddam@redhat.com>
Signed-off-by: bmangoen <bmangoen@redhat.com>

* Display a friendly message for missing K8s cluster (#175)

Some of the Makefile commands require a running K8s cluster.
When these commands are issued without an active cluster, we
currently do not display a proper message, and users have to
figure it out manually. This PR fixes that by verifying access
to a running cluster and displaying a friendly message if not.

Signed-off-by: Sridhar Gaddam <sgaddam@redhat.com>
Signed-off-by: bmangoen <bmangoen@redhat.com>

* Add docs for sail-operator installation using CLI (#171)

* Add installation with CLI doc

Signed-off-by: bmangoen <bmangoen@redhat.com>

* Use 0.1-nightly channel

Signed-off-by: bmangoen <bmangoen@redhat.com>

---------

Signed-off-by: bmangoen <bmangoen@redhat.com>

* Prerequisites for installing using CLI (#179)

Signed-off-by: bmangoen <bmangoen@redhat.com>

* Add user docs for addons (#187)

* Add user docs for addons

Signed-off-by: Nick Fox <nfox@redhat.com>

* Apply suggestions from code review

Co-authored-by: Sridhar Gaddam <sgaddam@redhat.com>

---------

Signed-off-by: Nick Fox <nfox@redhat.com>
Co-authored-by: Sridhar Gaddam <sgaddam@redhat.com>
Signed-off-by: bmangoen <bmangoen@redhat.com>

* Remove outdated comments from Dockerfile (#194)

We're not planning on using distroles

Signed-off-by: Daniel Grimm <dgrimm@redhat.com>
Signed-off-by: bmangoen <bmangoen@redhat.com>

* Add enhancements/ directory (#191)

* Add enhancements/ directory

I added an enhancement template and a first SEP that discusses the
process

Signed-off-by: Daniel Grimm <dgrimm@redhat.com>

* Added `backward compatibility` section to template

Signed-off-by: Daniel Grimm <dgrimm@redhat.com>

* Wording

Signed-off-by: Daniel Grimm <dgrimm@redhat.com>

* Add a sentence about istio design doc

Signed-off-by: Daniel Grimm <dgrimm@redhat.com>

---------

Signed-off-by: Daniel Grimm <dgrimm@redhat.com>
Signed-off-by: bmangoen <bmangoen@redhat.com>

* Add helm-publish make target (#203)

* Add helm-publish target

Signed-off-by: bmangoen <bmangoen@redhat.com>

* Add comment for helm-publish target

Signed-off-by: bmangoen <bmangoen@redhat.com>

---------

Signed-off-by: bmangoen <bmangoen@redhat.com>

* #204 Update Redme with enhancement process information (#205)

Signed-off-by: frherrer <frherrer@redhat.com>
Signed-off-by: bmangoen <bmangoen@redhat.com>

---------

Signed-off-by: Sridhar Gaddam <sgaddam@redhat.com>
Signed-off-by: bmangoen <bmangoen@redhat.com>
Signed-off-by: Nick Fox <nfox@redhat.com>
Signed-off-by: Daniel Grimm <dgrimm@redhat.com>
Signed-off-by: frherrer <frherrer@redhat.com>
Co-authored-by: Sridhar Gaddam <sgaddam@redhat.com>
Co-authored-by: Nick Fox <nick@nrfox.com>
Co-authored-by: Daniel Grimm <dgrimm@redhat.com>
Co-authored-by: Francisco Herrera <frherrer@redhat.com>
FilipB pushed a commit to FilipB/sail-operator that referenced this pull request Dec 12, 2024
…t/master-release-3.0-tp2-merge_upstream_release-0.2-032ed811

Automator: merge upstream changes to openshift-service-mesh/sail-operator@release-3.0-tp2
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants