-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix minor typos in e2e readme file #176
Merged
istio-testing
merged 1 commit into
istio-ecosystem:main
from
sridhargaddam:fix-typo-e2e-readme
Jun 24, 2024
Merged
Fix minor typos in e2e readme file #176
istio-testing
merged 1 commit into
istio-ecosystem:main
from
sridhargaddam:fix-typo-e2e-readme
Jun 24, 2024
+2
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Sridhar Gaddam <sgaddam@redhat.com>
luksa
approved these changes
Jun 24, 2024
openshift-service-mesh-bot
referenced
this pull request
in openshift-service-mesh-bot/sail-operator
Jun 24, 2024
* upstream/main: Fix minor typos in e2e readme file (openshift-service-mesh#176) Include steps to create istio-cni ns when missing (openshift-service-mesh#174)
openshift-service-mesh-bot
referenced
this pull request
in openshift-service-mesh-bot/sail-operator
Jun 25, 2024
* upstream/main: Automator: Update dependencies in istio-ecosystem/sail-operator@main (openshift-service-mesh#177) Fix minor typos in e2e readme file (openshift-service-mesh#176) Include steps to create istio-cni ns when missing (openshift-service-mesh#174) # Conflicts: # bundle/manifests/servicemeshoperator3.clusterserviceversion.yaml
openshift-service-mesh-bot
referenced
this pull request
in openshift-service-mesh-bot/sail-operator
Jun 25, 2024
* upstream/main: Automator: Update dependencies in istio-ecosystem/sail-operator@main (openshift-service-mesh#177) Fix minor typos in e2e readme file (openshift-service-mesh#176) Include steps to create istio-cni ns when missing (openshift-service-mesh#174) # Conflicts: # bundle/manifests/servicemeshoperator3.clusterserviceversion.yaml
openshift-service-mesh-bot
referenced
this pull request
in openshift-service-mesh-bot/sail-operator
Jun 25, 2024
* upstream/main: Display a friendly message for missing K8s cluster (openshift-service-mesh#175) Automator: Update dependencies in istio-ecosystem/sail-operator@main (openshift-service-mesh#177) Fix minor typos in e2e readme file (openshift-service-mesh#176) Include steps to create istio-cni ns when missing (openshift-service-mesh#174) # Conflicts: # bundle/manifests/servicemeshoperator3.clusterserviceversion.yaml
openshift-service-mesh-bot
referenced
this pull request
in openshift-service-mesh-bot/sail-operator
Jun 25, 2024
* upstream/main: Display a friendly message for missing K8s cluster (openshift-service-mesh#175) Automator: Update dependencies in istio-ecosystem/sail-operator@main (openshift-service-mesh#177) Fix minor typos in e2e readme file (openshift-service-mesh#176) Include steps to create istio-cni ns when missing (openshift-service-mesh#174) # Conflicts: # bundle/manifests/servicemeshoperator3.clusterserviceversion.yaml
openshift-service-mesh-bot
referenced
this pull request
in openshift-service-mesh-bot/sail-operator
Jun 25, 2024
* upstream/main: Add docs for sail-operator installation using CLI (openshift-service-mesh#171) Display a friendly message for missing K8s cluster (openshift-service-mesh#175) Automator: Update dependencies in istio-ecosystem/sail-operator@main (openshift-service-mesh#177) Fix minor typos in e2e readme file (openshift-service-mesh#176) Include steps to create istio-cni ns when missing (openshift-service-mesh#174) # Conflicts: # bundle/manifests/servicemeshoperator3.clusterserviceversion.yaml
openshift-service-mesh-bot
referenced
this pull request
in openshift-service-mesh-bot/sail-operator
Jun 25, 2024
* upstream/main: Add docs for sail-operator installation using CLI (openshift-service-mesh#171) Display a friendly message for missing K8s cluster (openshift-service-mesh#175) Automator: Update dependencies in istio-ecosystem/sail-operator@main (openshift-service-mesh#177) Fix minor typos in e2e readme file (openshift-service-mesh#176) Include steps to create istio-cni ns when missing (openshift-service-mesh#174) # Conflicts: # bundle/manifests/servicemeshoperator3.clusterserviceversion.yaml
bmangoen
pushed a commit
to bmangoen/sail-operator
that referenced
this pull request
Jul 18, 2024
Signed-off-by: Sridhar Gaddam <sgaddam@redhat.com>
bmangoen
pushed a commit
to bmangoen/sail-operator
that referenced
this pull request
Jul 18, 2024
Signed-off-by: Sridhar Gaddam <sgaddam@redhat.com> Signed-off-by: bmangoen <bmangoen@redhat.com>
istio-testing
pushed a commit
that referenced
this pull request
Jul 19, 2024
* Include steps to create istio-cni ns when missing (#174) Signed-off-by: Sridhar Gaddam <sgaddam@redhat.com> Signed-off-by: bmangoen <bmangoen@redhat.com> * Fix minor typos in e2e readme file (#176) Signed-off-by: Sridhar Gaddam <sgaddam@redhat.com> Signed-off-by: bmangoen <bmangoen@redhat.com> * Display a friendly message for missing K8s cluster (#175) Some of the Makefile commands require a running K8s cluster. When these commands are issued without an active cluster, we currently do not display a proper message, and users have to figure it out manually. This PR fixes that by verifying access to a running cluster and displaying a friendly message if not. Signed-off-by: Sridhar Gaddam <sgaddam@redhat.com> Signed-off-by: bmangoen <bmangoen@redhat.com> * Add docs for sail-operator installation using CLI (#171) * Add installation with CLI doc Signed-off-by: bmangoen <bmangoen@redhat.com> * Use 0.1-nightly channel Signed-off-by: bmangoen <bmangoen@redhat.com> --------- Signed-off-by: bmangoen <bmangoen@redhat.com> * Prerequisites for installing using CLI (#179) Signed-off-by: bmangoen <bmangoen@redhat.com> * Add user docs for addons (#187) * Add user docs for addons Signed-off-by: Nick Fox <nfox@redhat.com> * Apply suggestions from code review Co-authored-by: Sridhar Gaddam <sgaddam@redhat.com> --------- Signed-off-by: Nick Fox <nfox@redhat.com> Co-authored-by: Sridhar Gaddam <sgaddam@redhat.com> Signed-off-by: bmangoen <bmangoen@redhat.com> * Remove outdated comments from Dockerfile (#194) We're not planning on using distroles Signed-off-by: Daniel Grimm <dgrimm@redhat.com> Signed-off-by: bmangoen <bmangoen@redhat.com> * Add enhancements/ directory (#191) * Add enhancements/ directory I added an enhancement template and a first SEP that discusses the process Signed-off-by: Daniel Grimm <dgrimm@redhat.com> * Added `backward compatibility` section to template Signed-off-by: Daniel Grimm <dgrimm@redhat.com> * Wording Signed-off-by: Daniel Grimm <dgrimm@redhat.com> * Add a sentence about istio design doc Signed-off-by: Daniel Grimm <dgrimm@redhat.com> --------- Signed-off-by: Daniel Grimm <dgrimm@redhat.com> Signed-off-by: bmangoen <bmangoen@redhat.com> * Add helm-publish make target (#203) * Add helm-publish target Signed-off-by: bmangoen <bmangoen@redhat.com> * Add comment for helm-publish target Signed-off-by: bmangoen <bmangoen@redhat.com> --------- Signed-off-by: bmangoen <bmangoen@redhat.com> * #204 Update Redme with enhancement process information (#205) Signed-off-by: frherrer <frherrer@redhat.com> Signed-off-by: bmangoen <bmangoen@redhat.com> --------- Signed-off-by: Sridhar Gaddam <sgaddam@redhat.com> Signed-off-by: bmangoen <bmangoen@redhat.com> Signed-off-by: Nick Fox <nfox@redhat.com> Signed-off-by: Daniel Grimm <dgrimm@redhat.com> Signed-off-by: frherrer <frherrer@redhat.com> Co-authored-by: Sridhar Gaddam <sgaddam@redhat.com> Co-authored-by: Nick Fox <nick@nrfox.com> Co-authored-by: Daniel Grimm <dgrimm@redhat.com> Co-authored-by: Francisco Herrera <frherrer@redhat.com>
FilipB
pushed a commit
to FilipB/sail-operator
that referenced
this pull request
Dec 12, 2024
…t/master-release-3.0-tp2-merge_upstream_release-0.2-032ed811 Automator: merge upstream changes to openshift-service-mesh/sail-operator@release-3.0-tp2
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.