-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add helm-publish make target #203
Add helm-publish make target #203
Conversation
Signed-off-by: bmangoen <bmangoen@redhat.com>
Signed-off-by: bmangoen <bmangoen@redhat.com>
6c8e737
to
56ed06f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, this will be executed in a postsubmit job only in release branches?
* upstream/main: openshift-service-mesh#204 Update Redme with enhancement process information (openshift-service-mesh#205) Add helm-publish make target (openshift-service-mesh#203)
It is the idea to do so. Hum we might have to separate the release/tag creation and the upload of the helm charts tarball because |
* upstream/main: openshift-service-mesh#204 Update Redme with enhancement process information (openshift-service-mesh#205) Add helm-publish make target (openshift-service-mesh#203)
* upstream/main: openshift-service-mesh#204 Update Redme with enhancement process information (openshift-service-mesh#205) Add helm-publish make target (openshift-service-mesh#203)
* Add helm-publish target Signed-off-by: bmangoen <bmangoen@redhat.com> * Add comment for helm-publish target Signed-off-by: bmangoen <bmangoen@redhat.com> --------- Signed-off-by: bmangoen <bmangoen@redhat.com>
* Add helm-publish target Signed-off-by: bmangoen <bmangoen@redhat.com> * Add comment for helm-publish target Signed-off-by: bmangoen <bmangoen@redhat.com> --------- Signed-off-by: bmangoen <bmangoen@redhat.com>
* Include steps to create istio-cni ns when missing (#174) Signed-off-by: Sridhar Gaddam <sgaddam@redhat.com> Signed-off-by: bmangoen <bmangoen@redhat.com> * Fix minor typos in e2e readme file (#176) Signed-off-by: Sridhar Gaddam <sgaddam@redhat.com> Signed-off-by: bmangoen <bmangoen@redhat.com> * Display a friendly message for missing K8s cluster (#175) Some of the Makefile commands require a running K8s cluster. When these commands are issued without an active cluster, we currently do not display a proper message, and users have to figure it out manually. This PR fixes that by verifying access to a running cluster and displaying a friendly message if not. Signed-off-by: Sridhar Gaddam <sgaddam@redhat.com> Signed-off-by: bmangoen <bmangoen@redhat.com> * Add docs for sail-operator installation using CLI (#171) * Add installation with CLI doc Signed-off-by: bmangoen <bmangoen@redhat.com> * Use 0.1-nightly channel Signed-off-by: bmangoen <bmangoen@redhat.com> --------- Signed-off-by: bmangoen <bmangoen@redhat.com> * Prerequisites for installing using CLI (#179) Signed-off-by: bmangoen <bmangoen@redhat.com> * Add user docs for addons (#187) * Add user docs for addons Signed-off-by: Nick Fox <nfox@redhat.com> * Apply suggestions from code review Co-authored-by: Sridhar Gaddam <sgaddam@redhat.com> --------- Signed-off-by: Nick Fox <nfox@redhat.com> Co-authored-by: Sridhar Gaddam <sgaddam@redhat.com> Signed-off-by: bmangoen <bmangoen@redhat.com> * Remove outdated comments from Dockerfile (#194) We're not planning on using distroles Signed-off-by: Daniel Grimm <dgrimm@redhat.com> Signed-off-by: bmangoen <bmangoen@redhat.com> * Add enhancements/ directory (#191) * Add enhancements/ directory I added an enhancement template and a first SEP that discusses the process Signed-off-by: Daniel Grimm <dgrimm@redhat.com> * Added `backward compatibility` section to template Signed-off-by: Daniel Grimm <dgrimm@redhat.com> * Wording Signed-off-by: Daniel Grimm <dgrimm@redhat.com> * Add a sentence about istio design doc Signed-off-by: Daniel Grimm <dgrimm@redhat.com> --------- Signed-off-by: Daniel Grimm <dgrimm@redhat.com> Signed-off-by: bmangoen <bmangoen@redhat.com> * Add helm-publish make target (#203) * Add helm-publish target Signed-off-by: bmangoen <bmangoen@redhat.com> * Add comment for helm-publish target Signed-off-by: bmangoen <bmangoen@redhat.com> --------- Signed-off-by: bmangoen <bmangoen@redhat.com> * #204 Update Redme with enhancement process information (#205) Signed-off-by: frherrer <frherrer@redhat.com> Signed-off-by: bmangoen <bmangoen@redhat.com> --------- Signed-off-by: Sridhar Gaddam <sgaddam@redhat.com> Signed-off-by: bmangoen <bmangoen@redhat.com> Signed-off-by: Nick Fox <nfox@redhat.com> Signed-off-by: Daniel Grimm <dgrimm@redhat.com> Signed-off-by: frherrer <frherrer@redhat.com> Co-authored-by: Sridhar Gaddam <sgaddam@redhat.com> Co-authored-by: Nick Fox <nick@nrfox.com> Co-authored-by: Daniel Grimm <dgrimm@redhat.com> Co-authored-by: Francisco Herrera <frherrer@redhat.com>
* feat: migration documentation updates # Conflicts: # docs/ossm/ossm2-migration/README.md * address filip's review * add example yaml if user cannot migrate without NPs * rename from default, add default fields to examples * change label to enabled * add note on label for selectors * Update docs/ossm/ossm2-migration/network-policies.md Co-authored-by: Nick Fox <6226732+nrfox@users.noreply.github.com> * re-order example into individual steps * avoid NP name conflicts --------- Co-authored-by: Nick Fox <6226732+nrfox@users.noreply.github.com>
According to this issue #110, we want to create a release and upload the helm charts package tarball as a release asset