Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add enhancements/ directory #191

Merged
merged 4 commits into from
Jul 12, 2024
Merged

Add enhancements/ directory #191

merged 4 commits into from
Jul 12, 2024

Conversation

dgn
Copy link
Collaborator

@dgn dgn commented Jul 9, 2024

I added an enhancement template and a first SEP that discusses the process

@dgn
Add enhancements/ directory
5157ad3 
I added an enhancement template and a first SEP that discusses the
process

Signed-off-by: Daniel Grimm <dgrimm@redhat.com>
@dgn dgn requested a review from a team as a code owner July 9, 2024 13:17
@dgn
Added backward compatibility section to template
ef4075c 
Signed-off-by: Daniel Grimm <dgrimm@redhat.com>
@dgn
Wording
367594c 
Signed-off-by: Daniel Grimm <dgrimm@redhat.com>
@dgn dgn force-pushed the enhancements-process branch from 5299a4b to 367594c Compare July 9, 2024 13:46
@dgn
Add a sentence about istio design doc
75f0ac1 
Signed-off-by: Daniel Grimm <dgrimm@redhat.com>
@dgn
Copy link
Collaborator Author

dgn commented Jul 10, 2024

/retest

fjglira
fjglira approved these changes Jul 12, 2024
View reviewed changes
Copy link
Contributor

@fjglira fjglira left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like this process, will help to have in one place inside the repo all those big changes that we will do at some point (Instead of having a drive folder with a lot of doc, you can have in the repo)

@istio-testing istio-testing merged commit eda1145 into istio-ecosystem:main Jul 12, 2024
9 checks passed
@fjglira
Copy link
Contributor

fjglira commented Jul 12, 2024

I think we need to add also a reference in the read me file to link to this enhancements directory

openshift-service-mesh-bot pushed a commit to openshift-service-mesh-bot/sail-operator that referenced this pull request Jul 12, 2024
Automated merge
0ce8f8c 
* upstream/main:
  Add enhancements/ directory (istio-ecosystem#191)
openshift-service-mesh-bot pushed a commit to openshift-service-mesh-bot/sail-operator that referenced this pull request Jul 12, 2024
Automated merge
70031a3 
* upstream/main:
  Add enhancements/ directory (istio-ecosystem#191)
@dgn dgn deleted the enhancements-process branch July 15, 2024 07:02
@FilipB
Copy link
Collaborator

FilipB commented Jul 15, 2024

LGTM, should we update the status to Done?

@fjglira
Copy link
Contributor

fjglira commented Jul 15, 2024

LGTM, should we update the status to Done?

Yes, we can update this at the same time that we add the reference for this documentation in the read me file.

bmangoen pushed a commit to bmangoen/sail-operator that referenced this pull request Jul 18, 2024
@dgn @bmangoen
Add enhancements/ directory (istio-ecosystem#191)
5df98eb 
* Add enhancements/ directory

I added an enhancement template and a first SEP that discusses the
process

Signed-off-by: Daniel Grimm <dgrimm@redhat.com>

* Added `backward compatibility` section to template

Signed-off-by: Daniel Grimm <dgrimm@redhat.com>

* Wording

Signed-off-by: Daniel Grimm <dgrimm@redhat.com>

* Add a sentence about istio design doc

Signed-off-by: Daniel Grimm <dgrimm@redhat.com>

---------

Signed-off-by: Daniel Grimm <dgrimm@redhat.com>
bmangoen pushed a commit to bmangoen/sail-operator that referenced this pull request Jul 18, 2024
@dgn @bmangoen
Add enhancements/ directory (istio-ecosystem#191)
0e89d3d 
* Add enhancements/ directory

I added an enhancement template and a first SEP that discusses the
process

Signed-off-by: Daniel Grimm <dgrimm@redhat.com>

* Added `backward compatibility` section to template

Signed-off-by: Daniel Grimm <dgrimm@redhat.com>

* Wording

Signed-off-by: Daniel Grimm <dgrimm@redhat.com>

* Add a sentence about istio design doc

Signed-off-by: Daniel Grimm <dgrimm@redhat.com>

---------

Signed-off-by: Daniel Grimm <dgrimm@redhat.com>
Signed-off-by: bmangoen <bmangoen@redhat.com>
istio-testing pushed a commit that referenced this pull request Jul 19, 2024
@bmangoen @sridhargaddam
@nrfox @dgn @fjglira
Cherry-pick doc commits to release-0.1 (#221)
d72f6f0 
* Include steps to create istio-cni ns when missing (#174)

Signed-off-by: Sridhar Gaddam <sgaddam@redhat.com>
Signed-off-by: bmangoen <bmangoen@redhat.com>

* Fix minor typos in e2e readme file (#176)

Signed-off-by: Sridhar Gaddam <sgaddam@redhat.com>
Signed-off-by: bmangoen <bmangoen@redhat.com>

* Display a friendly message for missing K8s cluster (#175)

Some of the Makefile commands require a running K8s cluster.
When these commands are issued without an active cluster, we
currently do not display a proper message, and users have to
figure it out manually. This PR fixes that by verifying access
to a running cluster and displaying a friendly message if not.

Signed-off-by: Sridhar Gaddam <sgaddam@redhat.com>
Signed-off-by: bmangoen <bmangoen@redhat.com>

* Add docs for sail-operator installation using CLI (#171)

* Add installation with CLI doc

Signed-off-by: bmangoen <bmangoen@redhat.com>

* Use 0.1-nightly channel

Signed-off-by: bmangoen <bmangoen@redhat.com>

---------

Signed-off-by: bmangoen <bmangoen@redhat.com>

* Prerequisites for installing using CLI (#179)

Signed-off-by: bmangoen <bmangoen@redhat.com>

* Add user docs for addons (#187)

* Add user docs for addons

Signed-off-by: Nick Fox <nfox@redhat.com>

* Apply suggestions from code review

Co-authored-by: Sridhar Gaddam <sgaddam@redhat.com>

---------

Signed-off-by: Nick Fox <nfox@redhat.com>
Co-authored-by: Sridhar Gaddam <sgaddam@redhat.com>
Signed-off-by: bmangoen <bmangoen@redhat.com>

* Remove outdated comments from Dockerfile (#194)

We're not planning on using distroles

Signed-off-by: Daniel Grimm <dgrimm@redhat.com>
Signed-off-by: bmangoen <bmangoen@redhat.com>

* Add enhancements/ directory (#191)

* Add enhancements/ directory

I added an enhancement template and a first SEP that discusses the
process

Signed-off-by: Daniel Grimm <dgrimm@redhat.com>

* Added `backward compatibility` section to template

Signed-off-by: Daniel Grimm <dgrimm@redhat.com>

* Wording

Signed-off-by: Daniel Grimm <dgrimm@redhat.com>

* Add a sentence about istio design doc

Signed-off-by: Daniel Grimm <dgrimm@redhat.com>

---------

Signed-off-by: Daniel Grimm <dgrimm@redhat.com>
Signed-off-by: bmangoen <bmangoen@redhat.com>

* Add helm-publish make target (#203)

* Add helm-publish target

Signed-off-by: bmangoen <bmangoen@redhat.com>

* Add comment for helm-publish target

Signed-off-by: bmangoen <bmangoen@redhat.com>

---------

Signed-off-by: bmangoen <bmangoen@redhat.com>

* #204 Update Redme with enhancement process information (#205)

Signed-off-by: frherrer <frherrer@redhat.com>
Signed-off-by: bmangoen <bmangoen@redhat.com>

---------

Signed-off-by: Sridhar Gaddam <sgaddam@redhat.com>
Signed-off-by: bmangoen <bmangoen@redhat.com>
Signed-off-by: Nick Fox <nfox@redhat.com>
Signed-off-by: Daniel Grimm <dgrimm@redhat.com>
Signed-off-by: frherrer <frherrer@redhat.com>
Co-authored-by: Sridhar Gaddam <sgaddam@redhat.com>
Co-authored-by: Nick Fox <nick@nrfox.com>
Co-authored-by: Daniel Grimm <dgrimm@redhat.com>
Co-authored-by: Francisco Herrera <frherrer@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sridhargaddam sridhargaddam sridhargaddam left review comments

@fjglira fjglira fjglira approved these changes

Assignees
No one assigned
Labels
size/M
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@dgn @fjglira @FilipB @sridhargaddam @istio-testing