Rename addTags to addComments in API transformer
#259
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Marko Lukša <mluksa@redhat.com>
sridhargaddam
approved these changes
Aug 9, 2024
dgn
pushed a commit
to dgn/sail-operator
that referenced
this pull request
Aug 13, 2024
…#259) Signed-off-by: Marko Lukša <mluksa@redhat.com> Signed-off-by: Daniel Grimm <dgrimm@redhat.com>
openshift-service-mesh-bot
pushed a commit
to openshift-service-mesh-bot/sail-operator
that referenced
this pull request
Aug 13, 2024
* upstream/main: Ensure `make gen-check` works when go mod cache is empty (istio-ecosystem#270) Introduce RemoteIstio (istio-ecosystem#202) api_transformer: use `go env` to detect mod cache dir (istio-ecosystem#269) Add field values.experimental to API (istio-ecosystem#264) Fix errors in tables for api reference documentation (istio-ecosystem#263) Generate CNIGlobalConfig from GlobalConfig automatically (istio-ecosystem#260) Fix errors in api reference doc (istio-ecosystem#262) Rename `addTags` to `addComments` in API transformer (istio-ecosystem#259) Add relatedImages to ClusterServiceVersion (istio-ecosystem#243) Generate API from versions defined in go.mod (istio-ecosystem#258) Fix issues identified during API review (istio-ecosystem#254) # Conflicts: # bundle/manifests/sailoperator.clusterserviceversion.yaml
istio-testing
pushed a commit
that referenced
this pull request
Aug 13, 2024
Signed-off-by: Marko Lukša <mluksa@redhat.com> Signed-off-by: Daniel Grimm <dgrimm@redhat.com>
openshift-service-mesh-bot
pushed a commit
to openshift-service-mesh-bot/sail-operator
that referenced
this pull request
Aug 13, 2024
* upstream/main: Add `RemoteIstio` to API concepts in docs (istio-ecosystem#272) Ensure `make gen-check` works when go mod cache is empty (istio-ecosystem#270) Introduce RemoteIstio (istio-ecosystem#202) api_transformer: use `go env` to detect mod cache dir (istio-ecosystem#269) Add field values.experimental to API (istio-ecosystem#264) Fix errors in tables for api reference documentation (istio-ecosystem#263) Generate CNIGlobalConfig from GlobalConfig automatically (istio-ecosystem#260) Fix errors in api reference doc (istio-ecosystem#262) Rename `addTags` to `addComments` in API transformer (istio-ecosystem#259) Add relatedImages to ClusterServiceVersion (istio-ecosystem#243) Generate API from versions defined in go.mod (istio-ecosystem#258) Fix issues identified during API review (istio-ecosystem#254) # Conflicts: # bundle/manifests/sailoperator.clusterserviceversion.yaml
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.