Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix errors in tables for api reference documentation #263

Merged
merged 1 commit into from
Aug 12, 2024

Conversation

fjglira
Copy link
Contributor

@fjglira fjglira commented Aug 12, 2024

Some of the tables was not correctly formed because of the deletion the new line prior the table

Signed-off-by: frherrer <frherrer@redhat.com>
@fjglira fjglira requested a review from a team as a code owner August 12, 2024 12:04
@fjglira
Copy link
Contributor Author

fjglira commented Aug 12, 2024

/test gencheck

@istio-testing istio-testing merged commit 48b7bbf into istio-ecosystem:main Aug 12, 2024
11 checks passed
dgn pushed a commit to dgn/sail-operator that referenced this pull request Aug 13, 2024
…#263)

Signed-off-by: frherrer <frherrer@redhat.com>
Signed-off-by: Daniel Grimm <dgrimm@redhat.com>
openshift-service-mesh-bot pushed a commit to openshift-service-mesh-bot/sail-operator that referenced this pull request Aug 13, 2024
* upstream/main:
  Ensure `make gen-check` works when go mod cache is empty (istio-ecosystem#270)
  Introduce RemoteIstio (istio-ecosystem#202)
  api_transformer: use `go env` to detect mod cache dir (istio-ecosystem#269)
  Add field values.experimental to API (istio-ecosystem#264)
  Fix errors in tables for api reference documentation (istio-ecosystem#263)
  Generate CNIGlobalConfig from GlobalConfig automatically (istio-ecosystem#260)
  Fix errors in api reference doc (istio-ecosystem#262)
  Rename `addTags` to `addComments` in API transformer (istio-ecosystem#259)
  Add relatedImages to ClusterServiceVersion (istio-ecosystem#243)
  Generate API from versions defined in go.mod (istio-ecosystem#258)
  Fix issues identified during API review (istio-ecosystem#254)

# Conflicts:
#	bundle/manifests/sailoperator.clusterserviceversion.yaml
istio-testing pushed a commit that referenced this pull request Aug 13, 2024
Signed-off-by: frherrer <frherrer@redhat.com>
Signed-off-by: Daniel Grimm <dgrimm@redhat.com>
openshift-service-mesh-bot pushed a commit to openshift-service-mesh-bot/sail-operator that referenced this pull request Aug 13, 2024
* upstream/main:
  Add `RemoteIstio` to API concepts in docs (istio-ecosystem#272)
  Ensure `make gen-check` works when go mod cache is empty (istio-ecosystem#270)
  Introduce RemoteIstio (istio-ecosystem#202)
  api_transformer: use `go env` to detect mod cache dir (istio-ecosystem#269)
  Add field values.experimental to API (istio-ecosystem#264)
  Fix errors in tables for api reference documentation (istio-ecosystem#263)
  Generate CNIGlobalConfig from GlobalConfig automatically (istio-ecosystem#260)
  Fix errors in api reference doc (istio-ecosystem#262)
  Rename `addTags` to `addComments` in API transformer (istio-ecosystem#259)
  Add relatedImages to ClusterServiceVersion (istio-ecosystem#243)
  Generate API from versions defined in go.mod (istio-ecosystem#258)
  Fix issues identified during API review (istio-ecosystem#254)

# Conflicts:
#	bundle/manifests/sailoperator.clusterserviceversion.yaml
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants