-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: update the networking folder for the zh-docs #10717
Conversation
😊 Welcome! This is either your first contribution to the Istio documentation repo, or
Thanks for contributing! Courtesy of your friendly welcome wagon. |
Hi @saltbo. Thanks for your PR. I'm waiting for a istio member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
54333bb
to
10a48c0
Compare
@saltbo are you still WIP? IMHO, we should not copy en doc to zh folder. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/ok-to-test
AFAIK, reference docs are generated from istio/api repo, @ericvn can you share more details about it? |
@saltbo: The following tests failed, say
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
@zirain You are correct in that there is a nightly job which updates various reference documents based on thing in other repos. The job runs Ignoring that issue, another question would be if these reference files should/could contain translated text? If they could include translations, then we would not want to replace them every time. If they should remain the same across translations, then I think we could upgrade the script to update them all in each language. I'm curious what @craigbox and the translation teams think. Should these files have translations, or should the be consistent across languages? Note: If we update the script, we probably need to tweak the links that the reference docs point to (see the lint errors):
|
I am doing a quick test in #10719 to see what might happen if we tried to updating the /zh/ version of the reference files using the tooling. It looks like we would have to do some more updates for some issues I noted there. |
No response on whether we should update the reference docs in the /zh/ tree so closing my test PR for now. If we want to update all the reference docs, we can recreate the PR, as there have been updates since that PR was done. |
#11252 updates the reference docs in the |
@saltbo: PR needs rebase. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
No description provided.