Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update reference docs in zh path #11252

Merged
merged 2 commits into from
May 10, 2022
Merged

Conversation

ericvn
Copy link
Contributor

@ericvn ericvn commented May 2, 2022

Please provide a description for what this PR is for.

The first pass of this PR is to update the zh path reference docs by modifying the grab_reference_docs script (new script also checked in). This resulted in files being deleted, new files being created, as well as many modified files. Given the updated reference docs, see if the various linting checks still pass and there aren't outstanding errors within the docs pointing the the newly updated reference docs or pointing to removed docs.

If this works, then we can try updating the grab_reference_docs script to simply update both sets of documents when it is run. This would be in the next commit.

@ericvn ericvn added the do-not-merge/work-in-progress Block merging of a PR because it isn't ready yet. label May 2, 2022
@ericvn ericvn requested review from a team as code owners May 2, 2022 13:46
@istio-testing istio-testing added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed do-not-merge/work-in-progress Block merging of a PR because it isn't ready yet. labels May 2, 2022
@ericvn ericvn added kind/site infra do-not-merge Block automatic merging of a PR. translation/chinese Translation item and removed size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels May 2, 2022
@istio-testing istio-testing added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label May 2, 2022
@ericvn
Copy link
Contributor Author

ericvn commented May 2, 2022

Lint passed on commit #1, so updating grab_reference_docs to do both en and zh branches. Running the script showed no changes in the reference files from prior commit. Commit #2 has the updated script.

@istio-testing istio-testing merged commit 94d1e90 into istio:master May 10, 2022
@ericvn ericvn deleted the updateDocRefZH branch May 10, 2022 17:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/site infra size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. translation/chinese Translation item
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants