Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

zh-translation: docs/reference/config/networking/destination-rule/ind… #11182

Closed
wants to merge 3 commits into from

Conversation

my-git9
Copy link
Member

@my-git9 my-git9 commented Apr 17, 2022

Please provide a description for what this PR is for.

And to help us figure out who should review this PR, please
put an X in all the areas that this PR affects.

  • Configuration Infrastructure
  • Docs
  • Installation
  • Networking
  • Performance and Scalability
  • Policies and Telemetry
  • Security
  • Test and Release
  • User Experience
  • Developer Infrastructure

@my-git9 my-git9 requested a review from a team as a code owner April 17, 2022 14:12
@istio-testing istio-testing added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Apr 17, 2022
@zirain
Copy link
Member

zirain commented Apr 18, 2022

reference pages ares auto-generated by bots.
@ericvn any update about the infra?

@ericvn
Copy link
Contributor

ericvn commented Apr 19, 2022

@zirain I had looked into the possibility of updating the translated reference docs to match the English versions in a prior PR, but did not get feedback if we should make it happen and I closed it. For reference, it was #10719 and that referred to #10717.

@craigbox Thoughts on re-doing my earlier PR to update the zh version of the reference files as part of our normal automated reference doc updates?

@craigbox
Copy link
Contributor

craigbox commented Apr 19, 2022 via email

@kebe7jun
Copy link
Member

@zirain I had looked into the possibility of updating the translated reference docs to match the English versions in a prior PR, but did not get feedback if we should make it happen and I closed it. For reference, it was #10719 and that referred to #10717.

@craigbox Thoughts on re-doing my earlier PR to update the zh version of the reference files as part of our normal automated reference doc updates?

I think it is necessary to update the reference of zh automatically, this part of the content is not quite suitable for manual translation into Chinese, it may be more obscure and difficult to understand, build at this stage, if the update can be automatic, keep the accuracy of the content I think more good.

@ericvn
Copy link
Contributor

ericvn commented Apr 22, 2022

Talking with @craigbox I think it makes sense to update the translated docs at the same time as the English docs. I'll create a PR for that soon.

@ericvn
Copy link
Contributor

ericvn commented May 2, 2022

#11252 was created to update the zh side of the reference docs at the same time as the en directory. The daily automated job would now update both.

@my-git9 my-git9 closed this May 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/docs size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. translation/chinese Translation item
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants