-
Notifications
You must be signed in to change notification settings - Fork 394
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
start: use tabs for a Windows command #3215
Conversation
Received and error while removing the data file. Remove-Item : Parameter cannot be processed because the parameter name 'f' is ambiguous. Possible matches include: -Filter -Force. I used Force command to make it work
Thanks @mahnoor-shahid but what OS and terminal are you using? |
Windows @jorgeorpinel |
OK. We will be getting to multi-platform examples in the future per #2939. Meanwhile please also consider these recommended POSIX-like interfaces for Windows: https://dvc.org/doc/user-guide/running-dvc-on-windows Thanks |
may be we could slightly modify specifically this place to use tabs? |
no need to all this at once, we could gradually modify them, wdyt, @jorgeorpinel ... could we guide @mahnoor-shahid to slightly change the PR? |
Sure, the info about how to use tabs is currently in #2939 ⌛ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is how you'd use the tab toggle. I'll commit and deploy this to double check... ✔️
<tab title="Windows"> | ||
|
||
``` | ||
> del data\data.xml |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Separate question: Prism doesn't seem to have a Windows Command Prompt language unfortunately. It does have PowerShell but I assume we're going with plain cmd
right @shcheklein ? If so we may need to make a new custom highlighter cc @julieg18 WDYT
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jorgeorpinel I don't think we need a custom highlighter since I think PowerShell runs Windows Command Prompt language as well as its own special syntax. Using the powershell
language should suffice.
How this script would look in powershell
using Prism's Test drive tool:
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
BTW this is deployed to https://dvc-org-patch-1-u1nyq9vcgqv1gr.herokuapp.com/doc/start/data-and-model-versioning#retrieving: |
@@ -175,7 +175,7 @@ $ rm -f data/data.xml | |||
<tab title="Windows"> | |||
|
|||
``` | |||
> rmdir .dvc/cache | |||
> rmdir .dvc\cache |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would keep $ for now. It's not an important detail to be honest.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done.
|
||
``` | ||
> rmdir .dvc\cache | ||
> del data\data.xml |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
what about powershell - it it del or does it support Posix?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not familiar with PowerShell but it looks like it's a totally different command: Remove-Item.
@julieg18 thanks for looking into this. Should it be a check at all? It's an action that help to run a command and schedule, not sure why do we have / need status for it. |
As far as I understand, certain GH Actions hooks like |
Thanks for noticing and addressing the check issue. Separately (since you're here), please notice #3215 (review) above. Thanks p.s. so can we merge this? |
* start: use `powershell` highligher for tab toggles per #3215 (comment) * start: Windows command tabs for Versioning page * start: use `dvc` highlighter (and `$`) for Windows cmd blocks per #3273 (review) * start: Windows code blocks for /tmp location * Apply suggestions from code review
* Changed line 168 ~ from rm -f data/... to rm -Force data/... Received and error while removing the data file. Remove-Item : Parameter cannot be processed because the parameter name 'f' is ambiguous. Possible matches include: -Filter -Force. I used Force command to make it work * Apply suggestions from code review * Update content/docs/start/data-and-model-versioning.md * Update content/docs/start/data-and-model-versioning.md * Update content/docs/start/data-and-model-versioning.md * Update content/docs/start/data-and-model-versioning.md Co-authored-by: Jorge Orpinel <jorgeorpinel@users.noreply.github.com>
* start: use `powershell` highligher for tab toggles per #3215 (comment) * start: Windows command tabs for Versioning page * start: use `dvc` highlighter (and `$`) for Windows cmd blocks per #3273 (review) * start: Windows code blocks for /tmp location * Apply suggestions from code review
Received and error while removing the data file.
Remove-Item : Parameter cannot be processed because the parameter name 'f' is ambiguous. Possible
matches include: -Filter -Force.
I used Force command to make it work.