Fix broken merge-schedule gh action #3346
Conversation
* update if statement in action to check for event type
| @@ -12,7 +12,8 @@ jobs: | |||
| merge_schedule: | |||
| runs-on: ubuntu-latest | |||
| if: | |||
| ${{ github.event.pull_request.head.repo.full_name == github.repository }} | |||
| ${{ github.event_name == 'schedule' || | |||
There was a problem hiding this comment.
Figured out why #3282 wasn't merging! This action runs on pull_request (for finding prs that need to be merged) and on schedule (for actually merging the prs). This if statement was stopping the action from running on schedule. Hopefully, this update, which checks for event_name, should fix the action.
There was a problem hiding this comment.
Do we need to have if statement at all 🤔 ? If I understand correctly, it is mentioned that pull requests from forks are ignored and I believe the pull request is generated when we have /schedule date so the event name would be schedule itself.
There was a problem hiding this comment.
Do we need to have if statement at all 🤔 ?
Yes! The action still runs on forks and fails on them. See #3215 convo. So we put down the if statement (#3267) so that this action will get skipped on forks.
* update if statement in action to check for event type
ifstatement in action to check for event type